X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/3bd92c16704823e79ac61f27d05c1a9be52858f5..88105d9c643519e02082ba9cc5044bb0dfdcb7b9:/app/models/way.rb diff --git a/app/models/way.rb b/app/models/way.rb index 2c9ce9f72..f1dc76eb4 100644 --- a/app/models/way.rb +++ b/app/models/way.rb @@ -3,6 +3,7 @@ class Way < ActiveRecord::Base belongs_to :user + has_many :nodes, :through => :way_nodes, :order => 'sequence_id' has_many :way_nodes, :foreign_key => 'id', :order => 'sequence_id' has_many :way_tags, :foreign_key => 'id' @@ -52,7 +53,9 @@ class Way < ActiveRecord::Base # You can't pull in all the tags too unless we put a sequence_id on the way_tags table and have a multipart key def self.find_eager(id) - way = Way.find(id, :include => [:way_tags, {:way_nodes => :node}]) + way = Way.find(id, :include => {:way_nodes => :node}) + #If waytag had a multipart key that was real, you could do this: + #way = Way.find(id, :include => [:way_tags, {:way_nodes => :node}]) end # Find a way given it's ID, and in a single SQL call also grab its nodes and tags @@ -204,4 +207,50 @@ class Way < ActiveRecord::Base return true end + # Delete the way and it's relations, but don't really delete it - set its visibility to false and update the history etc to maintain wiki-like functionality. + def delete_with_relations_and_history(user) + if self.visible + # FIXME + # this should actually delete the relations, + # not just throw a PreconditionFailed if it's a member of a relation!! + if RelationMember.find(:first, :joins => "INNER JOIN current_relations ON current_relations.id=current_relation_members.id", + :conditions => [ "visible = 1 AND member_type='way' and member_id=?", self.id]) + raise OSM::APIPreconditionFailedError + # end FIXME + else + self.user_id = user.id + self.tags = [] + self.nds = [] + self.visible = false + self.save_with_history! + end + else + raise OSM::APIAlreadyDeletedError + end + end + + # delete a way and it's nodes that aren't part of other ways, with history + def delete_with_relations_and_nodes_and_history(user) + + node_ids = self.nodes.collect {|node| node.id } + node_ids_not_to_delete = [] + way_nodes = WayNode.find(:all, :conditions => "node_id in (#{node_ids.join(',')}) and id != #{self.id}") + + node_ids_not_to_delete = way_nodes.collect {|way_node| way_node.node_id} + + node_ids_to_delete = node_ids - node_ids_not_to_delete + + # delete the nodes not used by other ways + node_ids_to_delete.each do |node_id| + n = Node.find(node_id) + n.user_id = user.id + n.visible = false + n.save_with_history! + end + + self.user_id = user.id + + self.delete_with_relations_and_history(user) + + end end