X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/3d0b94abdafeb04cbdece55ab21d3fb725d59137..d41d52877ed68902c45231a89715470774e7f944:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 5303fb051..d763c6d46 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2022-10-25 17:25:58 UTC using RuboCop version 1.37.1. +# on 2023-01-03 19:11:30 UTC using RuboCop version 1.42.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -14,7 +14,7 @@ require: - rubocop-rails - rubocop-rake -# Offense count: 555 +# Offense count: 556 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns. # URISchemes: http, https @@ -22,6 +22,7 @@ Layout/LineLength: Max: 248 # Offense count: 29 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: @@ -41,18 +42,18 @@ Lint/AssignmentInCondition: - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 676 +# Offense count: 681 # Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: Max: 189 -# Offense count: 72 +# Offense count: 73 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. # AllowedMethods: refine Metrics/BlockLength: Max: 71 -# Offense count: 15 +# Offense count: 20 # Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 @@ -62,12 +63,12 @@ Metrics/BlockNesting: Metrics/ClassLength: Max: 316 -# Offense count: 58 +# Offense count: 60 # Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 25 + Max: 26 -# Offense count: 751 +# Offense count: 755 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. Metrics/MethodLength: Max: 179 @@ -80,11 +81,16 @@ Metrics/ParameterLists: # Offense count: 57 # Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. Metrics/PerceivedComplexity: - Max: 26 + Max: 27 -# Offense count: 559 +# Offense count: 2513 +# This cop supports safe autocorrection (--autocorrect). +Minitest/EmptyLineBeforeAssertionMethods: + Enabled: false + +# Offense count: 564 Minitest/MultipleAssertions: - Max: 52 + Max: 54 # Offense count: 1 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. @@ -96,6 +102,12 @@ Naming/PredicateName: Exclude: - 'app/models/user.rb' +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ActionControllerFlashBeforeRender: + Exclude: + - 'app/controllers/traces_controller.rb' + # Offense count: 5 # Configuration parameters: Database, Include. # SupportedDatabases: mysql, postgresql @@ -153,11 +165,9 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 9 +# Offense count: 7 Rails/OutputSafety: Exclude: - - 'app/controllers/sessions_controller.rb' - - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' @@ -171,7 +181,7 @@ Rake/Desc: - 'lib/tasks/subscribe_diary_authors.rake' - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 625 +# Offense count: 631 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -183,3 +193,10 @@ Style/FrozenStringLiteralComment: # Configuration parameters: Strict, AllowedNumbers, AllowedPatterns. Style/NumericLiterals: MinDigits: 15 + +# Offense count: 110 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: . +# SupportedOperators: *, +, &, |, ^ +Style/YodaExpression: + Enabled: false