X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/4248e10946c9f60020112c969591b867c6f8fb19..7fd1e559383807dd0b509c7a08642f9d3a48616e:/app/controllers/notes_controller.rb diff --git a/app/controllers/notes_controller.rb b/app/controllers/notes_controller.rb index 1de58af90..f577dc2f2 100644 --- a/app/controllers/notes_controller.rb +++ b/app/controllers/notes_controller.rb @@ -1,6 +1,7 @@ class NotesController < ApplicationController layout "site", :only => [:mine] + skip_before_action :verify_authenticity_token, :except => [:mine] before_action :check_api_readable before_action :authorize_web, :only => [:mine] before_action :setup_user_auth, :only => [:create, :comment] @@ -159,7 +160,7 @@ class NotesController < ApplicationController # Find the note and check it is valid @note = Note.find_by(:id => id) raise OSM::APINotFoundError unless @note - raise OSM::APIAlreadyDeletedError.new("note", @note.id) unless @note.visible? || @user.moderator? + raise OSM::APIAlreadyDeletedError.new("note", @note.id) unless @note.visible? || current_user.moderator? raise OSM::APINoteAlreadyOpenError.new(@note) unless @note.closed? || !@note.visible? # Reopen the note and add a comment @@ -278,13 +279,14 @@ class NotesController < ApplicationController def mine if params[:display_name] if @this_user = User.active.find_by(:display_name => params[:display_name]) + @params = params.permit(:display_name) @title = t "note.mine.title", :user => @this_user.display_name @heading = t "note.mine.heading", :user => @this_user.display_name @description = t "note.mine.subheading", :user => render_to_string(:partial => "user", :object => @this_user) @page = (params[:page] || 1).to_i @page_size = 10 @notes = @this_user.notes - @notes = @notes.visible unless @user && @user.moderator? + @notes = @notes.visible unless current_user && current_user.moderator? @notes = @notes.order("updated_at DESC, id").distinct.offset((@page - 1) * @page_size).limit(@page_size).preload(:comments => :author).to_a else @title = t "user.no_such_user.title" @@ -339,8 +341,8 @@ class NotesController < ApplicationController def add_comment(note, text, event, notify = true) attributes = { :visible => true, :event => event, :body => text } - if @user - attributes[:author_id] = @user.id + if current_user + attributes[:author_id] = current_user.id else attributes[:author_ip] = request.remote_ip end @@ -348,7 +350,7 @@ class NotesController < ApplicationController comment = note.comments.create!(attributes) note.comments.map(&:author).uniq.each do |user| - if notify && user && user != @user && user.visible? + if notify && user && user != current_user && user.visible? Notifier.note_comment_notification(comment, user).deliver_now end end