X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/4eafa04ff8059f475ebfbec2cedeeee1773a9c8b..4ee48d2ad971ec8133e3ca46a5df054ad8e267de:/app/controllers/application.rb diff --git a/app/controllers/application.rb b/app/controllers/application.rb index bfd2e9c54..3d16ffa69 100644 --- a/app/controllers/application.rb +++ b/app/controllers/application.rb @@ -95,14 +95,49 @@ class ApplicationController < ActionController::Base # rather than only a status code and having the web engine make up a # phrase from that, we can also put the error message into the status # message. For now, rails won't let us) - def report_error(message) - render :text => message, :status => :bad_request + def report_error(message, status = :bad_request) # Todo: some sort of escaping of problem characters in the message response.headers['Error'] = message + render :text => message, :status => status + end + + def set_locale + I18n.locale = request.compatible_language_from(I18n.available_locales) end -private + def api_call_handle_error + begin + yield + rescue ActiveRecord::RecordNotFound => ex + render :nothing => true, :status => :not_found + rescue LibXML::XML::Error, ArgumentError => ex + report_error ex.message, :bad_request + rescue ActiveRecord::RecordInvalid => ex + message = "#{ex.record.class} #{ex.record.id}: " + ex.record.errors.each { |attr,msg| message << "#{attr}: #{msg} (#{ex.record[attr].inspect})" } + report_error message, :bad_request + rescue OSM::APIError => ex + report_error ex.message, ex.status + rescue Exception => ex + report_error "#{ex.class}: #{ex.message}", :internal_server_error + end + end + ## + # asserts that the request method is the +method+ given as a parameter + # or raises a suitable error. +method+ should be a symbol, e.g: :put or :get. + def assert_method(method) + ok = request.send((method.to_s.downcase + "?").to_sym) + raise OSM::APIBadMethodError.new(method) unless ok + end + + def api_call_timeout + Timeout::timeout(APP_CONFIG['api_timeout'], OSM::APITimeoutError) do + yield + end + end + +private # extract authorisation credentials from headers, returns user = nil if none def get_auth_data if request.env.has_key? 'X-HTTP_AUTHORIZATION' # where mod_rewrite might have put it