X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/544113affae90f5ca661021a980ab0a9c2c2b2d1..4b669ec1ae7470f68a9e00b6caffcc4a44240b7a:/test/functional/notes_controller_test.rb diff --git a/test/functional/notes_controller_test.rb b/test/functional/notes_controller_test.rb index 99faec25f..4bd0aa6cf 100644 --- a/test/functional/notes_controller_test.rb +++ b/test/functional/notes_controller_test.rb @@ -343,28 +343,47 @@ class NotesControllerTest < ActionController::TestCase end def test_note_delete_success - delete :destroy, {:id => notes(:open_note_with_comment).id} + delete :destroy, {:id => notes(:open_note_with_comment).id, :text => "This is a hide comment", :format => "json"} assert_response :unauthorized basic_authorization(users(:public_user).email, "test") - delete :destroy, {:id => notes(:open_note_with_comment).id} + delete :destroy, {:id => notes(:open_note_with_comment).id, :text => "This is a hide comment", :format => "json"} + assert_response :forbidden + + basic_authorization(users(:moderator_user).email, "test") + + delete :destroy, {:id => notes(:open_note_with_comment).id, :text => "This is a hide comment", :format => "json"} assert_response :success + js = ActiveSupport::JSON.decode(@response.body) + assert_not_nil js + assert_equal "Feature", js["type"] + assert_equal notes(:open_note_with_comment).id, js["properties"]["id"] + assert_equal "hidden", js["properties"]["status"] + assert_equal 3, js["properties"]["comments"].count + assert_equal "hidden", js["properties"]["comments"].last["action"] + assert_equal "This is a hide comment", js["properties"]["comments"].last["text"] + assert_equal "moderator", js["properties"]["comments"].last["user"] get :show, {:id => notes(:open_note_with_comment).id, :format => 'json'} assert_response :gone end def test_note_delete_fail - delete :destroy, {:id => 12345} + delete :destroy, {:id => 12345, :format => "json"} assert_response :unauthorized basic_authorization(users(:public_user).email, "test") - delete :destroy, {:id => 12345} + delete :destroy, {:id => 12345, :format => "json"} + assert_response :forbidden + + basic_authorization(users(:moderator_user).email, "test") + + delete :destroy, {:id => 12345, :format => "json"} assert_response :not_found - delete :destroy, {:id => notes(:hidden_note_with_comment).id} + delete :destroy, {:id => notes(:hidden_note_with_comment).id, :format => "json"} assert_response :gone end