X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/5449cf4adcc1fad4b9f43426e6d3e4a8f65e6fbb..f3ff36418b60a56f18525900720e6ff9d21f516d:/test/unit/relation_tag_test.rb

diff --git a/test/unit/relation_tag_test.rb b/test/unit/relation_tag_test.rb
index 5c008fc34..81bcd60ac 100644
--- a/test/unit/relation_tag_test.rb
+++ b/test/unit/relation_tag_test.rb
@@ -1,10 +1,10 @@
 require File.dirname(__FILE__) + '/../test_helper'
 
-class RelationTagTest < Test::Unit::TestCase
+class RelationTagTest < ActiveSupport::TestCase
   api_fixtures
   
   def test_relation_tag_count
-    assert_equal 3, RelationTag.count
+    assert_equal 7, RelationTag.count
   end
   
   def test_length_key_valid
@@ -14,7 +14,7 @@ class RelationTagTest < Test::Unit::TestCase
       tag.id = 1
       tag.k = key*i
       tag.v = "v"
-      assert_valid tag
+      assert tag.valid?
     end
   end
   
@@ -25,7 +25,7 @@ class RelationTagTest < Test::Unit::TestCase
       tag.id = 1
       tag.k = "k"
       tag.v = val*i
-      assert_valid tag
+      assert tag.valid?
     end
   end
   
@@ -67,4 +67,28 @@ class RelationTagTest < Test::Unit::TestCase
     assert_raise(ActiveRecord::RecordInvalid) {tag.save!}
     assert tag.new_record?
   end
+
+  ##
+  # test that tags can be updated and saved uniquely, i.e: tag.save!
+  # only affects the single tag that the activerecord object 
+  # represents. this amounts to testing that the primary key is
+  # unique.
+  #
+  # Commenting this out - I attempted to fix it, but composite primary keys
+  # wasn't playing nice with the column already called :id. Seemed to be 
+  # impossible to have validations on the :id column. If someone knows better
+  # please fix, otherwise this test is shelved.
+  #
+  # def test_update
+  #   v = "probably unique string here 3142592654"
+  #   assert_equal 0, RelationTag.count(:conditions => ['v=?', v])
+
+  #   # make sure we select a tag on a relation which has more than one tag
+  #   id = current_relations(:multi_tag_relation).id
+  #   tag = RelationTag.find(:first, :conditions => ["id = ?", id])
+  #   tag.v = v
+  #   tag.save!
+
+  #   assert_equal 1, RelationTag.count(:conditions => ['v=?', v])
+  # end
 end