X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/58e95f7ea46accda6359b187ce5936aad4ac5945..2cfd5b97a83ab27f51e2d44ab832194f098d1eb7:/app/helpers/browse_tags_helper.rb diff --git a/app/helpers/browse_tags_helper.rb b/app/helpers/browse_tags_helper.rb index 375300e14..d4294daaa 100644 --- a/app/helpers/browse_tags_helper.rb +++ b/app/helpers/browse_tags_helper.rb @@ -17,8 +17,16 @@ module BrowseTagsHelper link_to(w[:title], w[:url], :title => t("browse.tag_details.wikidata_link", :page => w[:title].strip)) end safe_join(wdt, ";") + elsif wmc = wikimedia_commons_link(key, value) + link_to h(wmc[:title]), wmc[:url], :title => t("browse.tag_details.wikimedia_commons_link", :page => wmc[:title]) elsif url = wiki_link("tag", "#{key}=#{value}") link_to h(value), url, :title => t("browse.tag_details.wiki_link.tag", :key => key, :value => value) + elsif emails = email_links(key, value) + # similarly, email_links() returns an array of emails + emails = emails.map do |e| + link_to(h(e[:email]), e[:url], :title => t("browse.tag_details.email_link", :email => e[:email])) + end + safe_join(emails, "; ") elsif phones = telephone_links(key, value) # similarly, telephone_links() returns an array of phone numbers phones = phones.map do |p| @@ -111,6 +119,39 @@ module BrowseTagsHelper nil end + def wikimedia_commons_link(key, value) + if key == "wikimedia_commons" && value =~ /^(?:file|category):/i + return { + :url => "//commons.wikimedia.org/wiki/#{value}?uselang=#{I18n.locale}", + :title => value + } + end + nil + end + + def email_links(_key, value) + # Does value look like an email? eg "someone@domain.tld" + # or a list of alternate emails separated by ; + + # Uses WHATWG implementation of email validation, which follows RFC 1123 + # but is a willful violation of RFC 5322. + # (see: https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address) + if value.match?(%r{^\s*[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+ + @[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*\s* + (;\s*[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+ + @[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*\s*)*$ + }x) + return value.split(";").map do |email| + # remove any leading or trailing whitespace if present + email = email.strip + + # add 'mailto:'' prefix + { :email => email, :url => "mailto:#{email}" } + end + end + nil + end + def telephone_links(_key, value) # Does it look like a global phone number? eg "+1 (234) 567-8901 " # or a list of alternate numbers separated by ;