X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/5a6f4c5690d3f7292e6c96ea7170c741306665e3..dcbc807526b5eb456e33e22d794374ae7ff3723b:/app/controllers/user_preference_controller.rb diff --git a/app/controllers/user_preference_controller.rb b/app/controllers/user_preference_controller.rb index b22c52240..d02313497 100644 --- a/app/controllers/user_preference_controller.rb +++ b/app/controllers/user_preference_controller.rb @@ -1,8 +1,43 @@ +# Update and read user preferences, which are arbitrayr key/val pairs class UserPreferenceController < ApplicationController before_filter :authorize + before_filter :require_allow_read_prefs, :only => [:read_one, :read] + before_filter :require_allow_write_prefs, :except => [:read_one, :read] - def read + def read_one + pref = UserPreference.find(@user.id, params[:preference_key]) + + render :text => pref.v.to_s + rescue ActiveRecord::RecordNotFound => ex + render :text => 'OH NOES! PREF NOT FOUND!', :status => :not_found + end + + def update_one + begin + pref = UserPreference.find(@user.id, params[:preference_key]) + pref.v = request.raw_post.chomp + pref.save + rescue ActiveRecord::RecordNotFound + pref = UserPreference.new + pref.user = @user + pref.k = params[:preference_key] + pref.v = request.raw_post.chomp + pref.save + end + + render :nothing => true + end + def delete_one + UserPreference.delete(@user.id, params[:preference_key]) + + render :nothing => true + rescue ActiveRecord::RecordNotFound => ex + render :text => "param: #{params[:preference_key]} not found", :status => :not_found + end + + # print out all the preferences as a big xml block + def read doc = OSM::API.new.get_xml_doc prefs = @user.preferences @@ -15,54 +50,50 @@ class UserPreferenceController < ApplicationController doc.root << el1 render :text => doc.to_s, :content_type => "text/xml" - end + # update the entire set of preferences def update begin - p = XML::Parser.new - p.string = request.raw_post - doc = p.parse - - prefs = [] - - keyhash = {} - - doc.find('//preferences/preference').each do |pt| - pref = UserPreference.new - - unless keyhash[pt['k']].nil? # already have that key - render :text => 'OH NOES! CAN HAS UNIQUE KEYS?', :status => :not_acceptable - return - end - - keyhash[pt['k']] = 1 - - pref.k = pt['k'] - pref.v = pt['v'] - pref.user_id = @user.id - prefs << pref - end + p = XML::Parser.string(request.raw_post) + rescue LibXML::XML::Error, ArgumentError => ex + raise OSM::APIBadXMLError.new("preferences", xml, ex.message) + end + doc = p.parse - if prefs.size > 150 - render :text => 'Too many preferences', :status => :request_entity_too_large - return - end + prefs = [] - # kill the existing ones - UserPreference.delete_all(['user_id = ?', @user.id]) + keyhash = {} - # save the new ones - prefs.each do |pref| - pref.save! + doc.find('//preferences/preference').each do |pt| + pref = UserPreference.new + + unless keyhash[pt['k']].nil? # already have that key + render :text => 'OH NOES! CAN HAS UNIQUE KEYS?', :status => :not_acceptable end - rescue Exception => ex - render :text => 'OH NOES! FAIL!: ' + ex.to_s, :status => :internal_server_error - return + keyhash[pt['k']] = 1 + + pref.k = pt['k'] + pref.v = pt['v'] + pref.user_id = @user.id + prefs << pref end + if prefs.size > 150 + render :text => 'Too many preferences', :status => :request_entity_too_large + end + + # kill the existing ones + UserPreference.delete_all(['user_id = ?', @user.id]) + + # save the new ones + prefs.each do |pref| + pref.save! + end render :nothing => true - end + rescue Exception => ex + render :text => 'OH NOES! FAIL!: ' + ex.to_s, :status => :internal_server_error + end end