X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/5e8fd6e6cbf974999395f6199a3862823e1ca357..506731031dc919c4342aecb4254cc177eac9ade5:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 342275040..307a23f4b 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,26 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2019-06-05 09:04:25 +0100 using RuboCop version 0.71.0. +# on 2019-10-19 16:05:52 +0000 using RuboCop version 0.75.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 33 +# Work around erblint issues. +# https://github.com/openstreetmap/openstreetmap-website/issues/2472 +require: + - rubocop-minitest + - rubocop-performance + - rubocop-rails + +# Offense count: 3338 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 260 + +# Offense count: 35 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: @@ -27,51 +41,52 @@ Lint/AssignmentInCondition: # Offense count: 4 # Configuration parameters: AllowComments. -Lint/HandleExceptions: +Lint/SuppressedException: Exclude: - 'app/controllers/api/amf_controller.rb' - 'app/controllers/users_controller.rb' + - 'app/controllers/site_controller.rb' -# Offense count: 703 +# Offense count: 701 Metrics/AbcSize: - Max: 279 + Max: 189 -# Offense count: 40 +# Offense count: 39 # Configuration parameters: CountComments, ExcludedMethods. # ExcludedMethods: refine Metrics/BlockLength: - Max: 263 + Max: 71 # Offense count: 15 # Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 68 +# Offense count: 25 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 1397 + Max: 645 -# Offense count: 73 +# Offense count: 74 Metrics/CyclomaticComplexity: Max: 22 -# Offense count: 714 +# Offense count: 722 # Configuration parameters: CountComments, ExcludedMethods. Metrics/MethodLength: Max: 179 -# Offense count: 1 +# Offense count: 2 # Configuration parameters: CountComments. Metrics/ModuleLength: - Max: 107 + Max: 117 # Offense count: 4 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 9 -# Offense count: 71 +# Offense count: 72 Metrics/PerceivedComplexity: Max: 25 @@ -100,12 +115,13 @@ Naming/PredicateName: - 'app/models/user.rb' - 'lib/classic_pagination/pagination.rb' -# Offense count: 1 -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/ActiveRecordOverride: +# Offense count: 5 +# Cop supports --auto-correct. +Performance/RegexpMatch: Exclude: - - 'app/models/trace.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/validators/characters_validator.rb' + - 'app/validators/whitespace_validator.rb' # Offense count: 6 # Configuration parameters: Database, Include. @@ -172,11 +188,20 @@ Style/AsciiComments: Exclude: - 'test/models/message_test.rb' -# Offense count: 255 -Style/Documentation: - Enabled: false - -# Offense count: 503 +# Offense count: 27 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: annotated, template, unannotated +Style/FormatStringToken: + Exclude: + - 'app/models/concerns/geo_record.rb' + - 'app/views/api/map/_bounds.xml.builder' + - 'lib/bounding_box.rb' + - 'test/controllers/api/map_controller_test.rb' + - 'test/controllers/api/relations_controller_test.rb' + - 'test/controllers/api/ways_controller_test.rb' + - 'test/lib/bounding_box_test.rb' + +# Offense count: 539 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, never @@ -189,15 +214,8 @@ Style/IfUnlessModifier: Exclude: - 'app/controllers/api/ways_controller.rb' -# Offense count: 74 +# Offense count: 70 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: MinDigits: 11 - -# Offense count: 3320 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 1073