X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/6bca4b66d14f01f716af0f11ddb96c275a3ad0dd..3170600b9c6a1a42a1b2385fff08eca1c5f07b26:/test/unit/relation_tag_test.rb

diff --git a/test/unit/relation_tag_test.rb b/test/unit/relation_tag_test.rb
index 38c8af22b..81bcd60ac 100644
--- a/test/unit/relation_tag_test.rb
+++ b/test/unit/relation_tag_test.rb
@@ -1,11 +1,94 @@
 require File.dirname(__FILE__) + '/../test_helper'
 
-class RelationTagTest < Test::Unit::TestCase
-  fixtures :current_relation_tags
-  set_fixture_class :current_relation_tags => RelationTag
+class RelationTagTest < ActiveSupport::TestCase
+  api_fixtures
   
   def test_relation_tag_count
-    assert_equal 3, RelationTag.count
+    assert_equal 7, RelationTag.count
   end
   
+  def test_length_key_valid
+    key = "k"
+    (0..255).each do |i|
+      tag = RelationTag.new
+      tag.id = 1
+      tag.k = key*i
+      tag.v = "v"
+      assert tag.valid?
+    end
+  end
+  
+  def test_length_value_valid
+    val = "v"
+    (0..255).each do |i|
+      tag = RelationTag.new
+      tag.id = 1
+      tag.k = "k"
+      tag.v = val*i
+      assert tag.valid?
+    end
+  end
+  
+  def test_length_key_invalid
+    ["k"*256].each do |i|
+      tag = RelationTag.new
+      tag.id = 1
+      tag.k = i
+      tag.v = "v"
+      assert !tag.valid?, "Key #{i} should be too long"
+      assert tag.errors.invalid?(:k)
+    end
+  end
+  
+  def test_length_value_invalid
+    ["v"*256].each do |i|
+      tag = RelationTag.new
+      tag.id = 1
+      tag.k = "k"
+      tag.v = i
+      assert !tag.valid?, "Value #{i} should be too long"
+      assert tag.errors.invalid?(:v)
+    end
+  end
+  
+  def test_empty_tag_invalid
+    tag = RelationTag.new
+    assert !tag.valid?, "Empty relation tag should be invalid"
+    assert tag.errors.invalid?(:id)
+  end
+  
+  def test_uniquness
+    tag = RelationTag.new
+    tag.id = current_relation_tags(:t1).id
+    tag.k = current_relation_tags(:t1).k
+    tag.v = current_relation_tags(:t1).v
+    assert tag.new_record?
+    assert !tag.valid?
+    assert_raise(ActiveRecord::RecordInvalid) {tag.save!}
+    assert tag.new_record?
+  end
+
+  ##
+  # test that tags can be updated and saved uniquely, i.e: tag.save!
+  # only affects the single tag that the activerecord object 
+  # represents. this amounts to testing that the primary key is
+  # unique.
+  #
+  # Commenting this out - I attempted to fix it, but composite primary keys
+  # wasn't playing nice with the column already called :id. Seemed to be 
+  # impossible to have validations on the :id column. If someone knows better
+  # please fix, otherwise this test is shelved.
+  #
+  # def test_update
+  #   v = "probably unique string here 3142592654"
+  #   assert_equal 0, RelationTag.count(:conditions => ['v=?', v])
+
+  #   # make sure we select a tag on a relation which has more than one tag
+  #   id = current_relations(:multi_tag_relation).id
+  #   tag = RelationTag.find(:first, :conditions => ["id = ?", id])
+  #   tag.v = v
+  #   tag.save!
+
+  #   assert_equal 1, RelationTag.count(:conditions => ['v=?', v])
+  # end
 end