X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/6c51b3cc0ad7e193c7dae3794502088faab37c7b..1e2b99a75b4b87855fbb3397fc87c462306dea5d:/app/controllers/notes_controller.rb diff --git a/app/controllers/notes_controller.rb b/app/controllers/notes_controller.rb index a297748bd..bf28d4c25 100644 --- a/app/controllers/notes_controller.rb +++ b/app/controllers/notes_controller.rb @@ -155,8 +155,8 @@ class NotesController < ApplicationController # Find the note and check it is valid @note = Note.find_by_id(id) raise OSM::APINotFoundError unless @note - raise OSM::APIAlreadyDeletedError.new("note", @note.id) unless @note.visible? - raise OSM::APINoteAlreadyOpenError.new(@note) unless @note.closed? + raise OSM::APIAlreadyDeletedError.new("note", @note.id) unless @note.visible? or @user.moderator? + raise OSM::APINoteAlreadyOpenError.new(@note) unless @note.closed? or not @note.visible? # Reopen the note and add a comment Note.transaction do @@ -260,6 +260,11 @@ class NotesController < ApplicationController # Find the notes we want to return @notes = @notes.order("updated_at DESC").limit(result_limit).preload(:comments) + # Disable notes search until we can make it scalable + response.headers['Error'] = "Searching of notes is currently unavailable" + render :text => "", :status => :service_unavailable + return false + # Render the result respond_to do |format| format.rss { render :action => :index } @@ -308,8 +313,12 @@ private ## # Get the maximum number of results to return def result_limit - if params[:limit] and params[:limit].to_i > 0 and params[:limit].to_i < 10000 - params[:limit].to_i + if params[:limit] + if params[:limit].to_i > 0 and params[:limit].to_i < 10000 + params[:limit].to_i + else + raise OSM::APIBadUserInput.new("Note limit must be between 1 and 9999") + end else 100 end