X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/7a1615bc55aee72dd03a5dd43c08b4f13f669f06..cad185a83caf5518c1b3f85f2759cbb9bec45daf:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 307a23f4b..32514771c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2019-10-19 16:05:52 +0000 using RuboCop version 0.75.0. +# on 2021-06-29 17:25:37 UTC using RuboCop version 1.18.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -12,15 +12,16 @@ require: - rubocop-minitest - rubocop-performance - rubocop-rails + - rubocop-rake -# Offense count: 3338 +# Offense count: 510 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 260 + Max: 270 -# Offense count: 35 +# Offense count: 34 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: @@ -33,27 +34,30 @@ Lint/AssignmentInCondition: - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_tags_helper.rb' - - 'app/mailers/notifier.rb' + - 'app/mailers/user_mailer.rb' - 'app/models/client_application.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 4 -# Configuration parameters: AllowComments. -Lint/SuppressedException: +# Offense count: 8 +# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. +Lint/DuplicateBranch: Exclude: - - 'app/controllers/api/amf_controller.rb' - - 'app/controllers/users_controller.rb' - - 'app/controllers/site_controller.rb' + - 'app/controllers/api_controller.rb' + - 'app/controllers/diary_entries_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'lib/password_hash.rb' -# Offense count: 701 +# Offense count: 631 +# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: - Max: 189 + Max: 235 -# Offense count: 39 -# Configuration parameters: CountComments, ExcludedMethods. -# ExcludedMethods: refine +# Offense count: 68 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# IgnoredMethods: refine Metrics/BlockLength: Max: 71 @@ -63,51 +67,64 @@ Metrics/BlockNesting: Max: 5 # Offense count: 25 -# Configuration parameters: CountComments. +# Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 645 + Max: 361 -# Offense count: 74 +# Offense count: 56 +# Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 22 + Max: 25 -# Offense count: 722 -# Configuration parameters: CountComments, ExcludedMethods. +# Offense count: 703 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. Metrics/MethodLength: Max: 179 -# Offense count: 2 -# Configuration parameters: CountComments. -Metrics/ModuleLength: - Max: 117 - -# Offense count: 4 -# Configuration parameters: CountKeywordArgs. +# Offense count: 1 +# Configuration parameters: CountKeywordArgs, MaxOptionalParameters. Metrics/ParameterLists: - Max: 9 + Max: 6 -# Offense count: 72 +# Offense count: 60 +# Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: - Max: 25 + Max: 26 -# Offense count: 6 +# Offense count: 519 +Minitest/MultipleAssertions: + Max: 88 + +# Offense count: 4 Naming/AccessorMethodName: Exclude: - 'app/controllers/application_controller.rb' - 'app/helpers/title_helper.rb' - - 'app/models/old_way.rb' - 'lib/osm.rb' - - 'lib/potlatch.rb' + +# Offense count: 21 +# Configuration parameters: CheckIdentifiers, CheckConstants, CheckVariables, CheckStrings, CheckSymbols, CheckComments, CheckFilepaths, FlaggedTerms. +Naming/InclusiveLanguage: + Exclude: + - 'app/controllers/sessions_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/views/api/capabilities/show.builder' + - 'app/views/confirmations/_resend_success_flash.html.erb' + - 'app/views/users/suspended.html.erb' + - 'config/environments/production.rb' + - 'config/initializers/canonical_rails.rb' + - 'config/initializers/config.rb' + - 'config/initializers/doorkeeper.rb' # Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? # MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: - - 'spec/**/*' - 'app/models/changeset.rb' - 'app/models/old_node.rb' - 'app/models/old_relation.rb' @@ -116,21 +133,12 @@ Naming/PredicateName: - 'lib/classic_pagination/pagination.rb' # Offense count: 5 -# Cop supports --auto-correct. -Performance/RegexpMatch: - Exclude: - - 'app/helpers/browse_tags_helper.rb' - - 'app/validators/characters_validator.rb' - - 'app/validators/whitespace_validator.rb' - -# Offense count: 6 # Configuration parameters: Database, Include. # SupportedDatabases: mysql, postgresql # Include: db/migrate/*.rb Rails/BulkChangeTable: Exclude: - 'db/migrate/20111116184519_update_oauth.rb' - - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb' - 'db/migrate/20120208194454_add_domain_to_acl.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' @@ -142,14 +150,19 @@ Rails/HasAndBelongsToMany: - 'app/models/changeset.rb' - 'app/models/user.rb' -# Offense count: 11 +# Offense count: 3 # Configuration parameters: Include. # Include: app/helpers/**/*.rb Rails/HelperInstanceVariable: Exclude: - - 'app/helpers/application_helper.rb' - 'app/helpers/title_helper.rb' - - 'app/helpers/trace_helper.rb' + +# Offense count: 1 +# Configuration parameters: Include. +# Include: app/controllers/**/*.rb +Rails/LexicallyScopedActionFilter: + Exclude: + - 'app/controllers/oauth2_applications_controller.rb' # Offense count: 5 # Configuration parameters: Include. @@ -162,60 +175,40 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 18 +# Offense count: 9 Rails/OutputSafety: Exclude: + - 'app/controllers/sessions_controller.rb' - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changesets_helper.rb' - - 'app/helpers/geocoder_helper.rb' - - 'app/helpers/note_helper.rb' - - 'app/helpers/open_graph_helper.rb' - - 'app/helpers/user_blocks_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 94 +# Offense count: 91 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: Enabled: false -# Offense count: 1 -# Configuration parameters: AllowedChars. -Style/AsciiComments: +# Offense count: 6 +# Cop supports --auto-correct. +Rake/Desc: Exclude: - - 'test/models/message_test.rb' + - 'lib/tasks/auto_annotate_models.rake' + - 'lib/tasks/eslint.rake' + - 'lib/tasks/subscribe_diary_authors.rake' + - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 27 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: annotated, template, unannotated -Style/FormatStringToken: - Exclude: - - 'app/models/concerns/geo_record.rb' - - 'app/views/api/map/_bounds.xml.builder' - - 'lib/bounding_box.rb' - - 'test/controllers/api/map_controller_test.rb' - - 'test/controllers/api/relations_controller_test.rb' - - 'test/controllers/api/ways_controller_test.rb' - - 'test/lib/bounding_box_test.rb' - -# Offense count: 539 +# Offense count: 597 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: always, never +# SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 2 -# Cop supports --auto-correct. -Style/IfUnlessModifier: - Exclude: - - 'app/controllers/api/ways_controller.rb' - -# Offense count: 70 +# Offense count: 73 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: - MinDigits: 11 + MinDigits: 15