X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/7f556f94f1d479346cbefb5cbeec0a6a0b7b8547..b01261760893de04dda650a427ceb59beea80004:/app/controllers/diary_entry_controller.rb?ds=sidebyside diff --git a/app/controllers/diary_entry_controller.rb b/app/controllers/diary_entry_controller.rb index b9eb1c2d6..f87b02ef9 100644 --- a/app/controllers/diary_entry_controller.rb +++ b/app/controllers/diary_entry_controller.rb @@ -8,8 +8,9 @@ class DiaryEntryController < ApplicationController before_filter :check_database_writable, :only => [:new, :edit] before_filter :require_administrator, :only => [:hide, :hidecomment] - caches_action :list, :view, :layout => false + caches_action :list, :layout => false, :unless => :user_specific_list? caches_action :rss, :layout => true + caches_action :view, :layout => false cache_sweeper :diary_sweeper, :only => [:new, :edit, :comment, :hide, :hidecomment] def new @@ -71,7 +72,7 @@ class DiaryEntryController < ApplicationController def list if params[:display_name] - @this_user = User.where(:status => ["active", "confirmed"]).find_by_display_name(params[:display_name]) + @this_user = User.active.find_by_display_name(params[:display_name]) if @this_user @title = t 'diary_entry.list.user_title', :user => @this_user.display_name @@ -98,6 +99,34 @@ class DiaryEntryController < ApplicationController }, :order => 'created_at DESC', :per_page => 20) + elsif params[:friends] + if @user + @title = t 'diary_entry.list.title_friends' + @entry_pages, @entries = paginate(:diary_entries, :include => :user, + :conditions => { + :user_id => @user.friend_users, + :visible => true + }, + :order => 'created_at DESC', + :per_page => 20) + else + require_user + return + end + elsif params[:nearby] + if @user + @title = t 'diary_entry.list.title_nearby' + @entry_pages, @entries = paginate(:diary_entries, :include => :user, + :conditions => { + :user_id => @user.nearby, + :visible => true + }, + :order => 'created_at DESC', + :per_page => 20) + else + require_user + return + end else @title = t 'diary_entry.list.title' @entry_pages, @entries = paginate(:diary_entries, :include => :user, @@ -114,10 +143,10 @@ class DiaryEntryController < ApplicationController @entries = DiaryEntry.includes(:user).order("created_at DESC").limit(20) if params[:display_name] - user = User.where("status IN ('active', 'confirmed')").find_by_display_name(params[:display_name]) + user = User.active.find_by_display_name(params[:display_name]) if user - @entries = @entries.where(:user_id => user.id, :visible => true ) + @entries = user.diary_entries.visible @title = I18n.t('diary_entry.feed.user.title', :user => user.display_name) @description = I18n.t('diary_entry.feed.user.description', :user => user.display_name) @link = "http://#{SERVER_URL}/user/#{user.display_name}/diary" @@ -125,15 +154,12 @@ class DiaryEntryController < ApplicationController render :nothing => true, :status => :not_found end elsif params[:language] - @entries = @entries.where(:users => { :status => ["active", "confirmed"] }, - :visible => true, - :language_code => params[:language]) + @entries = @entries.visible.where(:language_code => params[:language]).joins(:user).where(:users => { :status => ["active", "confirmed"] }) @title = I18n.t('diary_entry.feed.language.title', :language_name => Language.find(params[:language]).english_name) @description = I18n.t('diary_entry.feed.language.description', :language_name => Language.find(params[:language]).english_name) @link = "http://#{SERVER_URL}/diary/#{params[:language]}" else - @entries = @entries.where(:users => { :status => ["active", "confirmed"] }, - :visible => true) + @entries = @entries.visible.joins(:user).where(:users => { :status => ["active", "confirmed"] }) @title = I18n.t('diary_entry.feed.all.title') @description = I18n.t('diary_entry.feed.all.description') @link = "http://#{SERVER_URL}/diary" @@ -141,12 +167,10 @@ class DiaryEntryController < ApplicationController end def view - user = User.where("status IN ('active', 'confirmed')").find_by_display_name(params[:display_name]) + user = User.active.find_by_display_name(params[:display_name]) if user - @entry = DiaryEntry.where(:id => params[:id], - :user_id => user.id, - :visible => true).first + @entry = user.diary_entries.visible.where(:id => params[:id]).first if @entry @title = t 'diary_entry.view.title', :user => params[:display_name], :title => @entry.title else @@ -171,6 +195,22 @@ class DiaryEntryController < ApplicationController comment.update_attributes(:visible => false) redirect_to :action => "view", :display_name => comment.diary_entry.user.display_name, :id => comment.diary_entry.id end + + def comments + @this_user = User.active.find_by_display_name(params[:display_name]) + + if @this_user + @comment_pages, @comments = paginate(:diary_comments, + :conditions => { :user_id => @this_user }, + :order => 'created_at DESC', + :per_page => 20) + @page = (params[:page] || 1).to_i + else + @title = t'diary_entry.no_such_user.title' + @not_found_user = params[:display_name] + render :action => 'no_such_user', :status => :not_found + end + end private ## # require that the user is a administrator, or fill out a helpful error message @@ -181,4 +221,10 @@ private redirect_to :controller => 'diary_entry', :action => 'view', :display_name => params[:id] end end + + ## + # is this list user specific? + def user_specific_list? + params[:friends] or params[:nearby] + end end