X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/85f197b6df81cef19fe6a2a1cfc0429ea50051c7..d07277efba0c0069705bbefa68f2624a9c6c9ff0:/app/models/node.rb

diff --git a/app/models/node.rb b/app/models/node.rb
index b83d934a2..dfc603376 100644
--- a/app/models/node.rb
+++ b/app/models/node.rb
@@ -1,12 +1,16 @@
 class Node < ActiveRecord::Base
   require 'xml/libxml'
   set_table_name 'current_nodes'
+  
+
+  validates_numericality_of :latitude
+  validates_numericality_of :longitude
+  # FIXME validate lat and lon within the world
 
   has_many :old_nodes, :foreign_key => :id
   belongs_to :user
 
 
-
   def self.from_xml(xml, create=false)
     p = XML::Parser.new
     p.string = xml
@@ -24,16 +28,20 @@ class Node < ActiveRecord::Base
         return nil
       end
 
-      if pt['id'] != '0'
-        node.id = pt['id'].to_i
+      unless create
+        if pt['id'] != '0'
+          node.id = pt['id'].to_i
+        end
       end
 
-      node.visible = pt['visible'] == '1'
+      node.visible = pt['visible'] and pt['visible'] == 'true'
 
       if create
         node.timestamp = Time.now
       else
-        node.timestamp = Time.parse(pt['timestamp'])
+        if pt['timestamp']
+          node.timestamp = Time.parse(pt['timestamp'])
+        end
       end
 
       tags = []
@@ -54,41 +62,39 @@ class Node < ActiveRecord::Base
   def save_with_history
     begin
       Node.transaction do
-        old_node = OldNode.from_node(this)
-        this.save
+        self.save
+        old_node = OldNode.from_node(self)
         old_node.save
       end
       return true
     rescue Exception => ex
       return nil
-
     end
   end
 
-  def self.to_xml
+  def to_xml
     doc = XML::Document.new
-
-    doc.encoding = "UTF-8"  
+    doc.encoding = 'UTF-8' 
     root = XML::Node.new 'osm'
-    root['version'] = '0.4'
+    root['version'] = API_VERSION
     root['generator'] = 'OpenStreetMap server'
     doc.root = root
-    el1 = XML::Node.new 'node'
-    el1['id'] = this.id.to_s
-    el1['lat'] = this.latitude.to_s
-    el1['lon'] = this.longitude.to_s
-    split_tags(el1, this.tags)
-    el1['visible'] = thiss.visible.to_s
-    el1['timestamp'] = this.timestamp.xmlschema
-    root << el1
-
-    return root
-
+    root << to_xml_node()
+    return doc
   end
 
+  def to_xml_node
+    el1 = XML::Node.new 'node'
+    el1['id'] = self.id.to_s
+    el1['lat'] = self.latitude.to_s
+    el1['lon'] = self.longitude.to_s
+    Node.split_tags(el1, self.tags)
+    el1['visible'] = self.visible.to_s
+    el1['timestamp'] = self.timestamp.xmlschema
+    return el1
+  end
 
-  private
-  def split_tags(el, tags)
+  def self.split_tags(el, tags)
     tags.split(';').each do |tag|
       parts = tag.split('=')
       key = ''
@@ -96,14 +102,11 @@ class Node < ActiveRecord::Base
       key = parts[0].strip unless parts[0].nil?
       val = parts[1].strip unless parts[1].nil?
       if key != '' && val != ''
-        el2 = Node.new('tag')
+        el2 = XML::Node.new('tag')
         el2['k'] = key.to_s
         el2['v'] = val.to_s
         el << el2
       end
     end
   end
-
-
-
 end