X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/86b4d1bc2c05a68053c7485217144a7fcf8ef4e8..328d47e506972fededfa1080967224928c36a4cf:/app/controllers/node_controller.rb diff --git a/app/controllers/node_controller.rb b/app/controllers/node_controller.rb index 379ee77c9..03ae64f41 100644 --- a/app/controllers/node_controller.rb +++ b/app/controllers/node_controller.rb @@ -13,10 +13,13 @@ class NodeController < ApplicationController def create if request.put? node = Node.from_xml(request.raw_post, true) + # FIXME remove debug + logger.debug request.raw_post + logger.debug node if node node.version = 0 - node.user_id = @user.id + #node.changeset_id = node.changeset node.visible = true node.save_with_history! @@ -43,6 +46,21 @@ class NodeController < ApplicationController render :nothing => true, :status => :not_found end end + + # Dump a specific version of the node based on the given params[:id] and params[:version] + def version + begin + node = Node.find(:first, :conditions => { :id => params[:id], :version => params[:version] } ) + if node.visible + response.headers['Last-Modified'] = node.timestamp.rfc822 + render :text => node.to_xml.to_s, :content_type => "text/xml" + else + render :nothing => true, :status => :gone + end + rescue ActiveRecord::RecordNotFound + render :nothing => true, :status => :not_found + end + end # Update a node from given XML def update @@ -56,7 +74,7 @@ class NodeController < ApplicationController else render :nothing => true, :status => :bad_request end - rescue OSM::APIVersionMismatchError ex + rescue OSM::APIVersionMismatchError => ex render :text => "Version mismatch: Provided " + ex.provided.to_s + ", server had: " + ex.latest.to_s, :status => :bad_request rescue ActiveRecord::RecordNotFound @@ -70,12 +88,12 @@ class NodeController < ApplicationController begin node = Node.find(params[:id]) node.delete_with_history(@user) + + render :nothing => true rescue ActiveRecord::RecordNotFound render :nothing => true, :status => :not_found - rescue OSM::APIAlreadyDeletedError - render :text => "", :status => :gone - rescue OSM::APIPreconditionFailedError - render :text => "", :status => :precondition_failed + rescue OSM::APIError => ex + render ex.render_opts end end