X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/8bd09c082897d808c4641f94836f5cfa4cbbf95c..457d66eb5b5b390257e318dd8258228db4de5b92:/app/controllers/user_controller.rb diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb index 354e8c66f..9a1d89da6 100644 --- a/app/controllers/user_controller.rb +++ b/app/controllers/user_controller.rb @@ -2,8 +2,8 @@ class UserController < ApplicationController layout 'site' before_filter :authorize, :only => [:preferences, :api_details, :api_gpx_files] - before_filter :authorize_web, :only => [:edit, :account, :go_public, :view, :diary] - before_filter :require_user, :only => [:edit, :set_home, :account, :go_public] + before_filter :authorize_web, :only => [:edit, :account, :go_public, :view, :diary, :make_friend] + before_filter :require_user, :only => [:edit, :set_home, :account, :go_public, :make_friend] def save @user = User.new(params[:user]) @@ -28,7 +28,7 @@ class UserController < ApplicationController @user.home_lat = home_lat.to_f @user.home_lon = home_lon.to_f if @user.save - flash[:notice] = "User edited OK." + flash[:notice] = "User information updated successfully." redirect_to :controller => 'user', :action => 'account' end end @@ -39,7 +39,7 @@ class UserController < ApplicationController @user.home_lat = params[:user][:home_lat].to_f @user.home_lon = params[:user][:home_lon].to_f if @user.save - flash[:notice] = "User home saved." + flash[:notice] = "Home location saved successfully." redirect_to :controller => 'user', :action => 'account' end end @@ -48,21 +48,23 @@ class UserController < ApplicationController def go_public @user.data_public = true @user.save - flash[:notice] = 'All your edits are now public' - redirect_to :controller => 'user', :action => 'account' + flash[:notice] = 'All your edits are now public.' + redirect_to :controller => 'user', :action => 'account', :display_name => @user.display_name end def lost_password - if params['user']['email'] + if params[:user] and params[:user][:email] user = User.find_by_email(params['user']['email']) if user user.token = User.make_token user.save Notifier::deliver_lost_password(user) - flash[:notice] = "Sorry you lost it :-( but an email is on it's way so you can reset it soon." + flash[:notice] = "Sorry you lost it :-( but an email is on its way so you can reset it soon." else flash[:notice] = "Couldn't find that email address, sorry." end + else + render :action => 'lost_password' end end @@ -72,9 +74,11 @@ class UserController < ApplicationController if user pass = User.make_token(8) user.pass_crypt = pass + user.pass_crypt_confirmation = pass + user.active = true user.save Notifier::deliver_reset_password(user, pass) - flash[:notice] = "You're password has been changed and is on the way to your mailbox :-)" + flash[:notice] = "Your password has been changed and is on its way to your mailbox :-)" else flash[:notice] = "Didn't find that token, check the URL maybe?" end @@ -95,10 +99,14 @@ class UserController < ApplicationController u.timeout = 1.day.from_now u.save session[:token] = u.token - redirect_to :controller => 'site', :action => 'index' + if params[:next_controller] and params[:next_action] + redirect_to :controller => params[:next_controller], :action => params[:next_action] + else + redirect_to :controller => 'site', :action => 'index' + end return else - flash[:notice] = "Couldn't log in with those details" + flash[:notice] = "Sorry, couldn't log in with those details." end end end @@ -113,7 +121,11 @@ class UserController < ApplicationController end end session[:token] = nil - redirect_to :controller => 'site', :action => 'index' + if params[:next_controller] and params[:next_action] + redirect_to :controller => params[:next_controller], :action => params[:next_action] + else + redirect_to :controller => 'site', :action => 'index' + end end def confirm @@ -127,7 +139,7 @@ class UserController < ApplicationController redirect_to :action => 'login' else - flash[:notice] = 'Something went wrong confirming that user' + flash[:notice] = 'Something went wrong confirming that user.' end end @@ -162,15 +174,25 @@ class UserController < ApplicationController def diary @this_user = User.find_by_display_name(params[:display_name]) end - - def contact_others(user_id, message_body) - @to = User.find_by_id(user_id) - @to.messages.new = body - if @to.save - flash[:notice] = Message sent + + def make_friend + + if params[:display_name] + name = params[:display_name] + friend = Friend.new + friend.user_id = @user.id + friend.friend_user_id = User.find_by_display_name(name).id + unless @user.is_friends_with?(friend) + if friend.save + flash[:notice] = "#{name} is now your friend." + else + friend.add_error("Sorry, failed to add #{name} as a friend.") + end + else + flash[:notice] = "You are already friends with #{name}." + end + redirect_to :controller => 'user', :action => 'view' end - - #Send a message to other users - maybe there's a rails messaging plugin end end