X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/8c1a5d62f8b2f5491f7d476cdcbd0d4121903079..77f9aec772eb4bb1a413e310dd30a8532dccab5c:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 809cde374..f04b39c25 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,19 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2019-06-05 09:04:25 +0100 using RuboCop version 0.71.0. +# on 2020-07-31 18:09:40 UTC using RuboCop version 0.86.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 33 +# Offense count: 565 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 370 + +# Offense count: 36 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: @@ -25,18 +32,12 @@ Lint/AssignmentInCondition: - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 4 -# Configuration parameters: AllowComments. -Lint/HandleExceptions: - Exclude: - - 'app/controllers/api/amf_controller.rb' - - 'app/controllers/users_controller.rb' - -# Offense count: 703 +# Offense count: 739 +# Configuration parameters: IgnoredMethods. Metrics/AbcSize: - Max: 279 + Max: 189 -# Offense count: 40 +# Offense count: 72 # Configuration parameters: CountComments, ExcludedMethods. # ExcludedMethods: refine Metrics/BlockLength: @@ -47,31 +48,28 @@ Metrics/BlockLength: Metrics/BlockNesting: Max: 5 -# Offense count: 68 +# Offense count: 25 # Configuration parameters: CountComments. Metrics/ClassLength: Max: 645 -# Offense count: 73 +# Offense count: 68 +# Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 22 + Max: 28 -# Offense count: 714 +# Offense count: 735 # Configuration parameters: CountComments, ExcludedMethods. Metrics/MethodLength: Max: 179 -# Offense count: 1 -# Configuration parameters: CountComments. -Metrics/ModuleLength: - Max: 107 - # Offense count: 4 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 9 -# Offense count: 71 +# Offense count: 73 +# Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: Max: 25 @@ -85,10 +83,10 @@ Naming/AccessorMethodName: - 'lib/potlatch.rb' # Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? # MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: @@ -100,14 +98,13 @@ Naming/PredicateName: - 'app/models/user.rb' - 'lib/classic_pagination/pagination.rb' -# Offense count: 6 +# Offense count: 5 # Configuration parameters: Database, Include. # SupportedDatabases: mysql, postgresql # Include: db/migrate/*.rb Rails/BulkChangeTable: Exclude: - 'db/migrate/20111116184519_update_oauth.rb' - - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb' - 'db/migrate/20120208194454_add_domain_to_acl.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' @@ -139,7 +136,7 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 18 +# Offense count: 19 Rails/OutputSafety: Exclude: - 'app/controllers/users_controller.rb' @@ -152,7 +149,7 @@ Rails/OutputSafety: - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 94 +# Offense count: 95 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible @@ -165,32 +162,28 @@ Style/AsciiComments: Exclude: - 'test/models/message_test.rb' -# Offense count: 255 -Style/Documentation: - Enabled: false - -# Offense count: 503 +# Offense count: 32 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: annotated, template, unannotated +Style/FormatStringToken: + Exclude: + - 'app/models/concerns/geo_record.rb' + - 'app/views/api/map/_bounds.xml.builder' + - 'lib/bounding_box.rb' + - 'test/controllers/api/map_controller_test.rb' + - 'test/controllers/api/relations_controller_test.rb' + - 'test/controllers/api/ways_controller_test.rb' + - 'test/lib/bounding_box_test.rb' + +# Offense count: 572 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: always, never +# SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 2 -# Cop supports --auto-correct. -Style/IfUnlessModifier: - Exclude: - - 'app/controllers/api/ways_controller.rb' - -# Offense count: 74 +# Offense count: 78 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: MinDigits: 11 - -# Offense count: 3320 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 307