X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/8d76be71bbb8a799cbf0627dee170f26ade5a11f..d41d52877ed68902c45231a89715470774e7f944:/test/helpers/browse_tags_helper_test.rb
diff --git a/test/helpers/browse_tags_helper_test.rb b/test/helpers/browse_tags_helper_test.rb
index 3aa851ef9..a0f716974 100644
--- a/test/helpers/browse_tags_helper_test.rb
+++ b/test/helpers/browse_tags_helper_test.rb
@@ -22,6 +22,9 @@ class BrowseTagsHelperTest < ActionView::TestCase
html = format_value("unknown", "unknown")
assert_dom_equal "unknown", html
+ html = format_value("addr:street", "Rue de l'Amigo")
+ assert_dom_equal "Rue de l'Amigo", html
+
html = format_value("phone", "+1234567890")
assert_dom_equal "+1234567890", html
@@ -46,6 +49,15 @@ class BrowseTagsHelperTest < ActionView::TestCase
html = format_value("colour", "#f00")
assert_dom_equal %(#f00), html
+
+ html = format_value("email", "foo@example.com")
+ assert_dom_equal "foo@example.com", html
+
+ html = format_value("source", "https://example.com")
+ assert_dom_equal "https://example.com", html
+
+ html = format_value("source", "https://example.com;hello;https://example.net")
+ assert_dom_equal "https://example.com;hello;https://example.net", html
end
def test_wiki_link
@@ -120,6 +132,10 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_equal "//www.wikidata.org/entity/Q24?uselang=en", links[0][:url]
assert_equal "Q24", links[0][:title]
+ links = wikidata_links("species:wikidata", "Q26899")
+ assert_equal "//www.wikidata.org/entity/Q26899?uselang=en", links[0][:url]
+ assert_equal "Q26899", links[0][:title]
+
# Another allowed key, this time with multiple values and I18n
I18n.with_locale "dsb" do
links = wikidata_links("brand:wikidata", "Q936;Q2013;Q1568346")
@@ -169,11 +185,11 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_equal "de:Englischer Garten (München)#Japanisches Teehaus", link[:title]
link = wikipedia_link("wikipedia", "de:Alte Brücke (Heidelberg)#Brückenaffe")
- assert_equal "https://de.wikipedia.org/wiki/de:Alte Brücke (Heidelberg)?uselang=en#Br.C3.BCckenaffe", link[:url]
+ assert_equal "https://de.wikipedia.org/wiki/de:Alte Brücke (Heidelberg)?uselang=en#Br%C3%BCckenaffe", link[:url]
assert_equal "de:Alte Brücke (Heidelberg)#Brückenaffe", link[:title]
link = wikipedia_link("wikipedia", "de:Liste der Baudenkmäler in Eichstätt#BrückenstraÃe 1, Ehemaliges Bauernhaus")
- assert_equal "https://de.wikipedia.org/wiki/de:Liste der Baudenkmäler in Eichstätt?uselang=en#Br.C3.BCckenstra.C3.9Fe_1.2C_Ehemaliges_Bauernhaus", link[:url]
+ assert_equal "https://de.wikipedia.org/wiki/de:Liste der Baudenkmäler in Eichstätt?uselang=en#Br%C3%BCckenstra%C3%9Fe_1%2C_Ehemaliges_Bauernhaus", link[:url]
assert_equal "de:Liste der Baudenkmäler in Eichstätt#BrückenstraÃe 1, Ehemaliges Bauernhaus", link[:title]
I18n.with_locale "pt-BR" do
@@ -182,6 +198,10 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_equal "zh-classical:Test#Section", link[:title]
end
+ link = wikipedia_link("subject:wikipedia", "en:Catherine McAuley")
+ assert_equal "https://en.wikipedia.org/wiki/en:Catherine McAuley?uselang=en", link[:url]
+ assert_equal "en:Catherine McAuley", link[:title]
+
link = wikipedia_link("foo", "Test")
assert_nil link
end
@@ -240,29 +260,29 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_nil email
email = email_link("email", "x@example.com")
- assert_equal "x@example.com", email[:email]
- assert_equal "mailto:x@example.com", email[:url]
+ assert_equal "x@example.com", email
email = email_link("email", "other.email-with-hyphen@example.com")
- assert_equal "other.email-with-hyphen@example.com", email[:email]
- assert_equal "mailto:other.email-with-hyphen@example.com", email[:url]
+ assert_equal "other.email-with-hyphen@example.com", email
email = email_link("email", "user.name+tag+sorting@example.com")
- assert_equal "user.name+tag+sorting@example.com", email[:email]
- assert_equal "mailto:user.name+tag+sorting@example.com", email[:url]
+ assert_equal "user.name+tag+sorting@example.com", email
email = email_link("email", "dash-in@both-parts.com")
- assert_equal "dash-in@both-parts.com", email[:email]
- assert_equal "mailto:dash-in@both-parts.com", email[:url]
+ assert_equal "dash-in@both-parts.com", email
email = email_link("email", "example@s.example")
- assert_equal "example@s.example", email[:email]
- assert_equal "mailto:example@s.example", email[:url]
+ assert_equal "example@s.example", email
# Strips whitespace at ends
email = email_link("email", " test@email.com ")
- assert_equal "test@email.com", email[:email]
- assert_equal "mailto:test@email.com", email[:url]
+ assert_equal "test@email.com", email
+
+ email = email_link("contact:email", "example@example.com")
+ assert_equal "example@example.com", email
+
+ email = email_link("maxweight:conditional", "none@agricultural")
+ assert_nil email
end
def test_telephone_links