X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/a32076abd6369b74ac81db5eeffbc40bdf64d597..be40536440b8677323bcf30bc2b869e36f907dd9:/test/controllers/diary_entry_controller_test.rb?ds=sidebyside

diff --git a/test/controllers/diary_entry_controller_test.rb b/test/controllers/diary_entry_controller_test.rb
index 77d340ffe..d926f2656 100644
--- a/test/controllers/diary_entry_controller_test.rb
+++ b/test/controllers/diary_entry_controller_test.rb
@@ -1,7 +1,7 @@
 require "test_helper"
 
 class DiaryEntryControllerTest < ActionController::TestCase
-  fixtures :users, :user_roles, :languages, :friends
+  fixtures :users, :user_roles, :languages
 
   include ActionView::Helpers::NumberHelper
 
@@ -440,7 +440,8 @@ class DiaryEntryControllerTest < ActionController::TestCase
   end
 
   def test_list_friends
-    diary_entry = create(:diary_entry, :user_id => friends(:normal_user_with_second_user).friend_user_id)
+    friend = create(:friend, :user_id => users(:normal_user).id)
+    diary_entry = create(:diary_entry, :user_id => friend.friend_user_id)
     _other_entry = create(:diary_entry, :user_id => users(:second_public_user).id)
 
     # Try a list of diary entries for your friends when not logged in
@@ -662,8 +663,6 @@ class DiaryEntryControllerTest < ActionController::TestCase
     assert_response :not_found
   end
 
-  ##
-  # test subscribe success
   def test_subscribe_success
     diary_entry = create(:diary_entry, :user_id => users(:normal_user).id)
 
@@ -673,13 +672,11 @@ class DiaryEntryControllerTest < ActionController::TestCase
     assert_response :redirect
   end
 
-  ##
-  # test subscribe fail
   def test_subscribe_fail
     diary_entry = create(:diary_entry, :user_id => users(:normal_user).id)
 
     # not signed in
-    assert_no_difference "diary_entry.subscribers.count", 1 do
+    assert_no_difference "diary_entry.subscribers.count" do
       post :subscribe, :id => diary_entry.id, :display_name => diary_entry.user.display_name
     end
     assert_response :forbidden
@@ -691,12 +688,10 @@ class DiaryEntryControllerTest < ActionController::TestCase
     # trying to subscribe when already subscribed
     post :subscribe, { :id => diary_entry.id, :display_name => diary_entry.user.display_name }, { :user => users(:public_user).id }
     assert_no_difference "diary_entry.subscribers.count" do
-      post :subscribe, { :id => diary_entry.id, :display_name => diary_entry.user.display_name}, { :user => users(:public_user).id }
+      post :subscribe, { :id => diary_entry.id, :display_name => diary_entry.user.display_name }, { :user => users(:public_user).id }
     end
   end
 
-  ##
-  # test unsubscribe success
   def test_unsubscribe_success
     diary_entry = create(:diary_entry, :user_id => users(:normal_user).id)
 
@@ -707,8 +702,6 @@ class DiaryEntryControllerTest < ActionController::TestCase
     assert_response :redirect
   end
 
-  ##
-  # test unsubscribe fail
   def test_unsubscribe_fail
     diary_entry = create(:diary_entry, :user_id => users(:normal_user).id)
 
@@ -722,7 +715,7 @@ class DiaryEntryControllerTest < ActionController::TestCase
     post :unsubscribe, { :id => 999111, :display_name => "username" }, { :user => users(:public_user).id }
     assert_response :not_found
 
-    # trying to subscribe when already subscribed
+    # trying to unsubscribe when not subscribed
     assert_no_difference "diary_entry.subscribers.count" do
       post :unsubscribe, { :id => diary_entry.id, :display_name => diary_entry.user.display_name }, { :user => users(:public_user).id }
     end