X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/a790c47923ae5722743ba168eb79f3beabe8a71e..562e7e7d32c945a0f99442e38953da8402fdd997:/test/helpers/browse_tags_helper_test.rb
diff --git a/test/helpers/browse_tags_helper_test.rb b/test/helpers/browse_tags_helper_test.rb
index 195bd69de..0af0d9310 100644
--- a/test/helpers/browse_tags_helper_test.rb
+++ b/test/helpers/browse_tags_helper_test.rb
@@ -4,14 +4,6 @@ class BrowseTagsHelperTest < ActionView::TestCase
include ERB::Util
include ApplicationHelper
- def setup
- I18n.locale = "en"
- end
-
- def teardown
- I18n.locale = "en"
- end
-
def test_format_key
html = format_key("highway")
assert_dom_equal "highway", html
@@ -30,6 +22,9 @@ class BrowseTagsHelperTest < ActionView::TestCase
html = format_value("unknown", "unknown")
assert_dom_equal "unknown", html
+ html = format_value("addr:street", "Rue de l'Amigo")
+ assert_dom_equal "Rue de l'Amigo", html
+
html = format_value("phone", "+1234567890")
assert_dom_equal "+1234567890", html
@@ -43,10 +38,26 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_dom_equal "Q42", html
html = format_value("operator:wikidata", "Q12;Q98")
- assert_dom_equal "Q12;Q98", html
+ assert_dom_equal "Q12;" \
+ "Q98", html
html = format_value("name:etymology:wikidata", "Q123")
assert_dom_equal "Q123", html
+
+ html = format_value("wikimedia_commons", "File:Test.jpg")
+ assert_dom_equal "File:Test.jpg", html
+
+ html = format_value("colour", "#f00")
+ assert_dom_equal %(#f00), html
+
+ html = format_value("email", "foo@example.com")
+ assert_dom_equal "foo@example.com", html
+
+ html = format_value("source", "https://example.com")
+ assert_dom_equal "https://example.com", html
+
+ html = format_value("source", "https://example.com;hello;https://example.net")
+ assert_dom_equal "https://example.com;hello;https://example.net", html
end
def test_wiki_link
@@ -56,21 +67,21 @@ class BrowseTagsHelperTest < ActionView::TestCase
link = wiki_link("tag", "highway=primary")
assert_equal "https://wiki.openstreetmap.org/wiki/Tag:highway=primary?uselang=en", link
- I18n.locale = "de"
+ I18n.with_locale "de" do
+ link = wiki_link("key", "highway")
+ assert_equal "https://wiki.openstreetmap.org/wiki/DE:Key:highway?uselang=de", link
- link = wiki_link("key", "highway")
- assert_equal "https://wiki.openstreetmap.org/wiki/DE:Key:highway?uselang=de", link
-
- link = wiki_link("tag", "highway=primary")
- assert_equal "https://wiki.openstreetmap.org/wiki/DE:Tag:highway=primary?uselang=de", link
+ link = wiki_link("tag", "highway=primary")
+ assert_equal "https://wiki.openstreetmap.org/wiki/DE:Tag:highway=primary?uselang=de", link
+ end
- I18n.locale = "tr"
-
- link = wiki_link("key", "highway")
- assert_equal "https://wiki.openstreetmap.org/wiki/Tr:Key:highway?uselang=tr", link
+ I18n.with_locale "tr" do
+ link = wiki_link("key", "highway")
+ assert_equal "https://wiki.openstreetmap.org/wiki/Tr:Key:highway?uselang=tr", link
- link = wiki_link("tag", "highway=primary")
- assert_equal "https://wiki.openstreetmap.org/wiki/Tag:highway=primary?uselang=tr", link
+ link = wiki_link("tag", "highway=primary")
+ assert_equal "https://wiki.openstreetmap.org/wiki/Tag:highway=primary?uselang=tr", link
+ end
end
def test_wikidata_links
@@ -103,12 +114,12 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_equal "Q42", links[0][:title]
# the language of the wikidata-page should match the current locale
- I18n.locale = "zh-CN"
- links = wikidata_links("wikidata", "Q1234")
- assert_equal 1, links.length
- assert_equal "//www.wikidata.org/entity/Q1234?uselang=zh-CN", links[0][:url]
- assert_equal "Q1234", links[0][:title]
- I18n.locale = "en"
+ I18n.with_locale "zh-CN" do
+ links = wikidata_links("wikidata", "Q1234")
+ assert_equal 1, links.length
+ assert_equal "//www.wikidata.org/entity/Q1234?uselang=zh-CN", links[0][:url]
+ assert_equal "Q1234", links[0][:title]
+ end
### Prefixed wikidata-tags
@@ -121,17 +132,21 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_equal "//www.wikidata.org/entity/Q24?uselang=en", links[0][:url]
assert_equal "Q24", links[0][:title]
+ links = wikidata_links("species:wikidata", "Q26899")
+ assert_equal "//www.wikidata.org/entity/Q26899?uselang=en", links[0][:url]
+ assert_equal "Q26899", links[0][:title]
+
# Another allowed key, this time with multiple values and I18n
- I18n.locale = "dsb"
- links = wikidata_links("brand:wikidata", "Q936;Q2013;Q1568346")
- assert_equal 3, links.length
- assert_equal "//www.wikidata.org/entity/Q936?uselang=dsb", links[0][:url]
- assert_equal "Q936", links[0][:title]
- assert_equal "//www.wikidata.org/entity/Q2013?uselang=dsb", links[1][:url]
- assert_equal "Q2013", links[1][:title]
- assert_equal "//www.wikidata.org/entity/Q1568346?uselang=dsb", links[2][:url]
- assert_equal "Q1568346", links[2][:title]
- I18n.locale = "en"
+ I18n.with_locale "dsb" do
+ links = wikidata_links("brand:wikidata", "Q936;Q2013;Q1568346")
+ assert_equal 3, links.length
+ assert_equal "//www.wikidata.org/entity/Q936?uselang=dsb", links[0][:url]
+ assert_equal "Q936", links[0][:title]
+ assert_equal "//www.wikidata.org/entity/Q2013?uselang=dsb", links[1][:url]
+ assert_equal "Q2013", links[1][:title]
+ assert_equal "//www.wikidata.org/entity/Q1568346?uselang=dsb", links[2][:url]
+ assert_equal "Q1568346", links[2][:title]
+ end
# and now with whitespaces...
links = wikidata_links("subject:wikidata", "Q6542248 ;\tQ180\n ;\rQ364\t\n\r ;\nQ4006")
@@ -170,23 +185,106 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_equal "de:Englischer Garten (München)#Japanisches Teehaus", link[:title]
link = wikipedia_link("wikipedia", "de:Alte Brücke (Heidelberg)#Brückenaffe")
- assert_equal "https://de.wikipedia.org/wiki/de:Alte Brücke (Heidelberg)?uselang=en#Br.C3.BCckenaffe", link[:url]
+ assert_equal "https://de.wikipedia.org/wiki/de:Alte Brücke (Heidelberg)?uselang=en#Br%C3%BCckenaffe", link[:url]
assert_equal "de:Alte Brücke (Heidelberg)#Brückenaffe", link[:title]
link = wikipedia_link("wikipedia", "de:Liste der Baudenkmäler in Eichstätt#BrückenstraÃe 1, Ehemaliges Bauernhaus")
- assert_equal "https://de.wikipedia.org/wiki/de:Liste der Baudenkmäler in Eichstätt?uselang=en#Br.C3.BCckenstra.C3.9Fe_1.2C_Ehemaliges_Bauernhaus", link[:url]
+ assert_equal "https://de.wikipedia.org/wiki/de:Liste der Baudenkmäler in Eichstätt?uselang=en#Br%C3%BCckenstra%C3%9Fe_1%2C_Ehemaliges_Bauernhaus", link[:url]
assert_equal "de:Liste der Baudenkmäler in Eichstätt#BrückenstraÃe 1, Ehemaliges Bauernhaus", link[:title]
- I18n.locale = "pt-BR"
+ I18n.with_locale "pt-BR" do
+ link = wikipedia_link("wikipedia", "zh-classical:Test#Section")
+ assert_equal "https://zh-classical.wikipedia.org/wiki/zh-classical:Test?uselang=pt-BR#Section", link[:url]
+ assert_equal "zh-classical:Test#Section", link[:title]
+ end
- link = wikipedia_link("wikipedia", "zh-classical:Test#Section")
- assert_equal "https://zh-classical.wikipedia.org/wiki/zh-classical:Test?uselang=pt-BR#Section", link[:url]
- assert_equal "zh-classical:Test#Section", link[:title]
+ link = wikipedia_link("subject:wikipedia", "en:Catherine McAuley")
+ assert_equal "https://en.wikipedia.org/wiki/en:Catherine McAuley?uselang=en", link[:url]
+ assert_equal "en:Catherine McAuley", link[:title]
link = wikipedia_link("foo", "Test")
assert_nil link
end
+ def test_wikimedia_commons_link
+ link = wikimedia_commons_link("wikimedia_commons", "http://commons.wikimedia.org/wiki/File:Full%20URL.jpg")
+ assert_nil link
+
+ link = wikimedia_commons_link("wikimedia_commons", "https://commons.wikimedia.org/wiki/File:Full%20URL.jpg")
+ assert_nil link
+
+ link = wikimedia_commons_link("wikimedia_commons", "Test.jpg")
+ assert_nil link
+
+ link = wikimedia_commons_link("wikimedia_commons", "File:Test.jpg")
+ assert_equal "//commons.wikimedia.org/wiki/File:Test.jpg?uselang=en", link[:url]
+ assert_equal "File:Test.jpg", link[:title]
+
+ link = wikimedia_commons_link("wikimedia_commons", "Category:Test_Category")
+ assert_equal "//commons.wikimedia.org/wiki/Category:Test_Category?uselang=en", link[:url]
+ assert_equal "Category:Test_Category", link[:title]
+
+ I18n.with_locale "pt-BR" do
+ link = wikimedia_commons_link("wikimedia_commons", "File:Test.jpg")
+ assert_equal "//commons.wikimedia.org/wiki/File:Test.jpg?uselang=pt-BR", link[:url]
+ assert_equal "File:Test.jpg", link[:title]
+ end
+
+ link = wikimedia_commons_link("foo", "Test")
+ assert_nil link
+ end
+
+ def test_email_link
+ email = email_link("foo", "Test")
+ assert_nil email
+
+ email = email_link("email", "123")
+ assert_nil email
+
+ email = email_link("email", "Abc.example.com")
+ assert_nil email
+
+ email = email_link("email", "a@b@c.com")
+ assert_nil email
+
+ email = email_link("email", "just\"not\"right@example.com")
+ assert_nil email
+
+ email = email_link("email", "123 abcdefg@space.com")
+ assert_nil email
+
+ email = email_link("email", "test@ abc")
+ assert_nil email
+
+ email = email_link("email", "using;semicolon@test.com")
+ assert_nil email
+
+ email = email_link("email", "x@example.com")
+ assert_equal "x@example.com", email
+
+ email = email_link("email", "other.email-with-hyphen@example.com")
+ assert_equal "other.email-with-hyphen@example.com", email
+
+ email = email_link("email", "user.name+tag+sorting@example.com")
+ assert_equal "user.name+tag+sorting@example.com", email
+
+ email = email_link("email", "dash-in@both-parts.com")
+ assert_equal "dash-in@both-parts.com", email
+
+ email = email_link("email", "example@s.example")
+ assert_equal "example@s.example", email
+
+ # Strips whitespace at ends
+ email = email_link("email", " test@email.com ")
+ assert_equal "test@email.com", email
+
+ email = email_link("contact:email", "example@example.com")
+ assert_equal "example@example.com", email
+
+ email = email_link("maxweight:conditional", "none@agricultural")
+ assert_nil email
+ end
+
def test_telephone_links
links = telephone_links("foo", "Test")
assert_nil links
@@ -260,4 +358,106 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_equal "+22(33)4455.66.7788", links[1][:phone_number]
assert_equal "tel:+22(33)4455.66.7788", links[1][:url]
end
+
+ def test_colour_preview
+ # basic positive tests
+ colour = colour_preview("colour", "red")
+ assert_equal "red", colour
+
+ colour = colour_preview("colour", "Red")
+ assert_equal "Red", colour
+
+ colour = colour_preview("colour", "darkRed")
+ assert_equal "darkRed", colour
+
+ colour = colour_preview("colour", "#f00")
+ assert_equal "#f00", colour
+
+ colour = colour_preview("colour", "#fF0000")
+ assert_equal "#fF0000", colour
+
+ # other tag variants:
+ colour = colour_preview("building:colour", "#f00")
+ assert_equal "#f00", colour
+
+ colour = colour_preview("ref:colour", "#f00")
+ assert_equal "#f00", colour
+
+ colour = colour_preview("int_ref:colour", "green")
+ assert_equal "green", colour
+
+ colour = colour_preview("roof:colour", "#f00")
+ assert_equal "#f00", colour
+
+ colour = colour_preview("seamark:beacon_lateral:colour", "#f00")
+ assert_equal "#f00", colour
+
+ # negative tests:
+ colour = colour_preview("colour", "")
+ assert_nil colour
+
+ colour = colour_preview("colour", " ")
+ assert_nil colour
+
+ colour = colour_preview("colour", nil)
+ assert_nil colour
+
+ # ignore US spelling variant
+ colour = colour_preview("color", "red")
+ assert_nil colour
+
+ # irrelevant tag names
+ colour = colour_preview("building", "red")
+ assert_nil colour
+
+ colour = colour_preview("ref:colour_no", "red")
+ assert_nil colour
+
+ colour = colour_preview("ref:colour-bg", "red")
+ assert_nil colour
+
+ colour = colour_preview("int_ref", "red")
+ assert_nil colour
+
+ # invalid hex codes
+ colour = colour_preview("colour", "#")
+ assert_nil colour
+
+ colour = colour_preview("colour", "#ff")
+ assert_nil colour
+
+ colour = colour_preview("colour", "#ffff")
+ assert_nil colour
+
+ colour = colour_preview("colour", "#fffffff")
+ assert_nil colour
+
+ colour = colour_preview("colour", "#ggg")
+ assert_nil colour
+
+ colour = colour_preview("colour", "#ff 00 00")
+ assert_nil colour
+
+ # invalid w3c color names:
+ colour = colour_preview("colour", "r")
+ assert_nil colour
+
+ colour = colour_preview("colour", "ffffff")
+ assert_nil colour
+
+ colour = colour_preview("colour", "f00")
+ assert_nil colour
+
+ colour = colour_preview("colour", "xxxred")
+ assert_nil colour
+
+ colour = colour_preview("colour", "dark red")
+ assert_nil colour
+
+ colour = colour_preview("colour", "dark_red")
+ assert_nil colour
+
+ colour = colour_preview("colour", "ADarkDummyLongColourNameWithAPurpleUndertone")
+ assert_nil colour
+ end
end