X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/a9824dbc2e8763e6fff6f71db7a31cc4761cd245..34e3e51456774127d43408b7ab65c24f41373f62:/app/controllers/user_blocks_controller.rb diff --git a/app/controllers/user_blocks_controller.rb b/app/controllers/user_blocks_controller.rb index e681a194a..f530eec91 100644 --- a/app/controllers/user_blocks_controller.rb +++ b/app/controllers/user_blocks_controller.rb @@ -34,15 +34,15 @@ class UserBlocksController < ApplicationController end def create - if @valid_params - @user_block = UserBlock.new({ + if @valid_params + @user_block = UserBlock.new( :user_id => @this_user.id, :creator_id => @user.id, :reason => params[:user_block][:reason], :ends_at => Time.now.getutc() + @block_period.hours, :needs_view => params[:user_block][:needs_view] - }, :without_protection => true) - + ) + if @user_block.save flash[:notice] = t('user_block.create.flash', :name => @this_user.display_name) redirect_to @user_block @@ -54,16 +54,16 @@ class UserBlocksController < ApplicationController end end - def update - if @valid_params + def update + if @valid_params if @user_block.creator_id != @user.id flash[:error] = t('user_block.update.only_creator_can_edit') redirect_to :action => "edit" - elsif @user_block.update_attributes({ + elsif @user_block.update_attributes( :ends_at => Time.now.getutc() + @block_period.hours, :reason => params[:user_block][:reason], :needs_view => params[:user_block][:needs_view] - }, :without_protection => true) + ) flash[:notice] = t('user_block.update.success') redirect_to(@user_block) else @@ -106,28 +106,6 @@ class UserBlocksController < ApplicationController end private - ## - # require that the user is a moderator, or fill out a helpful error message - # and return them to the blocks index. - def require_moderator - unless @user.moderator? - if request.get? - flash[:error] = t('user_block.filter.not_a_moderator') - redirect_to :action => 'index' - else - render :nothing => true, :status => :forbidden - end - end - end - - ## - # ensure that there is a "this_user" instance variable - def lookup_this_user - unless @this_user = User.find_by_display_name(params[:display_name]) - render_unknown_user params[:display_name] - end - end - ## # ensure that there is a "user_block" instance variable def lookup_user_block @@ -147,10 +125,10 @@ class UserBlocksController < ApplicationController if !UserBlock::PERIODS.include?(@block_period) flash[:error] = t('user_block.filter.block_period') - + elsif @user_block and !@user_block.active? flash[:error] = t('user_block.filter.block_expired') - + else @valid_params = true end