X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/b0747c3c1e2c3f437fb5e94e85c2f329680f3ee0..4f05b6a8accae4877f81e617262a52cf0428cf8f:/test/functional/browse_controller_test.rb diff --git a/test/functional/browse_controller_test.rb b/test/functional/browse_controller_test.rb index 9ba8dd8f0..e2937c5d8 100644 --- a/test/functional/browse_controller_test.rb +++ b/test/functional/browse_controller_test.rb @@ -39,6 +39,10 @@ class BrowseControllerTest < ActionController::TestCase { :path => "/browse/changeset/1", :method => :get }, { :controller => "browse", :action => "changeset", :id => "1" } ) + assert_routing( + { :path => "/browse/note/1", :method => :get }, + { :controller => "browse", :action => "note", :id => "1" } + ) end def test_start @@ -74,6 +78,10 @@ class BrowseControllerTest < ActionController::TestCase browse_check 'changeset', changesets(:normal_user_first_change).id end + def test_read_note + browse_check 'note', notes(:open_note).id + end + ## # Methods to check redaction. # @@ -122,15 +130,17 @@ class BrowseControllerTest < ActionController::TestCase assert_select "body div#content div.browse_details[id=4] div.common", 1 end +private + # This is a convenience method for most of the above checks # First we check that when we don't have an id, it will correctly return a 404 # then we check that we get the correct 404 when a non-existant id is passed # then we check that it will get a successful response, when we do pass an id def browse_check(type, id) - assert_raise ActionController::RoutingError do + assert_raise ActionController::UrlGenerationError do get type end - assert_raise ActionController::RoutingError do + assert_raise ActionController::UrlGenerationError do get type, {:id => -10} # we won't have an id that's negative end get type, {:id => id}