X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/b095b59d5e0ee805e49980af80b21bd1acff1345..374518f58ac5e598d669ffd4e7e3a945b68b877c:/test/models/node_tag_test.rb

diff --git a/test/models/node_tag_test.rb b/test/models/node_tag_test.rb
index aa50b2f39..a7e72df73 100644
--- a/test/models/node_tag_test.rb
+++ b/test/models/node_tag_test.rb
@@ -1,80 +1,52 @@
-require 'test_helper'
+require "test_helper"
 
 class NodeTagTest < ActiveSupport::TestCase
-  api_fixtures
-  
-  def test_tag_count
-    assert_equal 12, NodeTag.count
-    node_tag_count(:visible_node, 1)
-    node_tag_count(:invisible_node, 1)
-    node_tag_count(:used_node_1, 1)
-    node_tag_count(:used_node_2, 1)
-    node_tag_count(:node_with_versions, 2)
-  end
-  
-  def node_tag_count (node, count)
-    nod = current_nodes(node)
-    assert_equal count, nod.node_tags.count
-  end
-  
   def test_length_key_valid
-    key = "k"
-    (0..255).each do |i|
-      tag = NodeTag.new
-      tag.node_id = current_node_tags(:t1).node_id
-      tag.k = key*i
-      tag.v = "v"
-      assert tag.valid?
+    tag = create(:node_tag)
+    [0, 255].each do |i|
+      tag.k = "k" * i
+      assert_predicate tag, :valid?
     end
   end
-  
+
   def test_length_value_valid
-    val = "v"
-    (0..255).each do |i|
-      tag = NodeTag.new
-      tag.node_id = current_node_tags(:t1).node_id
-      tag.k = "k"
-      tag.v = val*i
-      assert tag.valid?
+    tag = create(:node_tag)
+    [0, 255].each do |i|
+      tag.v = "v" * i
+      assert_predicate tag, :valid?
     end
   end
-  
+
   def test_length_key_invalid
-    ["k"*256].each do |i|
-      tag = NodeTag.new
-      tag.node_id = current_node_tags(:t1).node_id
-      tag.k = i
-      tag.v = "v"
-      assert !tag.valid?, "Key should be too long"
-      assert tag.errors[:k].any?
-    end
+    tag = create(:node_tag)
+    tag.k = "k" * 256
+    assert_not tag.valid?, "Key should be too long"
+    assert_predicate tag.errors[:k], :any?
   end
-  
+
   def test_length_value_invalid
-    ["k"*256].each do |i|
-      tag = NodeTag.new
-      tag.node_id = current_node_tags(:t1).node_id
-      tag.k = "k"
-      tag.v = i
-      assert !tag.valid?, "Value should be too long"
-      assert tag.errors[:v].any?
-    end
+    tag = create(:node_tag)
+    tag.v = "v" * 256
+    assert_not tag.valid?, "Value should be too long"
+    assert_predicate tag.errors[:v], :any?
   end
-  
-  def test_empty_node_tag_invalid
-    tag = NodeTag.new
-    assert !tag.valid?, "Empty tag should be invalid"
-    assert tag.errors[:node].any?
+
+  def test_orphaned_node_tag_invalid
+    tag = create(:node_tag)
+    tag.node = nil
+    assert_not tag.valid?, "Orphaned tag should be invalid"
+    assert_predicate tag.errors[:node], :any?
   end
-  
+
   def test_uniqueness
+    existing = create(:node_tag)
     tag = NodeTag.new
-    tag.node_id = current_node_tags(:t1).node_id
-    tag.k = current_node_tags(:t1).k
-    tag.v = current_node_tags(:t1).v
-    assert tag.new_record?
-    assert !tag.valid?
-    assert_raise(ActiveRecord::RecordInvalid) {tag.save!}
-    assert tag.new_record?
+    tag.node_id = existing.node_id
+    tag.k = existing.k
+    tag.v = existing.v
+    assert_predicate tag, :new_record?
+    assert_not tag.valid?
+    assert_raise(ActiveRecord::RecordInvalid) { tag.save! }
+    assert_predicate tag, :new_record?
   end
 end