X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/bac37f29d249b94386bc93d2f933f9fef07b1d1c..3db4ac9a8e8dd94bc288e98ff353452e401d0a59:/app/controllers/geocoder_controller.rb?ds=inline diff --git a/app/controllers/geocoder_controller.rb b/app/controllers/geocoder_controller.rb index 480dc5419..8abcbdc44 100644 --- a/app/controllers/geocoder_controller.rb +++ b/app/controllers/geocoder_controller.rb @@ -4,18 +4,48 @@ class GeocoderController < ApplicationController require 'rexml/document' def search - @query = params[:query] - @results = Array.new - - if @query.match(/^\d{5}(-\d{4})?$/) - @results.push search_us_postcode(@query) - elsif @query.match(/(GIR 0AA|[A-PR-UWYZ]([0-9]{1,2}|([A-HK-Y][0-9]|[A-HK-Y][0-9]([0-9]|[ABEHMNPRV-Y]))|[0-9][A-HJKS-UW]) [0-9][ABD-HJLNP-UW-Z]{2})/i) - @results.push search_uk_postcode(@query) - elsif @query.match(/[A-Z]\d[A-Z]\s*\d[A-Z]\d/i) - @results.push search_ca_postcode(@query) + query = params[:query] + results = Array.new + + if query.match(/^\d{5}(-\d{4})?$/) + results.push search_us_postcode(query) + elsif query.match(/(GIR 0AA|[A-PR-UWYZ]([0-9]{1,2}|([A-HK-Y][0-9]|[A-HK-Y][0-9]([0-9]|[ABEHMNPRV-Y]))|[0-9][A-HJKS-UW])\s*[0-9][ABD-HJLNP-UW-Z]{2})/i) + results.push search_uk_postcode(query) + elsif query.match(/[A-Z]\d[A-Z]\s*\d[A-Z]\d/i) + results.push search_ca_postcode(query) else - @results.push search_osm_namefinder(@query) - @results.push search_geonames(@query) + results.push search_osm_namefinder(query) + results.push search_geonames(query) + end + + results_count = count_results(results) + + render :update do |page| + page.replace_html :search_results_content, :partial => 'results', :object => results + + if results_count == 1 + position = results.collect { |s| s[:results] }.compact.flatten[0] + page.call "setPosition", position[:lat], position[:lon], position[:zoom] + else + page.call "openSearchResults" + end + end + end + + def description + results = Array.new + + lat = params[:lat] + lon = params[:lon] + + results.push description_osm_namefinder("cities", lat, lon, 2) + results.push description_osm_namefinder("towns", lat, lon, 4) + results.push description_osm_namefinder("places", lat, lon, 10) + results.push description_geonames(lat, lon) + + render :update do |page| + page.replace_html :search_results_content, :partial => 'results', :object => results + page.call "openSearchResults" end end @@ -31,7 +61,8 @@ private unless response.match(/couldn't find this zip/) data = response.split(/\s*,\s+/) # lat,long,town,state,zip results.push({:lat => data[0], :lon => data[1], :zoom => 12, - :description => "#{data[2]}, #{data[3]}, #{data[4]}"}) + :prefix => "#{data[2]}, #{data[3]}, ", + :name => data[4]}) end return { :source => "Geocoder.us", :url => "http://geocoder.us/", :results => results } @@ -50,7 +81,7 @@ private dataline = response.split(/\n/)[1] data = dataline.split(/,/) # easting,northing,postcode,lat,long results.push({:lat => data[3], :lon => data[4], :zoom => 12, - :description => data[2].gsub(/'/, "")}) + :name => data[2].gsub(/'/, "")}) end return { :source => "NPEMap / FreeThePostcode", :url => "http://www.npemap.org.uk/", :results => results } @@ -69,7 +100,7 @@ private results.push({:lat => response.get_text("geodata/latt").to_s, :lon => response.get_text("geodata/longt").to_s, :zoom => 12, - :description => query.upcase}) + :name => query.upcase}) end return { :source => "Geocoder.CA", :url => "http://geocoder.ca/", :results => results } @@ -91,16 +122,24 @@ private place = named.elements["place/named"] || named.elements["nearestplaces/named"] type = named.attributes["info"].to_s.capitalize name = named.attributes["name"].to_s + description = named.elements["description"].to_s + if name.empty? + prefix = "" + name = type + else + prefix = "#{type} " + end if place distance = format_distance(place.attributes["approxdistance"].to_i) direction = format_direction(place.attributes["direction"].to_i) placename = place.attributes["name"].to_s - results.push({:lat => lat, :lon => lon, :zoom => zoom, - :description => "#{type} #{name}, #{distance} #{direction} of #{placename}"}) + suffix = ", #{distance} #{direction} of #{placename}" else - results.push({:lat => lat, :lon => lon, :zoom => zoom, - :description => "#{type} #{name}"}) + suffix = "" end + results.push({:lat => lat, :lon => lon, :zoom => zoom, + :prefix => prefix, :name => name, :suffix => suffix, + :description => description}) end return { :source => "OpenStreetMap Namefinder", :url => "http://www.frankieandshadow.com/osm/", :results => results } @@ -121,7 +160,8 @@ private name = geoname.get_text("name").to_s country = geoname.get_text("countryName").to_s results.push({:lat => lat, :lon => lon, :zoom => 12, - :description => "#{name}, #{country}"}) + :name => name, + :suffix => ", #{country}"}) end return { :source => "GeoNames", :url => "http://www.geonames.org/", :results => results } @@ -129,6 +169,52 @@ private return { :source => "GeoNames", :url => "http://www.geonames.org/", :error => "Error contacting ws.geonames.org: #{ex.to_s}" } end + def description_osm_namefinder(types, lat, lon, max) + results = Array.new + + # ask OSM namefinder + response = fetch_xml("http://www.frankieandshadow.com/osm/search.xml?find=#{types}+near+#{lat},#{lon}&max=#{max}") + + # parse the response + response.elements.each("searchresults/named") do |named| + lat = named.attributes["lat"].to_s + lon = named.attributes["lon"].to_s + zoom = named.attributes["zoom"].to_s + place = named.elements["place/named"] || named.elements["nearestplaces/named"] + type = named.attributes["info"].to_s + name = named.attributes["name"].to_s + description = named.elements["description"].to_s + distance = format_distance(place.attributes["approxdistance"].to_i) + direction = format_direction((place.attributes["direction"].to_i - 180) % 360) + prefix = "#{distance} #{direction} of #{type} " + results.push({:lat => lat, :lon => lon, :zoom => zoom, + :prefix => prefix.capitalize, :name => name, + :description => description}) + end + + return { :type => types.capitalize, :source => "OpenStreetMap Namefinder", :url => "http://www.frankieandshadow.com/osm/", :results => results } + rescue Exception => ex + return { :type => types.capitalize, :source => "OpenStreetMap Namefinder", :url => "http://www.frankieandshadow.com/osm/", :error => "Error contacting www.frankieandshadow.com: #{ex.to_s}" } + end + + def description_geonames(lat, lon) + results = Array.new + + # ask geonames.org + response = fetch_xml("http://ws.geonames.org/countrySubdivision?lat=#{lat}&lng=#{lon}") + + # parse the response + response.elements.each("geonames/countrySubdivision") do |geoname| + name = geoname.get_text("adminName1").to_s + country = geoname.get_text("countryName").to_s + results.push({:prefix => "#{name}, #{country}"}) + end + + return { :type => "Location", :source => "GeoNames", :url => "http://www.geonames.org/", :results => results } + rescue Exception => ex + return { :type => types.capitalize, :source => "OpenStreetMap Namefinder", :url => "http://www.frankieandshadow.com/osm/", :error => "Error contacting www.frankieandshadow.com: #{ex.to_s}" } + end + def fetch_text(url) return Net::HTTP.get(URI.parse(url)) end @@ -152,4 +238,14 @@ private return "north-west" if bearing >= 292.5 and bearing < 337.5 return "west" end + + def count_results(results) + count = 0 + + results.each do |source| + count += source[:results].length if source[:results] + end + + return count + end end