X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/bb9f20710e851eb4943bfb8e63386680e359834a..44d4a521a3c44d86d251f1f63c7232e61160e30a:/app/controllers/oauth_controller.rb diff --git a/app/controllers/oauth_controller.rb b/app/controllers/oauth_controller.rb index 88691f862..2e847fcd5 100644 --- a/app/controllers/oauth_controller.rb +++ b/app/controllers/oauth_controller.rb @@ -27,7 +27,7 @@ class OauthController < ApplicationController end def revoke - @token = current_user.oauth_tokens.find_by_token params[:token] + @token = current_user.oauth_tokens.find_by :token => params[:token] if @token @token.invalidate! flash[:notice] = t("oauth.revoke.flash", :application => @token.client_application.name) @@ -41,38 +41,36 @@ class OauthController < ApplicationController if @token.invalidated? @message = t "oauth.oauthorize_failure.invalid" render :action => "authorize_failure" - else - if request.post? - if user_authorizes_token? - @token.authorize!(current_user) - if @token.oauth10? - callback_url = params[:oauth_callback] || @token.client_application.callback_url - else - callback_url = @token.oob? ? @token.client_application.callback_url : @token.callback_url - end - @redirect_url = URI.parse(callback_url) unless callback_url.blank? + elsif request.post? + if user_authorizes_token? + @token.authorize!(current_user) + callback_url = if @token.oauth10? + params[:oauth_callback] || @token.client_application.callback_url + else + @token.oob? ? @token.client_application.callback_url : @token.callback_url + end + @redirect_url = URI.parse(callback_url) unless callback_url.blank? - if @redirect_url.to_s.blank? - render :action => "authorize_success" - else - @redirect_url.query = if @redirect_url.query.blank? - "oauth_token=#{@token.token}" - else - @redirect_url.query + + if @redirect_url.to_s.blank? + render :action => "authorize_success" + else + @redirect_url.query = if @redirect_url.query.blank? + "oauth_token=#{@token.token}" + else + @redirect_url.query + "&oauth_token=#{@token.token}" - end - - unless @token.oauth10? - @redirect_url.query += "&oauth_verifier=#{@token.verifier}" - end + end - redirect_to @redirect_url.to_s + unless @token.oauth10? + @redirect_url.query += "&oauth_verifier=#{@token.verifier}" end - else - @token.invalidate! - @message = t("oauth.oauthorize_failure.denied", :app_name => @token.client_application.name) - render :action => "authorize_failure" + + redirect_to @redirect_url.to_s end + else + @token.invalidate! + @message = t("oauth.oauthorize_failure.denied", :app_name => @token.client_application.name) + render :action => "authorize_failure" end end end