X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/bf31791f65fee149b660c1395d59204309f906fa..e1005ce62f7b7cad67e0492581e480250192db70:/app/models/node.rb diff --git a/app/models/node.rb b/app/models/node.rb index bd51d6c50..e37a10250 100644 --- a/app/models/node.rb +++ b/app/models/node.rb @@ -131,13 +131,13 @@ class Node < ActiveRecord::Base # shouldn't be possible to get race conditions. Node.transaction do check_consistency(self, new_node, user) - way = WayNode.find(:first, :joins => "INNER JOIN current_ways ON current_ways.id = current_way_nodes.id", + way = WayNode.find(:first, :joins => :way, :conditions => [ "current_ways.visible = ? AND current_way_nodes.node_id = ?", true, self.id ]) - raise OSM::APIPreconditionFailedError.new("Node #{self.id} is still used by way #{way.id}.") unless way.nil? + raise OSM::APIPreconditionFailedError.new("Node #{self.id} is still used by way #{way.way.id}.") unless way.nil? - rel = RelationMember.find(:first, :joins => "INNER JOIN current_relations ON current_relations.id=current_relation_members.id", + rel = RelationMember.find(:first, :joins => :relation, :conditions => [ "visible = ? AND member_type='Node' and member_id=? ", true, self.id]) - raise OSM::APIPreconditionFailedError.new("Node #{self.id} is still used by relation #{rel.id}.") unless rel.nil? + raise OSM::APIPreconditionFailedError.new("Node #{self.id} is still used by relation #{rel.relation.id}.") unless rel.nil? self.changeset_id = new_node.changeset_id self.visible = false @@ -267,7 +267,7 @@ class Node < ActiveRecord::Base ## # dummy method to make the interfaces of node, way and relation # more consistent. - def fix_placeholders!(id_map) + def fix_placeholders!(id_map, placeholder_id = nil) # nodes don't refer to anything, so there is nothing to do here end