X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/c11d961f624cb610c4b8184d24e522b2c093d1ea..dcad582741f4d6d0d45ebc987f25dfff9341c2f5:/app/models/segment.rb

diff --git a/app/models/segment.rb b/app/models/segment.rb
index aa4e07887..6916b79b1 100644
--- a/app/models/segment.rb
+++ b/app/models/segment.rb
@@ -59,18 +59,12 @@ class Segment < ActiveRecord::Base
     return segment
   end
 
-  def save_with_history
-    begin
-      Segment.transaction do
-        self.timestamp = Time.now
-        self.save!
-        old_segment = OldSegment.from_segment(self)
-        old_segment.save!
-      end
-
-      return true
-    rescue
-      return nil
+  def save_with_history!
+    Segment.transaction do
+      self.timestamp = Time.now
+      self.save!
+      old_segment = OldSegment.from_segment(self)
+      old_segment.save!
     end
   end
 
@@ -88,7 +82,7 @@ class Segment < ActiveRecord::Base
 
     user_display_name_cache = {} if user_display_name_cache.nil?
 
-    if user_display_name_cache and user_display_name_cache[self.user_id]
+    if user_display_name_cache and user_display_name_cache.key?(self.user_id)
       # use the cache if available
     elsif self.user.data_public?
       user_display_name_cache[self.user_id] = self.user.display_name