X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/ccebb796ab50c40fed7b76b9b2a7934cbca19cdb..6fe824bd0ba20d997bb7d1b8627d79e209b61d03:/app/controllers/geocoder_controller.rb diff --git a/app/controllers/geocoder_controller.rb b/app/controllers/geocoder_controller.rb index 7eb817333..236e9f73c 100644 --- a/app/controllers/geocoder_controller.rb +++ b/app/controllers/geocoder_controller.rb @@ -1,6 +1,7 @@ # coding: utf-8 class GeocoderController < ApplicationController + require 'cgi' require 'uri' require 'net/http' require 'rexml/document' @@ -140,20 +141,27 @@ class GeocoderController < ApplicationController # get objects to excude if params[:exclude] - exclude = "&exclude_place_ids=#{params[:exclude].join(',')}" + exclude = "&exclude_place_ids=#{params[:exclude]}" end # ask nominatim response = fetch_xml("#{NOMINATIM_URL}search?format=xml&q=#{escape_query(query)}#{viewbox}#{exclude}&accept-language=#{http_accept_language.user_preferred_languages.join(',')}") + # extract the results from the response + results = response.elements["searchresults"] + + # extract parameters from more_url + more_url_params = CGI.parse(URI.parse(results.attributes["more_url"]).query) + # create result array @results = Array.new # create parameter hash for "more results" link - @more_params = params.reverse_merge({ :exclude => [] }) + @more_params = params.merge({ + :exclude => more_url_params["exclude_place_ids"].first + }) - # extract the results from the response - results = response.elements["searchresults"] +Rails.logger.info @more_params # parse the response results.elements.each("place") do |place| @@ -181,7 +189,6 @@ class GeocoderController < ApplicationController :min_lon => min_lon, :max_lon => max_lon, :prefix => prefix, :name => name, :type => object_type, :id => object_id}) - @more_params[:exclude].push(place.attributes["place_id"].to_s) end render :action => "results" @@ -194,11 +201,14 @@ class GeocoderController < ApplicationController # get query parameters query = params[:query] + # get preferred language + lang = I18n.locale.to_s.split("-").first + # create result array @results = Array.new # ask geonames.org - response = fetch_xml("http://api.geonames.org/search?q=#{escape_query(query)}&maxRows=20&username=#{GEONAMES_USERNAME}") + response = fetch_xml("http://api.geonames.org/search?q=#{escape_query(query)}&lang=#{lang}&maxRows=20&username=#{GEONAMES_USERNAME}") # parse the response response.elements.each("geonames/geoname") do |geoname| @@ -255,11 +265,14 @@ class GeocoderController < ApplicationController lat = params[:lat] lon = params[:lon] + # get preferred language + lang = I18n.locale.to_s.split("-").first + # create result array @results = Array.new # ask geonames.org - response = fetch_xml("http://api.geonames.org/countrySubdivision?lat=#{lat}&lng=#{lon}&username=#{GEONAMES_USERNAME}") + response = fetch_xml("http://api.geonames.org/countrySubdivision?lat=#{lat}&lng=#{lon}&lang=#{lang}&username=#{GEONAMES_USERNAME}") # parse the response response.elements.each("geonames/countrySubdivision") do |geoname|