X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/cfbdd3f7e1c688e2c875ded9fd847fcc1c3a4caf..97aefa23d0606edaee71d04cf6c1a2006689b1fa:/app/models/way.rb diff --git a/app/models/way.rb b/app/models/way.rb index e0a445074..64b11cf67 100644 --- a/app/models/way.rb +++ b/app/models/way.rb @@ -1,14 +1,19 @@ class Way < ActiveRecord::Base require 'xml/libxml' - + + set_table_name 'current_ways' + belongs_to :user + has_many :old_ways, :foreign_key => 'id', :order => 'version' + has_many :way_nodes, :foreign_key => 'id', :order => 'sequence_id' - has_many :way_tags, :foreign_key => 'id' + has_many :nodes, :through => :way_nodes, :order => 'sequence_id' - has_many :old_ways, :foreign_key => 'id', :order => 'version' + has_many :way_tags, :foreign_key => 'id' - set_table_name 'current_ways' + has_many :containing_relation_members, :class_name => "RelationMember", :as => :member + has_many :containing_relations, :class_name => "Relation", :through => :containing_relation_members, :source => :relation, :extend => ObjectFinder def self.from_xml(xml, create=false) begin @@ -47,6 +52,17 @@ class Way < ActiveRecord::Base return way end + # Find a way given it's ID, and in a single SQL call also grab its nodes + # + + # You can't pull in all the tags too unless we put a sequence_id on the way_tags table and have a multipart key + def self.find_eager(id) + way = Way.find(id, :include => {:way_nodes => :node}) + #If waytag had a multipart key that was real, you could do this: + #way = Way.find(id, :include => [:way_tags, {:way_nodes => :node}]) + end + + # Find a way given it's ID, and in a single SQL call also grab its nodes and tags def to_xml doc = OSM::API.new.get_xml_doc doc.root << to_xml_node() @@ -60,7 +76,7 @@ class Way < ActiveRecord::Base el1['timestamp'] = self.timestamp.xmlschema user_display_name_cache = {} if user_display_name_cache.nil? - + if user_display_name_cache and user_display_name_cache.key?(self.user_id) # use the cache if available elsif self.user.data_public? @@ -94,7 +110,7 @@ class Way < ActiveRecord::Base el1 << e end end - + self.way_tags.each do |tag| e = XML::Node.new 'tag' e['k'] = tag.k @@ -106,20 +122,20 @@ class Way < ActiveRecord::Base def nds unless @nds - @nds = Array.new - self.way_nodes.each do |nd| - @nds += [nd.node_id] - end + @nds = Array.new + self.way_nodes.each do |nd| + @nds += [nd.node_id] + end end @nds end def tags unless @tags - @tags = Hash.new - self.way_tags.each do |tag| - @tags[tag.k] = tag.v - end + @tags = {} + self.way_tags.each do |tag| + @tags[tag.k] = tag.v + end end @tags end @@ -169,14 +185,13 @@ class Way < ActiveRecord::Base WayNode.delete_all(['id = ?', self.id]) - i = 1 + sequence = 1 nds.each do |n| nd = WayNode.new - nd.id = self.id + nd.id = [self.id, sequence] nd.node_id = n - nd.sequence_id = i nd.save! - i += 1 + sequence += 1 end end @@ -196,4 +211,55 @@ class Way < ActiveRecord::Base return true end + # Delete the way and it's relations, but don't really delete it - set its visibility to false and update the history etc to maintain wiki-like functionality. + def delete_with_relations_and_history(user) + if self.visible + # FIXME + # this should actually delete the relations, + # not just throw a PreconditionFailed if it's a member of a relation!! + if RelationMember.find(:first, :joins => "INNER JOIN current_relations ON current_relations.id=current_relation_members.id", + :conditions => [ "visible = 1 AND member_type='way' and member_id=?", self.id]) + raise OSM::APIPreconditionFailedError + # end FIXME + else + self.user_id = user.id + self.tags = [] + self.nds = [] + self.visible = false + self.save_with_history! + end + else + raise OSM::APIAlreadyDeletedError + end + end + + # delete a way and it's nodes that aren't part of other ways, with history + def delete_with_relations_and_nodes_and_history(user) + + node_ids = self.nodes.collect {|node| node.id } + node_ids_not_to_delete = [] + way_nodes = WayNode.find(:all, :conditions => "node_id in (#{node_ids.join(',')}) and id != #{self.id}") + + node_ids_not_to_delete = way_nodes.collect {|way_node| way_node.node_id} + + node_ids_to_delete = node_ids - node_ids_not_to_delete + + # delete the nodes not used by other ways + node_ids_to_delete.each do |node_id| + n = Node.find(node_id) + n.user_id = user.id + n.visible = false + n.save_with_history! + end + + self.user_id = user.id + + self.delete_with_relations_and_history(user) + + end + + # Temporary method to match interface to nodes + def tags_as_hash + return self.tags + end end