X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/d49922eb630abb73c7faffb650ab97b3c5d94c52..cba08bb454a0e3571cfc3e858dc2b2817e7b7538:/app/controllers/issues_controller.rb diff --git a/app/controllers/issues_controller.rb b/app/controllers/issues_controller.rb index 6ca61b4ce..b46794d72 100644 --- a/app/controllers/issues_controller.rb +++ b/app/controllers/issues_controller.rb @@ -2,48 +2,67 @@ class IssuesController < ApplicationController layout "site" before_action :authorize_web - before_action :check_permission, only: [:index, :show, :resolve,:open,:ignore] - before_action :find_issue, only: [:show, :resolve, :reopen, :ignore] + before_action :require_user + before_action :set_issues + before_action :check_permission + before_action :find_issue, :only => [:show, :resolve, :reopen, :ignore] def index - @issues = Issue.all - end + if current_user.moderator? + @issue_types = @moderator_issues + @users = User.joins(:roles).where(:user_roles => { :role => "moderator" }) + else + @issue_types = @admin_issues + @users = User.joins(:roles).where(:user_roles => { :role => "administrator" }) + end - def show - @read_reports = @issue.read_reports - @unread_reports = @issue.unread_reports - end + @issues = Issue.where(:assigned_role => current_user.roles.map(&:role)) - def new - unless create_new_issue_params.blank? - @issue = Issue.find_or_initialize_by(create_new_issue_params) + # If search + if params[:search_by_user] && params[:search_by_user].present? + @find_user = User.find_by(:display_name => params[:search_by_user]) + if @find_user + @issues = @issues.where(:reported_user_id => @find_user.id) + else + notice = t("issues.index.search.user_not_found") + end end - end - def create - @issue = Issue.find_by_reportable_id_and_reportable_type(params[:reportable_id],params[:reportable_type]) - if !@issue - @issue = Issue.find_or_initialize_by(issue_params) - @admins = UserRole.where(role: "administrator") - @admins.each do |user| - Notifier.new_issue_notification(User.find(user.user_id)).deliver_now - end + if params[:status] && params[:status][0].present? + @issues = @issues.where(:status => params[:status][0].to_i) end - @report = @issue.reports.build(report_params) + if params[:issue_type] && params[:issue_type][0].present? + @issues = @issues.where(:reportable_type => params[:issue_type][0]) + end - if @issue.save - redirect_to @issue, notice: 'Issue was successfully created.' - else - render :new + # If last_updated_by + if params[:last_updated_by] && params[:last_updated_by][0].present? + last_updated_by = params[:last_updated_by][0].to_s == "nil" ? nil : params[:last_updated_by][0].to_i + @issues = @issues.where(:updated_by => last_updated_by) end + + if params[:last_reported_by] && params[:last_reported_by][0].present? + last_reported_by = params[:last_reported_by][0].to_s == "nil" ? nil : params[:last_reported_by][0].to_i + @issues = @issues.where(:updated_by => last_reported_by) + end + + redirect_to issues_path, :notice => notice if notice + end + + def show + @read_reports = @issue.read_reports + @unread_reports = @issue.unread_reports + @comments = @issue.comments + @related_issues = @issue.reported_user.issues.where(:assigned_role => current_user.roles.map(&:role)) + @new_comment = IssueComment.new(:issue => @issue) end # Status Transistions def resolve if @issue.resolve @issue.save! - redirect_to @issue, notice: "Issue status has been set to: 'Resolved'" + redirect_to @issue, :notice => t("issues.resolved") else render :show end @@ -51,8 +70,9 @@ class IssuesController < ApplicationController def ignore if @issue.ignore + @issue.updated_by = current_user.id @issue.save! - redirect_to @issue, notice: "Issue status has been set to: 'Ignored'" + redirect_to @issue, :notice => t("issues.ignored") else render :show end @@ -60,8 +80,9 @@ class IssuesController < ApplicationController def reopen if @issue.reopen + @issue.updated_by = current_user.id @issue.save! - redirect_to @issue, notice: "Issue status has been set to: 'Open'" + redirect_to @issue, :notice => t("issues.reopened") else render :show end @@ -69,26 +90,47 @@ class IssuesController < ApplicationController private - def find_issue - @issue = Issue.find(params[:id]) - end + def set_issues + @admin_issues = %w[DiaryEntry DiaryComment User] + @moderator_issues = %w[Changeset Note] + end - def check_permission - unless @user.administrator? - flash[:error] = t("application.require_admin.not_an_admin") - redirect_to root_path - end + def check_if_updated + if @issue.reportable && (@issue.ignored? || @issue.resolved?) && @issue.reportable.has_attribute?(:updated_by) && @issue.reportable.updated_at > @last_report.updated_at + true + else + false end + end - def create_new_issue_params - params.permit(:reportable_id, :reportable_type, :user_id) - end + def find_issue + @issue = Issue.find(params[:id]) + end - def issue_params - params[:issue].permit(:reportable_id, :reportable_type,:user_id) + def check_permission + unless current_user.administrator? || current_user.moderator? + flash[:error] = t("application.require_admin.not_an_admin") + redirect_to root_path end + end - def report_params - params[:report].permit(:details, :user_id) - end + def issue_params + params[:issue].permit(:reportable_id, :reportable_type) + end + + def report_params + params[:report].permit(:details) + end + + def issue_comment_params + params.require(:issue_comment).permit(:body) + end + + def sort_column + Issue.column_names.include?(params[:sort]) ? params[:sort] : "status" + end + + def sort_direction + %w[asc desc].include?(params[:direction]) ? params[:direction] : "asc" + end end