X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/d5fdc0855a48536492eaed2d2a9055fafd898a30..29925642761b6eb5ab5e19cdabc540dbb2f3cd4a:/app/assets/javascripts/index/query.js
diff --git a/app/assets/javascripts/index/query.js b/app/assets/javascripts/index/query.js
index f2281d007..12bb49efc 100644
--- a/app/assets/javascripts/index/query.js
+++ b/app/assets/javascripts/index/query.js
@@ -1,8 +1,10 @@
//= require jquery.simulate
OSM.Query = function(map) {
- var queryButton = $(".control-query .control-button"),
- uninterestingTags = ['source', 'source_ref', 'source:ref', 'history', 'attribution', 'created_by', 'tiger:county', 'tiger:tlid', 'tiger:upload_uuid'],
+ var protocol = document.location.protocol === "https:" ? "https:" : "http:",
+ url = protocol + OSM.OVERPASS_URL,
+ queryButton = $(".control-query .control-button"),
+ uninterestingTags = ['source', 'source_ref', 'source:ref', 'history', 'attribution', 'created_by', 'tiger:county', 'tiger:tlid', 'tiger:upload_uuid', 'KSJ2:curve_id', 'KSJ2:lat', 'KSJ2:lon', 'KSJ2:coordinate', 'KSJ2:filename', 'note:ja'],
marker;
var featureStyle = {
@@ -21,8 +23,6 @@ OSM.Query = function(map) {
if (queryButton.hasClass("active")) {
disableQueryMode();
-
- OSM.router.route("/");
} else {
enableQueryMode();
}
@@ -51,19 +51,24 @@ OSM.Query = function(map) {
if (geometry) map.removeLayer(geometry);
$(this).removeClass("selected");
})
- .on("click", ".query-results li.query-result", function (e) {
- if (!$(e.target).is('a')) {
- $(this).find("a").simulate("click", e);
- }
+ .on("mousedown", ".query-results li.query-result", function (e) {
+ var moved = false;
+ $(this).one("click", function (e) {
+ if (!moved) {
+ var geometry = $(this).data("geometry")
+ if (geometry) map.removeLayer(geometry);
+
+ if (!$(e.target).is('a')) {
+ $(this).find("a").simulate("click", e);
+ }
+ }
+ }).one("mousemove", function () {
+ moved = true;
+ });
});
function interestingFeature(feature, origin, radius) {
if (feature.tags) {
- if (feature.type === "node" &&
- OSM.distance(origin, L.latLng(feature.lat, feature.lon)) > radius) {
- return false;
- }
-
for (var key in feature.tags) {
if (uninterestingTags.indexOf(key) < 0) {
return true;
@@ -78,7 +83,7 @@ OSM.Query = function(map) {
var tags = feature.tags;
var prefix = "";
- if (tags.boundary === "administrative") {
+ if (tags.boundary === "administrative" && tags.admin_level) {
prefix = I18n.t("geocoder.search_osm_nominatim.admin_levels.level" + tags.admin_level)
} else {
var prefixes = I18n.t("geocoder.search_osm_nominatim.prefix");
@@ -107,7 +112,14 @@ OSM.Query = function(map) {
}
function featureName(feature) {
- var tags = feature.tags;
+ var tags = feature.tags,
+ locales = I18n.locales.get();
+
+ for (var i = 0; i < locales.length; i++) {
+ if (tags["name:" + locales[i]]) {
+ return tags["name:" + locales[i]];
+ }
+ }
if (tags["name"]) {
return tags["name"];
@@ -122,33 +134,27 @@ OSM.Query = function(map) {
}
}
- function featureGeometry(feature, features) {
+ function featureGeometry(feature) {
var geometry;
- if (feature.type === "node") {
+ if (feature.type === "node" && feature.lat && feature.lon) {
geometry = L.circleMarker([feature.lat, feature.lon], featureStyle);
- } else if (feature.type === "way") {
- geometry = L.polyline(feature.nodes.map(function (node) {
- return features["node" + node].getLatLng();
+ } else if (feature.type === "way" && feature.geometry) {
+ geometry = L.polyline(feature.geometry.filter(function (point) {
+ return point !== null;
+ }).map(function (point) {
+ return [point.lat, point.lon];
}), featureStyle);
- } else if (feature.type === "relation") {
- geometry = L.featureGroup();
-
- feature.members.forEach(function (member) {
- if (features[member.type + member.ref]) {
- geometry.addLayer(features[member.type + member.ref]);
- }
- });
- }
-
- if (geometry) {
- features[feature.type + feature.id] = geometry;
+ } else if (feature.type === "relation" && feature.members) {
+ geometry = L.featureGroup(feature.members.map(featureGeometry).filter(function (geometry) {
+ return geometry !== undefined;
+ }));
}
return geometry;
}
- function runQuery(latlng, radius, query, $section) {
+ function runQuery(latlng, radius, query, $section, compare) {
var $ul = $section.find("ul");
$ul.empty();
@@ -163,24 +169,29 @@ OSM.Query = function(map) {
}
$section.data("ajax", $.ajax({
- url: OSM.OVERPASS_URL,
+ url: url,
method: "POST",
data: {
data: "[timeout:5][out:json];" + query,
},
success: function(results) {
- var features = {};
+ var elements;
$section.find(".loader").stopTime("loading").hide();
- for (var i = 0; i < results.elements.length; i++) {
- var element = results.elements[i],
- geometry = featureGeometry(element, features);
+ if (compare) {
+ elements = results.elements.sort(compare);
+ } else {
+ elements = results.elements;
+ }
+
+ for (var i = 0; i < elements.length; i++) {
+ var element = elements[i];
if (interestingFeature(element, latlng, radius)) {
var $li = $("")
.addClass("query-result")
- .data("geometry", geometry)
+ .data("geometry", featureGeometry(element))
.appendTo($ul);
var $p = $("")
.text(featurePrefix(element) + " ")
@@ -203,19 +214,54 @@ OSM.Query = function(map) {
$section.find(".loader").stopTime("loading").hide();
$("
")
- .text(I18n.t("javascripts.query." + status, { server: OSM.OVERPASS_URL, error: error }))
+ .text(I18n.t("javascripts.query." + status, { server: url, error: error }))
.appendTo($ul);
}
}));
}
+ function compareSize(feature1, feature2) {
+ var width1 = feature1.bounds.maxlon - feature1.bounds.minlon,
+ height1 = feature1.bounds.maxlat - feature1.bounds.minlat,
+ area1 = width1 * height1,
+ width2 = feature2.bounds.maxlat - feature2.bounds.minlat,
+ height2 = feature2.bounds.maxlat - feature2.bounds.minlat,
+ area2 = width2 * height2;
+
+ return area1 - area2;
+ }
+
+ /*
+ * To find nearby objects we ask overpass for the union of the
+ * following sets:
+ *
+ * node(around:,,lng>)
+ * way(around:,,lng>)
+ * relation(around:,,lng>)
+ *
+ * to find enclosing objects we first find all the enclosing areas:
+ *
+ * is_in(,)->.a
+ *
+ * and then return the union of the following sets:
+ *
+ * relation(pivot.a)
+ * way(pivot.a)
+ *
+ * In both cases we then ask to retrieve tags and the geometry
+ * for each object.
+ */
function queryOverpass(lat, lng) {
var latlng = L.latLng(lat, lng),
+ bounds = map.getBounds(),
+ bbox = bounds.getSouth() + "," + bounds.getWest() + "," + bounds.getNorth() + "," + bounds.getEast(),
radius = 10 * Math.pow(1.5, 19 - map.getZoom()),
around = "around:" + radius + "," + lat + "," + lng,
- features = "(node(" + around + ");way(" + around + ");relation(" + around + "))",
- nearby = "((" + features + ";way(bn));node(w));out;",
- isin = "is_in(" + lat + "," + lng + ")->.a;(relation(pivot.a);way(pivot.a);node(w));out;";
+ nodes = "node(" + around + ")",
+ ways = "way(" + around + ")",
+ relations = "relation(" + around + ")",
+ nearby = "(" + nodes + ";" + ways + ");out tags geom(" + bbox + ");" + relations + ";out geom(" + bbox + ");",
+ isin = "is_in(" + lat + "," + lng + ")->.a;way(pivot.a);out tags geom(" + bbox + ");relation(pivot.a);out tags bb;";
$("#sidebar_content .query-intro")
.hide();
@@ -235,7 +281,7 @@ OSM.Query = function(map) {
}, 10);
runQuery(latlng, radius, nearby, $("#query-nearby"));
- runQuery(latlng, radius, isin, $("#query-isin"));
+ runQuery(latlng, radius, isin, $("#query-isin"), compareSize);
}
function clickHandler(e) {
@@ -271,19 +317,19 @@ OSM.Query = function(map) {
var params = querystring.parse(path.substring(path.indexOf('?') + 1)),
latlng = L.latLng(params.lat, params.lon);
- if (!window.location.hash &&
- (!noCentre || !map.getBounds().contains(latlng))) {
+ if (!window.location.hash && !noCentre && !map.getBounds().contains(latlng)) {
OSM.router.withoutMoveListener(function () {
map.setView(latlng, 15);
});
}
queryOverpass(params.lat, params.lon);
- enableQueryMode();
};
- page.unload = function() {
- disableQueryMode();
+ page.unload = function(sameController) {
+ if (!sameController) {
+ disableQueryMode();
+ }
};
return page;