X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/db33aa6ff66a85207c8706c1a18f91ae9111c2b0..cf9f5ba9333ac2dee444bdb5d4e20523061de184:/app/controllers/way_controller.rb?ds=sidebyside diff --git a/app/controllers/way_controller.rb b/app/controllers/way_controller.rb index 25a1231db..3b6491cf0 100644 --- a/app/controllers/way_controller.rb +++ b/app/controllers/way_controller.rb @@ -69,30 +69,20 @@ class WayController < ApplicationController end end + # This is the API call to delete a way def delete begin way = Way.find(params[:id]) - - if way.visible - # omg FIXME - if RelationMember.find(:first, :joins => "INNER JOIN current_relations ON current_relations.id=current_relation_members.id", :conditions => [ "visible = 1 AND member_type='way' and member_id=?", params[:id]]) - render :text => "", :status => :precondition_failed - else - way.user_id = @user.id - way.tags = [] - way.nds = [] - way.visible = false - way.save_with_history! - - render :nothing => true - end - else - render :text => "", :status => :gone - end + way.delete_with_relations_and_history(@user) + + # if we get here, all is fine, otherwise something will catch below. + render :nothing => true + rescue OSM::APIAlreadyDeletedError + render :text => "", :status => :gone + rescue OSM::APIPreconditionFailedError + render :text => "", :status => :precondition_failed rescue ActiveRecord::RecordNotFound render :nothing => true, :status => :not_found - rescue => ex - puts ex end end @@ -141,7 +131,7 @@ class WayController < ApplicationController end def ways_for_node - wayids = WayNode.find(:all, :conditions => ['node_id = ?', params[:id]]).collect { |ws| ws.id }.uniq + wayids = WayNode.find(:all, :conditions => ['node_id = ?', params[:id]]).collect { |ws| ws.id[0] }.uniq doc = OSM::API.new.get_xml_doc