X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/dbe165bbb3d6eda37d9579f1ac767599f9055607..b4106383d99ccbf152d79b0f2c9deca95df9fb61:/app/controllers/old_controller.rb diff --git a/app/controllers/old_controller.rb b/app/controllers/old_controller.rb index b52c4efa4..9adf141d9 100644 --- a/app/controllers/old_controller.rb +++ b/app/controllers/old_controller.rb @@ -11,7 +11,6 @@ class OldController < ApplicationController before_action :require_allow_write_api, :only => [:redact] before_action :check_api_readable before_action :check_api_writable, :only => [:redact] - after_action :compress_output around_action :api_call_handle_error, :api_call_timeout before_action :lookup_old_element, :except => [:history] before_action :lookup_old_element_versions, :only => [:history] @@ -20,7 +19,7 @@ class OldController < ApplicationController # the .where() method used in the lookup_old_element_versions # call won't throw an error if no records are found, so we have # to do that ourselves. - fail OSM::APINotFoundError.new if @elements.empty? + raise OSM::APINotFoundError if @elements.empty? doc = OSM::API.new.get_xml_doc @@ -34,12 +33,12 @@ class OldController < ApplicationController doc.root << element.to_xml_node end - render :text => doc.to_s, :content_type => "text/xml" + render :xml => doc.to_s end def version if @old_element.redacted? && !show_redactions? - render :text => "", :status => :forbidden + head :forbidden else response.last_modified = @old_element.timestamp @@ -47,7 +46,7 @@ class OldController < ApplicationController doc = OSM::API.new.get_xml_doc doc.root << @old_element.to_xml_node - render :text => doc.to_s, :content_type => "text/xml" + render :xml => doc.to_s end end @@ -65,12 +64,12 @@ class OldController < ApplicationController end # just return an empty 200 OK for success - render :text => "" + head :ok end private def show_redactions? - @user && @user.moderator? && params[:show_redactions] == "true" + current_user && current_user.moderator? && params[:show_redactions] == "true" end end