X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/e3b8b8933044104bb515d34c3d36851caba78ac7..ba5107ebb543a396fc78069c75c431e4d3887ee1:/app/models/note.rb

diff --git a/app/models/note.rb b/app/models/note.rb
index e36884ec1..14806be26 100644
--- a/app/models/note.rb
+++ b/app/models/note.rb
@@ -4,7 +4,7 @@ class Note < ActiveRecord::Base
   has_many :comments, :class_name => "NoteComment",
                       :foreign_key => :note_id,
                       :order => :created_at,
-                      :conditions => "visible = true AND body IS NOT NULL"
+                      :conditions => { :visible => true }
 
   validates_presence_of :id, :on => :update
   validates_uniqueness_of :id
@@ -12,21 +12,25 @@ class Note < ActiveRecord::Base
   validates_numericality_of :longitude, :only_integer => true
   validates_presence_of :closed_at if :status == "closed"
   validates_inclusion_of :status, :in => ["open", "closed", "hidden"]
+  validate :validate_position
 
-  def self.create_bug(lat, lon)
-    note = Note.new(:lat => lat, :lon => lon, :status => "open")
-    raise OSM::APIBadUserInput.new("The note is outside this world") unless note.in_world?
+  attr_accessible :lat, :lon
 
-    return note
+  after_initialize :set_defaults
+
+  # Sanity check the latitude and longitude and add an error if it's broken
+  def validate_position
+    errors.add(:base, "Note is not in the world") unless in_world?
   end
 
+  # Close a note
   def close
     self.status = "closed"
     self.closed_at = Time.now.getutc
-
     self.save
   end
 
+  # Return a flattened version of the comments for a note
   def flatten_comment(separator_char, upto_timestamp = :nil)
     resp = ""
     comment_no = 1
@@ -35,7 +39,7 @@ class Note < ActiveRecord::Base
       resp += (comment_no == 1 ? "" : separator_char)
       resp += comment.body if comment.body
       resp += " [ " 
-      resp += comment.author_name if comment.author_name
+      resp += comment.author.display_name if comment.author
       resp += " " + comment.created_at.to_s + " ]"
       comment_no += 1
     end
@@ -43,23 +47,25 @@ class Note < ActiveRecord::Base
     return resp
   end
 
-  def visible
+  # Check if a note is visible
+  def visible?
     return status != "hidden"
   end
 
+  # Return the author object, derived from the first comment
   def author
     self.comments.first.author
   end
 
+  # Return the author IP address, derived from the first comment
   def author_ip
     self.comments.first.author_ip
   end
 
-  def author_id
-    self.comments.first.author_id
-  end
+private
 
-  def author_name
-    self.comments.first.author_name
+  # Fill in default values for new notes
+  def set_defaults
+    self.status = "open" unless self.attribute_present?(:status)
   end
 end