X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/ea2652a211fb94a1148ce27f7877cc53199cf251..e83b793437184341c9a6fef2a1c6735c42fe1c30:/app/controllers/geocoder_controller.rb?ds=sidebyside diff --git a/app/controllers/geocoder_controller.rb b/app/controllers/geocoder_controller.rb index 6c98d49dd..9210fa8b5 100644 --- a/app/controllers/geocoder_controller.rb +++ b/app/controllers/geocoder_controller.rb @@ -19,12 +19,12 @@ class GeocoderController < ApplicationController @sources.push "us_postcode" elsif @query.match(/^(GIR 0AA|[A-PR-UWYZ]([0-9]{1,2}|([A-HK-Y][0-9]|[A-HK-Y][0-9]([0-9]|[ABEHMNPRV-Y]))|[0-9][A-HJKS-UW])\s*[0-9][ABD-HJLNP-UW-Z]{2})$/i) @sources.push "uk_postcode" - @sources.push "osm_nominatim" if APP_CONFIG['nominatim_enabled'] + @sources.push "osm_nominatim" @sources.push "osm_namefinder" elsif @query.match(/^[A-Z]\d[A-Z]\s*\d[A-Z]\d$/i) @sources.push "ca_postcode" else - @sources.push "osm_nominatim" if APP_CONFIG['nominatim_enabled'] + @sources.push "osm_nominatim" @sources.push "osm_namefinder" @sources.push "geonames" end @@ -218,30 +218,33 @@ class GeocoderController < ApplicationController def search_osm_nominatim # get query parameters query = params[:query] + minlon = params[:minlon] + minlat = params[:minlat] + maxlon = params[:maxlon] + maxlat = params[:maxlat] + + # get view box + if minlon && minlat && maxlon && maxlat + viewbox = "&viewbox=#{minlon},#{maxlat},#{maxlon},#{minlat}" + end # create result array @results = Array.new - # ask OSM namefinder - response = fetch_xml("http://nominatim.openstreetmap.org/search.php?format=xml&polygon=true&q=#{escape_query(query)}") + # ask nominatim + response = fetch_xml("http://nominatim.openstreetmap.org/search?format=xml&q=#{escape_query(query)}#{viewbox}&accept-language=#{request.user_preferred_languages.join(',')}") # parse the response response.elements.each("searchresults/place") do |place| lat = place.attributes["lat"].to_s lon = place.attributes["lon"].to_s - zoom = place.attributes["zoom"].to_s klass = place.attributes["class"].to_s type = place.attributes["type"].to_s name = place.attributes["display_name"].to_s min_lat,max_lat,min_lon,max_lon = place.attributes["boundingbox"].to_s.split(",") + prefix = t "geocoder.search_osm_nominatim.prefix_#{type}", :default => type.gsub("_", " ").capitalize - if klass == "highway" - prefix = t 'geocoder.search_osm_nominatim.prefix_highway', :type => type.capitalize - else - prefix = t 'geocoder.search_osm_nominatim.prefix_other', :type => type.capitalize - end - - @results.push({:lat => lat, :lon => lon, :zoom => zoom, + @results.push({:lat => lat, :lon => lon, :min_lat => min_lat, :max_lat => max_lat, :min_lon => min_lon, :max_lon => max_lon, :prefix => prefix, :name => name}) @@ -284,7 +287,7 @@ class GeocoderController < ApplicationController def description @sources = Array.new - @sources.push({ :name => "osm_nominatim" }) if APP_CONFIG['nominatim_enabled'] + @sources.push({ :name => "osm_nominatim" }) @sources.push({ :name => "osm_namefinder", :types => "cities", :max => 2 }) @sources.push({ :name => "osm_namefinder", :types => "towns", :max => 4 }) @sources.push({ :name => "osm_namefinder", :types => "places", :max => 10 }) @@ -342,7 +345,7 @@ class GeocoderController < ApplicationController @results = Array.new # ask OSM namefinder - response = fetch_xml("http://nominatim.openstreetmap.org/reverse.php?lat=#{lat}&lon=#{lon}&zoom=#{zoom}") + response = fetch_xml("http://nominatim.openstreetmap.org/reverse?lat=#{lat}&lon=#{lon}&zoom=#{zoom}&accept-language=#{request.user_preferred_languages.join(',')}") # parse the response response.elements.each("reversegeocode") do |result|