X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/ef7f3d800cbdd49b692df10d312e5fd880e2e938..84d90fabe44a7aff9a111162cbd1e1d463ac1f9c:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 75f088e1a..890fcc83c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,93 +1,72 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2015-02-16 19:20:52 +0000 using RuboCop version 0.29.1. +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2020-09-02 06:16:56 UTC using RuboCop version 0.90.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 13 -Lint/AmbiguousOperator: - Enabled: false +# Work around erblint issues. +# https://github.com/openstreetmap/openstreetmap-website/issues/2472 +require: + - rubocop-minitest + - rubocop-performance + - rubocop-rails -# Offense count: 110 -Lint/AmbiguousRegexpLiteral: - Enabled: false +# Offense count: 568 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 250 -# Offense count: 29 +# Offense count: 36 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: - Enabled: false - -# Offense count: 1 -# Configuration parameters: AlignWith, SupportedStyles. -Lint/DefEndAlignment: - Enabled: false - -# Offense count: 2 -Lint/DuplicateMethods: - Enabled: false - -# Offense count: 5 -# Configuration parameters: AlignWith, SupportedStyles. -Lint/EndAlignment: - Enabled: false - -# Offense count: 8 -Lint/HandleExceptions: - Enabled: false - -# Offense count: 1 -Lint/LiteralInCondition: - Enabled: false - -# Offense count: 8 -Lint/ParenthesesAsGroupedExpression: - Enabled: false - -# Offense count: 18 -Lint/RescueException: - Enabled: false - -# Offense count: 3 -Lint/ShadowingOuterLocalVariable: - Enabled: false - -# Offense count: 2 -Lint/UselessAccessModifier: - Enabled: false - -# Offense count: 48 -Lint/UselessAssignment: - Enabled: false - -# Offense count: 2 -Lint/Void: - Enabled: false - -# Offense count: 546 + Exclude: + - 'app/controllers/api/traces_controller.rb' + - 'app/controllers/api/user_preferences_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/controllers/notes_controller.rb' + - 'app/controllers/traces_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/mailers/user_mailer.rb' + - 'app/models/client_application.rb' + - 'lib/nominatim.rb' + - 'lib/osm.rb' + - 'script/deliver-message' + +# Offense count: 682 +# Configuration parameters: IgnoredMethods. Metrics/AbcSize: Max: 194 -# Offense count: 12 +# Offense count: 72 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. +# ExcludedMethods: refine +Metrics/BlockLength: + Max: 71 + +# Offense count: 15 +# Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 60 -# Configuration parameters: CountComments. +# Offense count: 25 +# Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 1515 + Max: 644 # Offense count: 68 +# Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 21 - -# Offense count: 2112 -# Configuration parameters: AllowURI, URISchemes. -Metrics/LineLength: - Max: 520 + Max: 26 -# Offense count: 520 -# Configuration parameters: CountComments. +# Offense count: 735 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. Metrics/MethodLength: Max: 179 @@ -96,189 +75,100 @@ Metrics/MethodLength: Metrics/ParameterLists: Max: 9 -# Offense count: 70 +# Offense count: 69 +# Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: - Max: 24 + Max: 26 -# Offense count: 5 -Style/AccessorMethodName: - Enabled: false +# Offense count: 540 +Minitest/MultipleAssertions: + Max: 81 -# Offense count: 1 -Style/AsciiComments: - Enabled: false - -# Offense count: 21 -# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep. -Style/CaseIndentation: - Enabled: false - -# Offense count: 3 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/ClassAndModuleChildren: - Enabled: false - -# Offense count: 9 -Style/ClassVars: - Enabled: false +# Offense count: 6 +Naming/AccessorMethodName: + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/helpers/title_helper.rb' + - 'app/models/old_way.rb' + - 'lib/osm.rb' + - 'lib/potlatch.rb' -# Offense count: 12 -# Configuration parameters: Keywords. -Style/CommentAnnotation: - Enabled: false - -# Offense count: 9 -Style/ConstantName: - Enabled: false +# Offense count: 8 +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. +# NamePrefix: is_, has_, have_ +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? +# MethodDefinitionMacros: define_method, define_singleton_method +Naming/PredicateName: + Exclude: + - 'spec/**/*' + - 'app/models/changeset.rb' + - 'app/models/old_node.rb' + - 'app/models/old_relation.rb' + - 'app/models/old_way.rb' + - 'app/models/user.rb' + - 'lib/classic_pagination/pagination.rb' -# Offense count: 306 -Style/Documentation: - Enabled: false +# Offense count: 5 +# Configuration parameters: Database, Include. +# SupportedDatabases: mysql, postgresql +# Include: db/migrate/*.rb +Rails/BulkChangeTable: + Exclude: + - 'db/migrate/20111116184519_update_oauth.rb' + - 'db/migrate/20120208194454_add_domain_to_acl.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' # Offense count: 2 -Style/EachWithObject: - Enabled: false - -# Offense count: 3 -Style/EmptyElse: - Enabled: false - -# Offense count: 3 -# Configuration parameters: Exclude. -Style/FileName: - Enabled: false - -# Offense count: 3 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/For: - Enabled: false - -# Offense count: 8 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/FormatString: - Enabled: false +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/HasAndBelongsToMany: + Exclude: + - 'app/models/changeset.rb' + - 'app/models/user.rb' -# Offense count: 1 -# Configuration parameters: AllowedVariables. -Style/GlobalVars: - Enabled: false +# Offense count: 4 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/title_helper.rb' -# Offense count: 41 -# Configuration parameters: MinBodyLength. -Style/GuardClause: - Enabled: false +# Offense count: 5 +# Configuration parameters: Include. +# Include: db/migrate/*.rb +Rails/NotNullColumn: + Exclude: + - 'db/migrate/002_cleanup_osm_db.rb' + - 'db/migrate/020_populate_node_tags_and_remove.rb' + - 'db/migrate/021_move_to_innodb.rb' + - 'db/migrate/025_add_end_time_to_changesets.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' + +# Offense count: 19 +Rails/OutputSafety: + Exclude: + - 'app/controllers/users_controller.rb' + - 'app/helpers/application_helper.rb' + - 'lib/rich_text.rb' + - 'test/helpers/application_helper_test.rb' -# Offense count: 5687 +# Offense count: 95 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/HashSyntax: +# Configuration parameters: EnforcedStyle. +# SupportedStyles: strict, flexible +Rails/TimeZone: Enabled: false -# Offense count: 41 -# Configuration parameters: MaxLineLength. -Style/IfUnlessModifier: - Enabled: false - -# Offense count: 60 +# Offense count: 572 # Cop supports --auto-correct. -Style/LineEndConcatenation: - Enabled: false - -# Offense count: 12 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/MethodName: - Enabled: false - -# Offense count: 3 -Style/MultilineTernaryOperator: - Enabled: false - -# Offense count: 1 -Style/NestedTernaryOperator: +# Configuration parameters: EnforcedStyle. +# SupportedStyles: always, always_true, never +Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 11 -# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles. -Style/Next: - Enabled: false - -# Offense count: 53 +# Offense count: 78 # Cop supports --auto-correct. +# Configuration parameters: Strict. Style/NumericLiterals: MinDigits: 11 - -# Offense count: 42 -Style/OneLineConditional: - Enabled: false - -# Offense count: 2 -Style/OpMethod: - Enabled: false - -# Offense count: 44 -# Cop supports --auto-correct. -Style/PerlBackrefs: - Enabled: false - -# Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist. -Style/PredicateName: - Enabled: false - -# Offense count: 95 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/RaiseArgs: - Enabled: false - -# Offense count: 11 -Style/RegexpLiteral: - MaxSlashes: 5 - -# Offense count: 2 -Style/RescueModifier: - Enabled: false - -# Offense count: 25 -# Configuration parameters: AllowAsExpressionSeparator. -Style/Semicolon: - Enabled: false - -# Offense count: 4 -# Configuration parameters: Methods. -Style/SingleLineBlockParams: - Enabled: false - -# Offense count: 6639 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiterals: - Enabled: false - -# Offense count: 8 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiteralsInInterpolation: - Enabled: false - -# Offense count: 1 -Style/StructInheritance: - Enabled: false - -# Offense count: 3 -# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist. -Style/TrivialAccessors: - Enabled: false - -# Offense count: 10 -Style/UnlessElse: - Enabled: false - -# Offense count: 2 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/VariableName: - Enabled: false - -# Offense count: 1 -# Configuration parameters: MaxLineLength. -Style/WhileUntilModifier: - Enabled: false