X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/ef7f3d800cbdd49b692df10d312e5fd880e2e938..dc2a2c8ebd1a11e4a64555fda22c6859a51defff:/app/models/changeset.rb

diff --git a/app/models/changeset.rb b/app/models/changeset.rb
index 2001c70be..11a098137 100644
--- a/app/models/changeset.rb
+++ b/app/models/changeset.rb
@@ -1,5 +1,5 @@
 class Changeset < ActiveRecord::Base
-  require 'xml/libxml'
+  require "xml/libxml"
 
   belongs_to :user, :counter_cache => true
 
@@ -13,7 +13,7 @@ class Changeset < ActiveRecord::Base
   has_many :old_relations
 
   has_many :comments, -> { where(:visible => true).order(:created_at) }, :class_name => "ChangesetComment"
-  has_and_belongs_to_many :subscribers, :class_name => 'User', :join_table => 'changesets_subscribers', :association_foreign_key => 'subscriber_id'
+  has_and_belongs_to_many :subscribers, :class_name => "User", :join_table => "changesets_subscribers", :association_foreign_key => "subscriber_id"
 
   validates_presence_of :id, :on => :update
   validates_presence_of :user_id, :created_at, :closed_at, :num_changes
@@ -50,16 +50,14 @@ class Changeset < ActiveRecord::Base
   end
 
   def set_closed_time_now
-    if is_open?
-      self.closed_at = Time.now.getutc
-    end
+    self.closed_at = Time.now.getutc if is_open?
   end
 
   def self.from_xml(xml, create = false)
     p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR)
     doc = p.parse
 
-    doc.find('//osm/changeset').each do |pt|
+    doc.find("//osm/changeset").each do |pt|
       return Changeset.from_xml_node(pt, create)
     end
     fail OSM::APIBadXMLError.new("changeset", xml, "XML doesn't contain an osm/changeset element.")
@@ -78,10 +76,10 @@ class Changeset < ActiveRecord::Base
       cs.num_changes = 0
     end
 
-    pt.find('tag').each do |tag|
-      fail OSM::APIBadXMLError.new("changeset", pt, "tag is missing key") if tag['k'].nil?
-      fail OSM::APIBadXMLError.new("changeset", pt, "tag is missing value") if tag['v'].nil?
-      cs.add_tag_keyval(tag['k'], tag['v'])
+    pt.find("tag").each do |tag|
+      fail OSM::APIBadXMLError.new("changeset", pt, "tag is missing key") if tag["k"].nil?
+      fail OSM::APIBadXMLError.new("changeset", pt, "tag is missing value") if tag["v"].nil?
+      cs.add_tag_keyval(tag["k"], tag["v"])
     end
 
     cs
@@ -185,8 +183,8 @@ class Changeset < ActiveRecord::Base
   end
 
   def to_xml_node(user_display_name_cache = nil, include_discussion = false)
-    el1 = XML::Node.new 'changeset'
-    el1['id'] = id.to_s
+    el1 = XML::Node.new "changeset"
+    el1["id"] = id.to_s
 
     user_display_name_cache = {} if user_display_name_cache.nil?
 
@@ -198,34 +196,32 @@ class Changeset < ActiveRecord::Base
       user_display_name_cache[user_id] = nil
     end
 
-    el1['user'] = user_display_name_cache[user_id] unless user_display_name_cache[user_id].nil?
-    el1['uid'] = user_id.to_s if user.data_public?
+    el1["user"] = user_display_name_cache[user_id] unless user_display_name_cache[user_id].nil?
+    el1["uid"] = user_id.to_s if user.data_public?
 
     tags.each do |k, v|
-      el2 = XML::Node.new('tag')
-      el2['k'] = k.to_s
-      el2['v'] = v.to_s
+      el2 = XML::Node.new("tag")
+      el2["k"] = k.to_s
+      el2["v"] = v.to_s
       el1 << el2
     end
 
-    el1['created_at'] = created_at.xmlschema
-    el1['closed_at'] = closed_at.xmlschema unless is_open?
-    el1['open'] = is_open?.to_s
+    el1["created_at"] = created_at.xmlschema
+    el1["closed_at"] = closed_at.xmlschema unless is_open?
+    el1["open"] = is_open?.to_s
 
-    if bbox.complete?
-      bbox.to_unscaled.add_bounds_to(el1, '_')
-    end
+    bbox.to_unscaled.add_bounds_to(el1, "_") if bbox.complete?
 
-    el1['comments_count'] = comments.count.to_s
+    el1["comments_count"] = comments.count.to_s
 
     if include_discussion
-      el2 = XML::Node.new('discussion')
+      el2 = XML::Node.new("discussion")
       comments.includes(:author).each do |comment|
-        el3 = XML::Node.new('comment')
-        el3['date'] = comment.created_at.xmlschema
-        el3['uid'] = comment.author.id.to_s if comment.author.data_public?
-        el3['user'] = comment.author.display_name.to_s if comment.author.data_public?
-        el4 = XML::Node.new('text')
+        el3 = XML::Node.new("comment")
+        el3["date"] = comment.created_at.xmlschema
+        el3["uid"] = comment.author.id.to_s if comment.author.data_public?
+        el3["user"] = comment.author.display_name.to_s if comment.author.data_public?
+        el4 = XML::Node.new("text")
         el4.content = comment.body.to_s
         el3 << el4
         el2 << el3
@@ -246,14 +242,10 @@ class Changeset < ActiveRecord::Base
   # bounding box, only the tags of the changeset.
   def update_from(other, user)
     # ensure that only the user who opened the changeset may modify it.
-    unless user.id == user_id
-      fail OSM::APIUserChangesetMismatchError.new
-    end
+    fail OSM::APIUserChangesetMismatchError.new unless user.id == user_id
 
     # can't change a closed changeset
-    unless is_open?
-      fail OSM::APIChangesetAlreadyClosedError.new(self)
-    end
+    fail OSM::APIChangesetAlreadyClosedError.new(self) unless is_open?
 
     # copy the other's tags
     self.tags = other.tags