X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/effb1b7f4170bb7244c4dfffcbe6134fe00e2bc4..03cad948e30d8f82d0c1c5e249cd6c92bb44dd3d:/test/models/changeset_comment_test.rb

diff --git a/test/models/changeset_comment_test.rb b/test/models/changeset_comment_test.rb
index 8e8d0cd70..2139c8d39 100644
--- a/test/models/changeset_comment_test.rb
+++ b/test/models/changeset_comment_test.rb
@@ -6,27 +6,27 @@ class ChangesetCommentTest < ActiveSupport::TestCase
     comment = create(:changeset_comment)
 
     comment.author = nil
-    assert !comment.valid?
+    assert_not comment.valid?
 
     comment.author_id = 999111
-    assert !comment.valid?
+    assert_not comment.valid?
   end
 
   def test_does_not_accept_invalid_changeset
     comment = create(:changeset_comment)
 
     comment.changeset = nil
-    assert !comment.valid?
+    assert_not comment.valid?
 
     comment.changeset_id = 999111
-    assert !comment.valid?
+    assert_not comment.valid?
   end
 
   def test_does_not_accept_empty_visible
     comment = create(:changeset_comment)
 
     comment.visible = nil
-    assert !comment.valid?
+    assert_not comment.valid?
   end
 
   def test_comments_of_changeset_count
@@ -44,13 +44,13 @@ class ChangesetCommentTest < ActiveSupport::TestCase
     ok.each do |body|
       changeset_comment = create(:changeset_comment)
       changeset_comment.body = body
-      assert changeset_comment.valid?, "#{body} is invalid, when it should be"
+      assert_predicate changeset_comment, :valid?, "#{body} is invalid, when it should be"
     end
 
     bad.each do |body|
       changeset_comment = create(:changeset_comment)
       changeset_comment.body = body
-      assert !changeset_comment.valid?, "#{body} is valid when it shouldn't be"
+      assert_not changeset_comment.valid?, "#{body} is valid when it shouldn't be"
     end
   end
 end