]> git.openstreetmap.org Git - rails.git/commitdiff
Blacklist all Google imagery with one regex
authorPaul Norman <penorman@mac.com>
Sat, 13 Aug 2016 20:56:20 +0000 (13:56 -0700)
committerTom Hughes <tom@compton.nu>
Sun, 14 Aug 2016 07:22:46 +0000 (08:22 +0100)
This expression catches 100% of Google imagery seen in imagery_used
tags with no false positives.

It won't stop someone who tries to load "https://www.google.com/maps" as
imagery, but that will fail to get imagery anyway.

config/example.application.yml

index 1f0705bd3a03adbbf561f98d900f51ce34b9b0fd..9234099b774005a37fb934129e9804dd77ba880b 100644 (file)
@@ -87,9 +87,9 @@ defaults: &defaults
   require_terms_agreed: false
   # Imagery to return in capabilities as blacklisted
   imagery_blacklist:
   require_terms_agreed: false
   # Imagery to return in capabilities as blacklisted
   imagery_blacklist:
-    - ".*\\.googleapis\\.com/.*"
-    - ".*\\.google\\.com/.*"
-    - ".*\\.google\\.ru/.*"
+    # Current Google imagery URLs have google or googleapis in the domain
+    # with a vt or kh endpoint, and x, y and z query parameters
+    - ".*\\.google(apis)?\\..*/(vt|kh)[\\?/].*([xyz]=.*){3}.*"
   # URL of Overpass instance to use for feature queries
   overpass_url: "//overpass-api.de/api/interpreter"
   # Routing endpoints
   # URL of Overpass instance to use for feature queries
   overpass_url: "//overpass-api.de/api/interpreter"
   # Routing endpoints