Fixed bug in _blocks partial when used by the index view.

diff --git a/app/views/user_blocks/_blocks.html.erb b/app/views/user_blocks/_blocks.html.erb
index cdb224c2e36ee44444276531056f3556dfd45412..7127cc283721059a1e4c52b938b0d38a02f0518a 100644 (file)
--- a/app/views/user_blocks/_blocks.html.erb
+++ b/app/views/user_blocks/_blocks.html.erb
@@ -1,4 +1,3 @@
-<% unless @user_blocks.empty? %>
 <table id="block_list" cellpadding="3">
   <tr>
     <% if show_user_name %>
@@ -18,6 +17,3 @@
   </tr>
   <%= render :partial => 'block', :locals => {:show_revoke_link => show_revoke_link, :show_user_name => show_user_name, :show_creator_name => show_creator_name }, :collection => @user_blocks %>
 </table>
-<% else %>
-<p><%= t "user_block.#{blocks_by_on}.empty", :name => h(@this_user.display_name) %></p>
-<% end %>

diff --git a/app/views/user_blocks/blocks_by.html.erb b/app/views/user_blocks/blocks_by.html.erb
index 1a910001f807ea449284fb3b9d12e2cf49ef84d3..c9158536b9708836d2017407218f8ad45fd45f2a 100644 (file)
--- a/app/views/user_blocks/blocks_by.html.erb
+++ b/app/views/user_blocks/blocks_by.html.erb
@@ -1,4 +1,8 @@
 <% @title = t('user_block.blocks_by.title', :name => h(@this_user.display_name)) %>
 <h1><%= t('user_block.blocks_by.heading', :name => link_to(h(@this_user.display_name), {:controller => 'user', :action => 'view', :display_name => @this_user.display_name})) %></h1>
 
-<%= render :partial => 'blocks', :locals => { :blocks_by_on => 'blocks_by', :show_revoke_link => (@user and @user.moderator?), :show_user_name => true, :show_creator_name => false } %>
+<% unless @user_blocks.empty? %>
+<%= render :partial => 'blocks', :locals => { :show_revoke_link => (@user and @user.moderator?), :show_user_name => true, :show_creator_name => false } %>
+<% else %>
+<p><%= t "user_block.blocks_by.empty", :name => h(@this_user.display_name) %></p>
+<% end %>

diff --git a/app/views/user_blocks/blocks_on.html.erb b/app/views/user_blocks/blocks_on.html.erb
index 9a2b8bc5f3cbd8e251c209af063e8cc2278dadb9..2074af433defaf027844eab07c92cf80b9dacd31 100644 (file)
--- a/app/views/user_blocks/blocks_on.html.erb
+++ b/app/views/user_blocks/blocks_on.html.erb
@@ -1,4 +1,8 @@
 <% @title = t('user_block.blocks_on.title', :name => h(@this_user.display_name)) %>
 <h1><%= t('user_block.blocks_on.heading', :name => link_to(h(@this_user.display_name), {:controller => 'user', :action => 'view', :display_name => @this_user.display_name})) %></h1>
 
-<%= render :partial => 'blocks', :locals => { :blocks_by_on => 'blocks_on', :show_revoke_link => (@user and @user.moderator?), :show_user_name => false, :show_creator_name => true } %>
+<% unless @user_blocks.empty? %>
+<%= render :partial => 'blocks', :locals => { :show_revoke_link => (@user and @user.moderator?), :show_user_name => false, :show_creator_name => true } %>
+<% else %>
+<p><%= t "user_block.blocks_on.empty", :name => h(@this_user.display_name) %></p>
+<% end %>

diff --git a/app/views/user_blocks/index.html.erb b/app/views/user_blocks/index.html.erb
index 8d645f46589b7fe8d281da3c7492c57af7da97b6..2baf91e5f25559e7975e281333d35c3b98805a96 100644 (file)
--- a/app/views/user_blocks/index.html.erb
+++ b/app/views/user_blocks/index.html.erb
@@ -1,4 +1,8 @@
 <% @title = t('user_block.index.title') %>
 <h1><%= t('user_block.index.heading') %></h1>
 
+<% unless @user_blocks.empty? %>
 <%= render :partial => 'blocks', :locals => { :show_revoke_link => (@user and @user.moderator?), :show_user_name => true, :show_creator_name => true } %>
+<% else %>
+<p><%= t "user_block.index.empty" %></p>
+<% end %>

diff --git a/config/locales/en.yml b/config/locales/en.yml
index fabfba040fb23175541f44c7877adecdc492b13c..f8a424b45be57247c0872a26062dafeaeca03e6e 100644 (file)
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -1073,6 +1073,7 @@ en:
     index:
       title: "User blocks"
       heading: "List of user blocks"
+      empty: "No blocks have been made yet."
     revoke:
       title: "Revoking block on {{block_on}}"
       heading: "Revoking block on {{block_on}} by {{block_by}}"