Avoid trying to resize non-resizable images
authorTom Hughes <tom@compton.nu>
Wed, 31 Jul 2019 10:42:09 +0000 (11:42 +0100)
committerTom Hughes <tom@compton.nu>
Wed, 31 Jul 2019 10:42:09 +0000 (11:42 +0100)
Fixed #2329

app/helpers/user_helper.rb

index 7914805..74f1638 100644 (file)
@@ -8,7 +8,7 @@ module UserHelper
     if user.image_use_gravatar
       user_gravatar_tag(user, options)
     elsif user.avatar.attached?
-      image_tag user.avatar.variant(:resize => "100x100>"), options
+      image_tag user_avatar_variant(user, :resize => "100x100>"), options
     else
       image_tag "avatar_large.png", options
     end
@@ -21,7 +21,7 @@ module UserHelper
     if user.image_use_gravatar
       user_gravatar_tag(user, options)
     elsif user.avatar.attached?
-      image_tag user.avatar.variant(:resize => "50x50>"), options
+      image_tag user_avatar_variant(user, :resize => "50x50>"), options
     else
       image_tag "avatar_small.png", options
     end
@@ -34,7 +34,7 @@ module UserHelper
     if user.image_use_gravatar
       user_gravatar_tag(user, options)
     elsif user.avatar.attached?
-      image_tag user.avatar.variant(:resize => "50x50>"), options
+      image_tag user_avatar_variant(user, :resize => "50x50>"), options
     else
       image_tag "avatar_small.png", options
     end
@@ -44,7 +44,7 @@ module UserHelper
     if user.image_use_gravatar
       user_gravatar_url(user, options)
     elsif user.avatar.attached?
-      polymorphic_url(user.avatar.variant(:resize => "100x100>"), :host => Settings.server_url)
+      polymorphic_url(user_avatar_variant(user, :resize => "100x100>"), :host => Settings.server_url)
     else
       image_url("avatar_large.png")
     end
@@ -67,6 +67,16 @@ module UserHelper
 
   private
 
+  # Local avatar support
+
+  def user_avatar_variant(user, options)
+    if user.avatar.variable?
+      user.avatar.variant(options)
+    else
+      user.avatar
+    end
+  end
+
   # Gravatar support
 
   # See http://en.gravatar.com/site/implement/images/ for details.