]> git.openstreetmap.org Git - rails.git/commitdiff
Refactor the query results to use bootstrap list-group-flush
authorAndy Allan <git@gravitystorm.co.uk>
Wed, 8 Jan 2020 15:00:18 +0000 (16:00 +0100)
committerAndy Allan <git@gravitystorm.co.uk>
Wed, 8 Jan 2020 15:00:18 +0000 (16:00 +0100)
app/assets/javascripts/index/query.js
app/assets/stylesheets/_bootstrap-custom.scss
app/assets/stylesheets/common.scss
app/views/browse/query.html.erb

index 5c6e5817080efe09680a7dccb2564106efe28713..514d6dbb25b6b6619a481de954802cbbd2f10ea4 100644 (file)
@@ -214,17 +214,15 @@ OSM.Query = function (map) {
 
           if (interestingFeature(element)) {
             var $li = $("<li>")
-              .addClass("query-result")
+              .addClass("query-result list-group-item")
               .data("geometry", featureGeometry(element))
-              .appendTo($ul);
-            var $p = $("<p>")
               .text(featurePrefix(element) + " ")
-              .appendTo($li);
+              .appendTo($ul);
 
             $("<a>")
               .attr("href", "/" + element.type + "/" + element.id)
               .text(featureName(element))
-              .appendTo($p);
+              .appendTo($li);
           }
         }
 
index 96d37415f33054d54b3615d9c3342106b1a75659..c07fc2d07e47080dc140aac6ed4d3cffc1afd339 100644 (file)
@@ -32,7 +32,7 @@
 @import "bootstrap/alert";
 // @import "bootstrap/progress";
 // @import "bootstrap/media";
-// @import "bootstrap/list-group";
+@import "bootstrap/list-group";
 // @import "bootstrap/close";
 // @import "bootstrap/toasts";
 // @import "bootstrap/modal";
index 3d013339df6e6d370247192d84ad93fcf9bb13bb..68fc8702cafe2177c82fef216bc76c399d4d931b 100644 (file)
@@ -1277,17 +1277,10 @@ tr.turn:hover {
 
   .query-results {
     display: none;
-
-    h3 {
-      padding: $lineheight $lineheight $lineheight/2;
-      margin: 0;
-    }
+    padding: 0 $lineheight $lineheight/2;
 
     ul {
       li {
-        padding: 15px 20px;
-        border-bottom: 1px solid $grey;
-
         &.query-result {
           cursor: pointer;
         }
index ea40a00dbcf7ee91189efd95447bf3edbe0b0034..ad6fdddb53e360068c1c598c3ed30299f3b505ea 100644 (file)
 <div id="query-nearby" class="query-results">
   <h3><%= t(".nearby") %></h3>
   <%= image_tag "searching.gif", :class => "loader" %>
-  <ul class="query-results-list"></ul>
+  <div>
+    <ul class="query-results-list list-group list-group-flush"></ul>
+  </div>
 </div>
 
 <div id="query-isin" class="query-results">
   <h3><%= t(".enclosing") %></h3>
   <%= image_tag "searching.gif", :class => "loader" %>
-  <ul class="query-results-list"></ul>
+  <div>
+    <ul class="query-results-list list-group list-group-flush"></ul>
+  </div>
 </div>