]> git.openstreetmap.org Git - rails.git/commitdiff
Generate email change token before changing the address
authorTom Hughes <tom@compton.nu>
Tue, 27 Feb 2024 20:53:51 +0000 (20:53 +0000)
committerTom Hughes <tom@compton.nu>
Tue, 27 Feb 2024 20:53:51 +0000 (20:53 +0000)
app/controllers/concerns/user_methods.rb

index 8cba09827225a31b8ba291dfb9cb41fb30baa38d..28305b5c3d55e2beed6c77cefbe6639532f42f2f 100644 (file)
@@ -45,13 +45,15 @@ module UserMethods
       if user.new_email.blank? || user.new_email == user.email
         flash[:notice] = t "accounts.update.success"
       else
+        token = user.generate_token_for(:new_email)
+
         user.email = user.new_email
 
         if user.valid?
           flash[:notice] = t "accounts.update.success_confirm_needed"
 
           begin
-            UserMailer.email_confirm(user, user.generate_token_for(:new_email)).deliver_later
+            UserMailer.email_confirm(user, token).deliver_later
           rescue StandardError
             # Ignore errors sending email
           end