Refactor mapLayers to create layers up front

diff --git a/app/assets/javascripts/index.js b/app/assets/javascripts/index.js
index 2cabfc5d0369105b5152b9650923c127c1e2c2dc..ba2aa26444ab8cc065537d124bd76fb8a4b44e4e 100644 (file)
--- a/app/assets/javascripts/index.js
+++ b/app/assets/javascripts/index.js
@@ -19,10 +19,6 @@ $(document).ready(function () {
 
   layers = mapLayers();
 
-  for (var i = 0; i < layers.length; i++) {
-    layers[i].layer = new (layers[i].klass)(layers[i]);
-  }
-
   layers[0].layer.addTo(map);
 
   $("#map").on("resized", function () {

diff --git a/app/assets/javascripts/map.js.erb b/app/assets/javascripts/map.js.erb
index a3fd53a682e7bdccbe84e1ab44758cf7fb05e4af..74aaf5579b75d825677fca18f8d93f912d1fe212 100644 (file)
--- a/app/assets/javascripts/map.js.erb
+++ b/app/assets/javascripts/map.js.erb
@@ -16,36 +16,31 @@ var objectLayer;
 var objectLoader;
 
 function mapLayers() {
-  return [
-    {
-      klass: L.OSM.Mapnik,
-      attribution: "",
-      keyid: "mapnik",
-      layerCode: "M",
-      name: I18n.t("javascripts.map.base.standard")
-    },
-    {
-      klass: L.OSM.CycleMap,
-      attribution: "Tiles courtesy of <a href='http://www.opencyclemap.org/' target='_blank'>Andy Allan</a>",
-      keyid: "cyclemap",
-      layerCode: "C",
-      name: I18n.t("javascripts.map.base.cycle_map")
-    },
-    {
-      klass: L.OSM.TransportMap,
-      attribution: "Tiles courtesy of <a href='http://www.opencyclemap.org/' target='_blank'>Andy Allan</a>",
-      keyid: "transportmap",
-      layerCode: "T",
-      name: I18n.t("javascripts.map.base.transport_map")
-    },
-    {
-      klass: L.OSM.MapQuestOpen,
-      attribution: "Tiles courtesy of <a href='http://www.mapquest.com/' target='_blank'>MapQuest</a> <img src='http://developer.mapquest.com/content/osm/mq_logo.png'>",
-      keyid: "mapquest",
-      layerCode: "Q",
-      name: I18n.t("javascripts.map.base.mapquest")
-    }
-  ]
+  return [{
+    layer: new L.OSM.Mapnik(),
+    attribution: "",
+    keyid: "mapnik",
+    layerCode: "M",
+    name: I18n.t("javascripts.map.base.standard")
+  }, {
+    layer: new L.OSM.CycleMap(),
+    attribution: "Tiles courtesy of <a href='http://www.opencyclemap.org/' target='_blank'>Andy Allan</a>",
+    keyid: "cyclemap",
+    layerCode: "C",
+    name: I18n.t("javascripts.map.base.cycle_map")
+  }, {
+    layer: new L.OSM.TransportMap(),
+    attribution: "Tiles courtesy of <a href='http://www.opencyclemap.org/' target='_blank'>Andy Allan</a>",
+    keyid: "transportmap",
+    layerCode: "T",
+    name: I18n.t("javascripts.map.base.transport_map")
+  }, {
+    layer: new L.OSM.MapQuestOpen(),
+    attribution: "Tiles courtesy of <a href='http://www.mapquest.com/' target='_blank'>MapQuest</a> <img src='http://developer.mapquest.com/content/osm/mq_logo.png'>",
+    keyid: "mapquest",
+    layerCode: "Q",
+    name: I18n.t("javascripts.map.base.mapquest")
+  }]
 }
 
 function getUserIcon(url) {