From: Tom Hughes <tom@compton.nu>
Date: Sat, 29 Feb 2020 17:43:19 +0000 (+0000)
Subject: Fix highlight of changesets with no bounding box
X-Git-Tag: live~2192
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/0f3856fd1c83e4cd92e34b18e047878505888051

Fix highlight of changesets with no bounding box

A changeset with no bounding box has no map layer so trying to
set it's style throws an exception which means we don't get to
the code to set the style on the list entry.

Fixes #2541
---

diff --git a/app/assets/javascripts/index/history.js b/app/assets/javascripts/index/history.js
index 80fb68444..fe64c2959 100644
--- a/app/assets/javascripts/index/history.js
+++ b/app/assets/javascripts/index/history.js
@@ -40,12 +40,14 @@ OSM.History = function (map) {
   };
 
   function highlightChangeset(id) {
-    group.getLayer(id).setStyle({ fillOpacity: 0.3, color: "#FF6600", weight: 3 });
+    var layer = group.getLayer(id);
+    if ( layer ) layer.setStyle({ fillOpacity: 0.3, color: "#FF6600", weight: 3 });
     $("#changeset_" + id).addClass("selected");
   }
 
   function unHighlightChangeset(id) {
-    group.getLayer(id).setStyle({ fillOpacity: 0, color: "#FF9500", weight: 2 });
+    var layer = group.getLayer(id);
+    if ( layer ) layer.setStyle({ fillOpacity: 0, color: "#FF9500", weight: 2 });
     $("#changeset_" + id).removeClass("selected");
   }