From: Tom Hughes <tom@compton.nu>
Date: Sat, 24 Aug 2013 11:38:14 +0000 (+0100)
Subject: Rework piwik configuration
X-Git-Tag: live~4793
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/26855add3861ad496efdcae8598ffdf7d1116074?hp=f26e417cf4d2640b93e066c9138814e24c171ee4;ds=sidebyside

Rework piwik configuration
---

diff --git a/app/assets/javascripts/osm.js.erb b/app/assets/javascripts/osm.js.erb
index eb5ce64f3..5c555a25a 100644
--- a/app/assets/javascripts/osm.js.erb
+++ b/app/assets/javascripts/osm.js.erb
@@ -1,7 +1,6 @@
 OSM = {
-<% if defined?(PIWIK_LOCATION) and defined?(PIWIK_SITE) %>
-  PIWIK_LOCATION:        <%= PIWIK_LOCATION.to_json %>,
-  PIWIK_SITE:            <%= PIWIK_SITE.to_json %>,
+<% if defined?(PIWIK) %>
+  PIWIK:                 <%= PIWIK.to_json %>,
 <% end %>
 
   MAX_REQUEST_AREA:      <%= MAX_REQUEST_AREA.to_json %>,
diff --git a/app/assets/javascripts/piwik.js b/app/assets/javascripts/piwik.js
index d0443ae6d..d81a9ec63 100644
--- a/app/assets/javascripts/piwik.js
+++ b/app/assets/javascripts/piwik.js
@@ -1,13 +1,13 @@
-if (OSM.PIWIK_LOCATION && OSM.PIWIK_SITE) {
+if (OSM.PIWIK) {
   $(document).ready(function () {
-    var base = document.location.protocol + "//" + OSM.PIWIK_LOCATION + "/";
+    var base = document.location.protocol + "//" + OSM.PIWIK.location + "/";
 
     $.ajax({
       url: base + "piwik.js",
       dataType: "script",
       cache: true,
       success: function () {
-        var piwikTracker = Piwik.getTracker(base + "piwik.php", OSM.PIWIK_SITE);
+        var piwikTracker = Piwik.getTracker(base + "piwik.php", OSM.PIWIK.site);
       
         piwikTracker.trackPageView();
         piwikTracker.enableLinkTracking();
diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb
index c3cd9fcf2..a7822e47f 100644
--- a/app/controllers/user_controller.rb
+++ b/app/controllers/user_controller.rb
@@ -86,7 +86,7 @@ class UserController < ApplicationController
         @user.openid_url = nil if @user.openid_url and @user.openid_url.empty?
 
         if @user.save
-          flash[:piwik_goal] = PIWIK_SIGNUP_GOAL if defined?(PIWIK_SIGNUP_GOAL)
+          flash[:piwik_goal] = PIWIK["goals"]["signup"] if defined?(PIWIK)
 
           referer = welcome_path
 
diff --git a/app/views/layouts/site.html.erb b/app/views/layouts/site.html.erb
index 12b5b82c5..97bf06203 100644
--- a/app/views/layouts/site.html.erb
+++ b/app/views/layouts/site.html.erb
@@ -126,8 +126,8 @@
         <%= yield %>
       </div>
     </div>
-    <% if defined?(PIWIK_LOCATION) and defined?(PIWIK_SITE) -%>
-    <noscript><p><img src="<%= request.protocol %><%= PIWIK_LOCATION %>/piwik.php?idsite=<%= PIWIK_SITE %>" style="border:0" alt="" /></p></noscript>
+    <% if defined?(PIWIK) -%>
+    <noscript><p><img src="<%= request.protocol %><%= PIWIK['location'] %>/piwik.php?idsite=<%= PIWIK['site'] %>" style="border:0" alt="" /></p></noscript>
     <% end -%>
   </body>
 </html>
diff --git a/config/example.application.yml b/config/example.application.yml
index c6c15bb1d..d6a855ef5 100644
--- a/config/example.application.yml
+++ b/config/example.application.yml
@@ -84,10 +84,6 @@ defaults: &defaults
   require_terms_seen: false
   # Whether to require users to agree to the CTs before editing
   require_terms_agreed: false
-  # Piwik details
-  #piwik_location: "piwik.openstreetmap.org"
-  #piwik_site: 1
-  #piwik_signup_goal: 1
 
 development:
   <<: *defaults
diff --git a/config/initializers/piwik.rb b/config/initializers/piwik.rb
new file mode 100644
index 000000000..1f054f7d1
--- /dev/null
+++ b/config/initializers/piwik.rb
@@ -0,0 +1,5 @@
+require "yaml"
+
+if File.exists?(piwik_file = File.expand_path("../../piwik.yml", __FILE__))
+  PIWIK = YAML.load_file(piwik_file)
+end