From: Tom Hughes Date: Mon, 10 Sep 2018 18:01:28 +0000 (+0100) Subject: Merge remote-tracking branch 'upstream/pull/1986' X-Git-Tag: live~2841 X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/276599d34fcbd7babc8e34b6859459cb44acabe7?hp=100babbe6cd463198f03f6b409cca2f5de45b4ea Merge remote-tracking branch 'upstream/pull/1986' --- diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss index f9214b24d..cf1019308 100644 --- a/app/assets/stylesheets/common.scss +++ b/app/assets/stylesheets/common.scss @@ -1501,7 +1501,7 @@ tr.turn:hover { /* Rules for the trace view */ -.trace-view { +.trace-show { .trace_pending { color: red; } @@ -1585,7 +1585,7 @@ tr.turn:hover { margin-left: 70px; } -.user-view { +.user-show { // Silly exception; remove when user page is redesigned. .content-inner { max-width: none; @@ -1712,7 +1712,7 @@ tr.turn:hover { } } -.diary_entry-view img.user_thumbnail { +.diary_entry-show img.user_thumbnail { float: left; } diff --git a/app/controllers/diary_entry_controller.rb b/app/controllers/diary_entry_controller.rb index f6da8d870..723fff17e 100644 --- a/app/controllers/diary_entry_controller.rb +++ b/app/controllers/diary_entry_controller.rb @@ -8,7 +8,7 @@ class DiaryEntryController < ApplicationController before_action :check_database_readable before_action :check_database_writable, :only => [:new, :edit, :comment, :hide, :hidecomment, :subscribe, :unsubscribe] before_action :require_administrator, :only => [:hide, :hidecomment] - before_action :allow_thirdparty_images, :only => [:new, :edit, :list, :show, :comments] + before_action :allow_thirdparty_images, :only => [:new, :edit, :index, :show, :comments] def new @title = t "diary_entry.new.title" @@ -29,7 +29,7 @@ class DiaryEntryController < ApplicationController # Subscribe user to diary comments @diary_entry.subscriptions.create(:user => current_user) - redirect_to :action => "list", :display_name => current_user.display_name + redirect_to :action => "index", :display_name => current_user.display_name else render :action => "edit" end @@ -99,12 +99,12 @@ class DiaryEntryController < ApplicationController render :action => "no_such_entry", :status => :not_found end - def list + def index if params[:display_name] @user = User.active.find_by(:display_name => params[:display_name]) if @user - @title = t "diary_entry.list.user_title", :user => @user.display_name + @title = t "diary_entry.index.user_title", :user => @user.display_name @entries = @user.diary_entries else render_unknown_user params[:display_name] @@ -112,7 +112,7 @@ class DiaryEntryController < ApplicationController end elsif params[:friends] if current_user - @title = t "diary_entry.list.title_friends" + @title = t "diary_entry.index.title_friends" @entries = DiaryEntry.where(:user_id => current_user.friend_users) else require_user @@ -120,7 +120,7 @@ class DiaryEntryController < ApplicationController end elsif params[:nearby] if current_user - @title = t "diary_entry.list.title_nearby" + @title = t "diary_entry.index.title_nearby" @entries = DiaryEntry.where(:user_id => current_user.nearby) else require_user @@ -130,10 +130,10 @@ class DiaryEntryController < ApplicationController @entries = DiaryEntry.joins(:user).where(:users => { :status => %w[active confirmed] }) if params[:language] - @title = t "diary_entry.list.in_language_title", :language => Language.find(params[:language]).english_name + @title = t "diary_entry.index.in_language_title", :language => Language.find(params[:language]).english_name @entries = @entries.where(:language_code => params[:language]) else - @title = t "diary_entry.list.title" + @title = t "diary_entry.index.title" end end @@ -157,7 +157,7 @@ class DiaryEntryController < ApplicationController @entries = user.diary_entries @title = t("diary_entry.feed.user.title", :user => user.display_name) @description = t("diary_entry.feed.user.description", :user => user.display_name) - @link = url_for :controller => "diary_entry", :action => "list", :display_name => user.display_name, :host => SERVER_URL, :protocol => SERVER_PROTOCOL + @link = url_for :controller => "diary_entry", :action => "index", :display_name => user.display_name, :host => SERVER_URL, :protocol => SERVER_PROTOCOL else head :not_found return @@ -169,11 +169,11 @@ class DiaryEntryController < ApplicationController @entries = @entries.where(:language_code => params[:language]) @title = t("diary_entry.feed.language.title", :language_name => Language.find(params[:language]).english_name) @description = t("diary_entry.feed.language.description", :language_name => Language.find(params[:language]).english_name) - @link = url_for :controller => "diary_entry", :action => "list", :language => params[:language], :host => SERVER_URL, :protocol => SERVER_PROTOCOL + @link = url_for :controller => "diary_entry", :action => "index", :language => params[:language], :host => SERVER_URL, :protocol => SERVER_PROTOCOL else @title = t("diary_entry.feed.all.title") @description = t("diary_entry.feed.all.description") - @link = url_for :controller => "diary_entry", :action => "list", :host => SERVER_URL, :protocol => SERVER_PROTOCOL + @link = url_for :controller => "diary_entry", :action => "index", :host => SERVER_URL, :protocol => SERVER_PROTOCOL end end @@ -193,7 +193,7 @@ class DiaryEntryController < ApplicationController def hide entry = DiaryEntry.find(params[:id]) entry.update(:visible => false) - redirect_to :action => "list", :display_name => entry.user.display_name + redirect_to :action => "index", :display_name => entry.user.display_name end def hidecomment diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb index 644c62b6f..5aaa9d72b 100644 --- a/app/controllers/user_controller.rb +++ b/app/controllers/user_controller.rb @@ -14,7 +14,7 @@ class UserController < ApplicationController before_action :require_allow_read_prefs, :only => [:api_details] before_action :require_allow_read_gpx, :only => [:api_gpx_files] before_action :require_cookies, :only => [:new, :login, :confirm] - before_action :require_administrator, :only => [:set_status, :delete, :list] + before_action :require_administrator, :only => [:set_status, :delete, :index] around_action :api_call_handle_error, :only => [:api_read, :api_users, :api_details, :api_gpx_files] before_action :lookup_user_by_id, :only => [:api_read] before_action :lookup_user_by_name, :only => [:set_status, :delete] @@ -488,7 +488,7 @@ class UserController < ApplicationController ## # display a list of users matching specified criteria - def list + def index if request.post? ids = params[:user].keys.collect(&:to_i) diff --git a/app/views/diary_entry/_diary_entry.html.erb b/app/views/diary_entry/_diary_entry.html.erb index de62e8e1a..ec2f22601 100644 --- a/app/views/diary_entry/_diary_entry.html.erb +++ b/app/views/diary_entry/_diary_entry.html.erb @@ -7,7 +7,7 @@

<%= link_to h(diary_entry.title), diary_entry_path(diary_entry.user, diary_entry) %>

- <%= raw(t '.posted_by', :link_user => (link_to h(diary_entry.user.display_name), user_path(diary_entry.user)), :created => l(diary_entry.created_at, :format => :blog), :language_link => (link_to h(diary_entry.language.name), :controller => 'diary_entry', :action => 'list', :display_name => nil, :language => diary_entry.language_code)) %> + <%= raw(t '.posted_by', :link_user => (link_to h(diary_entry.user.display_name), user_path(diary_entry.user)), :created => l(diary_entry.created_at, :format => :blog), :language_link => (link_to h(diary_entry.language.name), :controller => 'diary_entry', :action => 'index', :display_name => nil, :language => diary_entry.language_code)) %> @@ -21,7 +21,7 @@ <% end %> contributor terms: - heading: 'Termos do colaborador:' - agreed: Aceptou os novos termos do colaborador. - not yet agreed: Aínda non aceptou os novos termos do colaborador. - review link text: Siga esta ligazón para revisar e aceptar os novos termos - do colaborador. + heading: 'Termos do contribuínte:' + agreed: Aceptou os novos termos do contribuínte. + not yet agreed: Aínda non aceptou os novos termos do contribuínte. + review link text: Siga esta ligazón para revisar e acepta-los novos termos + do contribuínte. agreed_with_pd: Tamén declarou que considera que as súas edicións pertencen ao dominio público. link text: que é isto? @@ -2219,25 +2218,25 @@ gl: preferred editor: 'Editor preferido:' image: 'Imaxe:' gravatar: - gravatar: Usar Gravatar + gravatar: Emprega-lo Gravatar link: http://wiki.openstreetmap.org/wiki/Gravatar link text: que é isto? disabled: Gravatar foi desactivado. enabled: A visualización do seu Gravatar foi activada. new image: Engadir unha imaxe - keep image: Manter a imaxe actual - delete image: Eliminar a imaxe actual - replace image: Substituír a imaxe actual + keep image: Mante-la imaxe actual + delete image: Elimina-la imaxe actual + replace image: Substituí-la imaxe actual image size hint: (as imaxes cadradas de, polo menos, 100x100 funcionan mellor) home location: 'Lugar de orixe:' no home location: Non inseriu o seu lugar de orixe. latitude: 'Latitude:' longitude: 'Lonxitude:' - update home location on click: Quere actualizar o domicilio ao premer sobre - o mapa? + update home location on click: Quere actualiza-lo lugar do enderezo ó premer + sobre o mapa? save changes button: Garda-los cambios make edits public button: Facer públicas todas as miñas edicións - return to profile: Volver ao perfil + return to profile: Voltar ó perfil flash update success confirm needed: Información de usuario actualizada correctamente. Procura no teu correo electrónico unha mensaxe para confirma-lo teu novo enderezo. flash update success: Información de usuario actualizada correctamente. @@ -2261,7 +2260,7 @@ gl: proceso sen problemas. failure: Non se atopou o usuario "%{name}". confirm_email: - heading: Confirma-lo troco do enderezo de correo electrónico + heading: Confirma-lo cambio do enderezo de correo electrónico press confirm button: Prema sobre o botón de confirmación que aparece deseguido para confirmar o seu novo enderezo de correo electrónico. button: Confirmar @@ -2353,7 +2352,7 @@ gl: non_moderator_revoke: Cómpre ser moderador para revogar un bloqueo. not_found: sorry: Non se puido atopar o bloqueo de usuario número %{id}. - back: Volver ao índice + back: Voltar ó índice new: title: Creando un bloqueo a %{name} heading: Creando un bloqueo a %{name} @@ -2378,7 +2377,7 @@ gl: comúns. period: Por canto tempo, a partir de agora, o usuario terá bloqueado o uso da API? - submit: Actualizar o bloqueo + submit: Actualiza-lo bloqueo show: Ollar este bloqueo back: Ollar tódolos bloqueos needs_view: O usuario ten que acceder ao sistema antes de que o bloqueo sexa @@ -2509,7 +2508,7 @@ gl: center_marker: Centrar o mapa no marcador paste_html: Pegue o código HTML para incluílo na páxina web view_larger_map: Ver un mapa máis grande - only_standard_layer: Só a capa estándar pode exportarse como unha imaxe + only_standard_layer: Só a capa estándar pode exportarse coma unha imaxe embed: report_problem: Informar sobre un problema key: @@ -2524,27 +2523,27 @@ gl: title: Amosa-la miña localización popup: Está a {distance} {unit} deste punto base: - standard: Estándar + standard: Mapa estándar cycle_map: Mapa ciclista - transport_map: Mapa de transporte - hot: Humanitario + transport_map: Mapa do transporte + hot: Mapa humanitario layers: header: Capas do mapa notes: Notas do mapa data: Datos do mapa gps: Trazas GPS públicas - overlays: Activar a sobreposición para reparar o mapa + overlays: Activa-las sobreposicións para solucionares os problemas no mapa title: Capas copyright: © Contribuíntes do OpenStreetMap donate_link_text: site: edit_tooltip: Edita-lo mapa edit_disabled_tooltip: Achegue para edita-lo mapa - createnote_tooltip: Engadir unha nota ao mapa + createnote_tooltip: Engadir unha nota ó mapa createnote_disabled_tooltip: Achegar o mapa para engadirlle unha nota map_notes_zoom_in_tooltip: Achegar para veres as notas do mapa map_data_zoom_in_tooltip: Achegar para ver os datos do mapa - queryfeature_tooltip: Consultar as características + queryfeature_tooltip: Consulta-las características queryfeature_disabled_tooltip: Achegar para consulta-las características changesets: show: @@ -2555,10 +2554,10 @@ gl: unhide_comment: amosar notes: new: - intro: Atopou un erro ou descubriu que falta algún dato? Informe aos outros + intro: Atopou un erro ou descobriu que falla algún dato? Informe ós outros cartógrafos para que poidamos solucionalo. Mova o marcador á posición correcta - e escriba unha nota explicando o problema. - advice: A túa nota será pública e poderá empregarse para actualizar o mapa, + e escriba unha nota expoñendo o problema. + advice: A túa nota será pública e poderá empregarse para actualiza-lo mapa, por conseguinte, non insiras información persoal, nin datos de mapas protexidos por dereitos de autoría ou listaxes de directorios. add: Engadir a nota diff --git a/config/locales/km.yml b/config/locales/km.yml index 95d4577b5..eda1328f5 100644 --- a/config/locales/km.yml +++ b/config/locales/km.yml @@ -68,7 +68,7 @@ km: display_name: ​​ឈ្មោះអេក្រង់ (Display name) description: បរិយាយ​ languages: ភាសា​ - pass_crypt: លេខ​សម្ងាត់​ + pass_crypt: ពាក្យ​សម្ងាត់ browse: created: បាន​បង្កើត​ closed: បាន​បិទ @@ -78,6 +78,7 @@ km: deleted_by_html: បានលុបចោល %{time} មុន ដោយ %{user} edited_by_html: បានកែប្រែ %{time} មុន ដោយ %{user} closed_by_html: បានបិទ %{time} មុន ដោយ %{user} + version: កំណែ in_changeset: សំណុំបន្លាស់ប្ដូរ anonymous: អនាមិក no_comment: (គ្មានមតិយោបល់) @@ -95,11 +96,13 @@ km: way_paginated: ផ្លូវចំនួន (%{x}-%{y} ក្នុងចំណោម %{count}) relation: ទំនាក់ទំនងចំនួន (%{count}) relation_paginated: ទំនាក់ទំនងចំនួន (%{x}-%{y} ក្នុងចំណោម %{count}) + comment: មតិយោបល់ (%{count}) changesetxml: សំណុំបន្លាស់ប្ដូរ​ XML feed: title: សំណុំបន្លាស់ប្ដូរ​ %{id} - title_comment: សំនុំ​បំលាស់ប្តូរ​ %{id} - %{comment} + title_comment: សំណុំបន្លាស់ប្តូរ​ %{id} - %{comment} join_discussion: កត់ឈ្មោះចូលដើម្បីចូលរួមពិភាក្សា + discussion: ការពិភាក្សា node: title: ខ្នែង៖ %{name} history_title: ប្រវត្តិខ្នែង៖ %{name} @@ -233,6 +236,10 @@ km: geonames: លទ្ធផលពី GeoNames search_osm_nominatim: prefix: + aerialway: + cable_car: ឡានយោង + chair_lift: កៅអីយោង + pylon: ប៉មខ្សែភ្លើង amenity: arts_centre: មជ្ឍមណ្ឌលសិល្បៈ atm: ATM @@ -370,6 +377,7 @@ km: motorway_link: ផ្លូវល្បឿនលឿន rest_area: កន្លែងសម្រាក road: ផ្លូវ + steps: ជណ្ដើរ stop: ផ្លាកសញ្ញាឈប់ street_lamp: ភ្លើងបំភ្លឺផ្លូវ traffic_signals: ភ្លើងសញ្ញាចរាចរណ៍ @@ -413,7 +421,9 @@ km: vineyard: ចំការទំពាំងបាយជូរ leisure: beach_resort: ឆ្នេរកំសាន្ត + bird_hide: ខ្ទមមើលបក្សី common: ដីរួម + firepit: ចង្ក្រាន fishing: តំបន់ស្ទូចត្រី fitness_centre: មណ្ឌលហាត់ប្រាណ fitness_station: ស្ថានីយ៍ហាត់ប្រាណ @@ -430,8 +440,23 @@ km: stadium: កីឡាដ្ឋាន swimming_pool: អាងហែលទឹក water_park: ឧទ្យានទឹក + man_made: + bridge: ស្ពាន + bunker_silo: ត្រង់សេ + chimney: បំពង់ផ្សែង + dyke: ទំនប់ + flagpole: បង្គោលទង់ជាតិ + kiln: ឡ + petroleum_well: អណ្ដូងប្រេង + wastewater_plant: ស្ថានីយ៍សម្អាតទឹក + water_tower: ប៉មទឹក + water_well: អណ្ដូង military: airfield: មូលដ្ឋានទ័ពអាកាស + bunker: ត្រង់សេ + "yes": មូលដ្ឋានយោធា + mountain_pass: + "yes": ផ្លូវភ្នំ natural: bay: ឆកសមុទ្រ beach: ឆ្នេរខ្សាច់ @@ -440,12 +465,14 @@ km: cliff: ជ្រោះ crater: មាត់ភ្នំភ្លើង dune: ភ្នំខ្សាច់ + forest: ព្រៃ hill: កូនភ្នំ island: កោះ land: ដី mud: ភក់ peak: កំពូល point: ចំនុច + spring: ទឹកផុស strait: ដៃសមុទ្រ tree: ដើមឈើ valley: ជ្រលងភ្នំ @@ -465,7 +492,7 @@ km: insurance: ការិយាល័យធានារ៉ាប់រង it: ការិយាល័យព័តមានវិទ្យា lawyer: មេធាវី - ngo: ការិយាល័យ NGO + ngo: ការិយាល័យអង្គការ telecommunication: ការិយាល័យទូរគមនាគមន៍ travel_agent: ភ្នាក់ងារទេសចរណ៍ "yes": ការិយាល័យ @@ -529,18 +556,42 @@ km: gallery: វិចិត្រសាល gift: ហាងវត្ថុអនុស្សាវរីយ៍ greengrocer: ហាងបន្លែនិងផ្លែឈើ + grocery: ហាងចំណីអាហារ hairdresser: ហាងកាត់សក់និងអ៊ុតសក់ jewelry: ហាងលក់គ្រឿងអល័ង្ការ laundry: ហាងបោកអ៊ុត + market: ផ្សារ massage: ហាងម៉ាស្សា mobile_phone: ហាងទូរស័ព្ទ motorcycle: ហាងទោចក្រយានយន្ត music: ហាងតន្ត្រី newsagent: ហាងកាសែត optician: ហាងវ៉ែនតា + pawnbroker: ហាងបញ្ចាំ + pet: ហាងសត្វចិញ្ចឹម + pharmacy: ឱសថស្ថាន + photo: ហាងថតរូប + seafood: ហាងគ្រឿងសមុទ្រ + second_hand: ហាងជជុះ + shoes: ហាងស្បែកជើង + sports: ហាងសម្ភារៈកីឡា + stationery: បណ្ណាគារ + supermarket: ផ្សារទំនើប + tailor: ហាងកាត់ដេរ + ticket: ហាងសំបុត្រ + tobacco: ហាងបារី + travel_agency: ភ្នាក់ងារទេសចរណ៍ + tyres: ហាងកង់ឡាន tourism: camp_site: កន្លែងបោះតង់ caravan_site: កន្លែងចតឡានបោះតង់ + guest_house: ផ្ទះសំណាក់ + hostel: ផ្ទះសំណាក់ + hotel: សណ្ឋាគារ + museum: សារមន្ទីរ + zoo: សួនសត្វ + waterway: + canal: ព្រែកជីក description: types: cities: ក្រុង​ diff --git a/config/locales/nl.yml b/config/locales/nl.yml index 90f554402..e58bf0215 100644 --- a/config/locales/nl.yml +++ b/config/locales/nl.yml @@ -305,7 +305,7 @@ nl: user_title: Dagboek van %{user} in_language_title: Dagboekberichten in het %{language} new: Nieuw dagboekbericht - new_title: Nieuw bericht in uw dagboek schrijven + new_title: Nieuw bericht in mijn dagboek schrijven no_entries: Het dagboek is leeg recent_entries: Recente dagboekberichten older_entries: Oudere berichten diff --git a/config/locales/sr.yml b/config/locales/sr.yml index 7de950203..d01f00e6a 100644 --- a/config/locales/sr.yml +++ b/config/locales/sr.yml @@ -145,8 +145,8 @@ sr: feed: title: Скуп измена %{id} title_comment: Скуп измена %{id} – %{comment} - join_discussion: Пријавите се да бисте се укључили у разговор - discussion: Разговор + join_discussion: Пријавите се да бисте се придружили дискусији + discussion: Дискусија node: title: 'Тачка: %{name}' history_title: 'Историја тачака: %{name}' @@ -260,12 +260,12 @@ sr: timeout: sorry: Нажалост, преузимање траженог списка измена предуго траје. rss: - title_all: Разговор о скупу измена OpenStreetMap-а - title_particular: 'Разговор о скупу измена #%{changeset_id} OpenStreetMap-а' + title_all: Дискусија о скупу измена OpenStreetMap-а + title_particular: 'Дискусија о скупу измена #%{changeset_id} OpenStreetMap-а' comment: Нови коментар на скуп измена бр. %{changeset_id} корисника %{author} commented_at_html: Ажурирано пре %{when} commented_at_by_html: Ажурирао %{user} пре %{when} - full: Целокупан разговор + full: Цела дискусија diary_entry: new: title: Нови дневнички запис @@ -1472,7 +1472,8 @@ sr: табле. irc: title: IRC - description: Интерактивни разговор на многим језицима и на многе теме. + description: Интерактивно ћаскање на много различитих језицима и на многе + теме. switch2osm: title: switch2osm description: Помоћ за компаније и организације које прелазе на мапе засноване diff --git a/config/locales/sv.yml b/config/locales/sv.yml index b92e20e18..7e9ec3fbe 100644 --- a/config/locales/sv.yml +++ b/config/locales/sv.yml @@ -1787,6 +1787,8 @@ sv: trace_uploaded: Din GPX-fil har laddats upp och väntar på att lagras i databasen. Detta sker vanligtvis inom en halvtimme. När den är klar skickas en e-post till dig. + upload_failed: Tyvärr, GPX-uppladdningen misslyckades. En administratör har + meddelats om felet. Försök igen traces_waiting: one: Du har %{count} GPS-spår som håller på att laddas upp. Vänta gärna på att detta blir klart innan du laddar upp fler, så att du inte blockerar @@ -1811,6 +1813,8 @@ sv: save_button: Spara ändringar visibility: 'Synlighet:' visibility_help: vad betyder detta? + update: + updated: Spår uppdaterades trace_optionals: tags: Taggar show: diff --git a/config/locales/th.yml b/config/locales/th.yml index 4d4e94d78..78d7c9e67 100644 --- a/config/locales/th.yml +++ b/config/locales/th.yml @@ -1705,7 +1705,7 @@ th: remember: จดจำฉันไว้ในระบบ lost password link: ลืมรหัสผ่านหรือ? login_button: ลงชื่อเข้าใช้ - register now: ลงทะเบียนก่อนเลย + register now: สมัครเลย! with username: มีบัญชี OpenStreetMap แล้วหรือยัง? ถ้ามีโปรดเข้าระบบด้วยชื่อผู้ใช้และรหัสผ่านที่ท่านมี with external: นอกจากนี้ ท่านสามารถใช้บัญชีผู้ใช้จากเว็บอื่นในการเข้าใช้งานได้ new to osm: เพิ่งเริ่มใช้ OpenStreetMap หรือ? diff --git a/config/routes.rb b/config/routes.rb index da7e0de71..e60994863 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -215,16 +215,16 @@ OpenStreetMap::Application.routes.draw do # diary pages match "/diary/new" => "diary_entry#new", :via => [:get, :post] - get "/diary/friends" => "diary_entry#list", :friends => true, :as => "friend_diaries" - get "/diary/nearby" => "diary_entry#list", :nearby => true, :as => "nearby_diaries" + get "/diary/friends" => "diary_entry#index", :friends => true, :as => "friend_diaries" + get "/diary/nearby" => "diary_entry#index", :nearby => true, :as => "nearby_diaries" get "/user/:display_name/diary/rss" => "diary_entry#rss", :defaults => { :format => :rss } get "/diary/:language/rss" => "diary_entry#rss", :defaults => { :format => :rss } get "/diary/rss" => "diary_entry#rss", :defaults => { :format => :rss } get "/user/:display_name/diary/comments/:page" => "diary_entry#comments", :page => /[1-9][0-9]*/ get "/user/:display_name/diary/comments/" => "diary_entry#comments" - get "/user/:display_name/diary" => "diary_entry#list" - get "/diary/:language" => "diary_entry#list" - get "/diary" => "diary_entry#list" + get "/user/:display_name/diary" => "diary_entry#index" + get "/diary/:language" => "diary_entry#index" + get "/diary" => "diary_entry#index" get "/user/:display_name/diary/:id" => "diary_entry#show", :id => /\d+/, :as => :diary_entry post "/user/:display_name/diary/:id/newcomment" => "diary_entry#comment", :id => /\d+/ match "/user/:display_name/diary/:id/edit" => "diary_entry#edit", :via => [:get, :post], :id => /\d+/ @@ -242,8 +242,8 @@ OpenStreetMap::Application.routes.draw do get "/user/:display_name/delete" => "user#delete", :as => :delete_user # user lists - match "/users" => "user#list", :via => [:get, :post] - match "/users/:status" => "user#list", :via => [:get, :post] + match "/users" => "user#index", :via => [:get, :post] + match "/users/:status" => "user#index", :via => [:get, :post] # geocoder get "/search" => "geocoder#search" diff --git a/test/controllers/diary_entry_controller_test.rb b/test/controllers/diary_entry_controller_test.rb index 98330f690..b102716d1 100644 --- a/test/controllers/diary_entry_controller_test.rb +++ b/test/controllers/diary_entry_controller_test.rb @@ -16,23 +16,23 @@ class DiaryEntryControllerTest < ActionController::TestCase def test_routes assert_routing( { :path => "/diary", :method => :get }, - { :controller => "diary_entry", :action => "list" } + { :controller => "diary_entry", :action => "index" } ) assert_routing( { :path => "/diary/language", :method => :get }, - { :controller => "diary_entry", :action => "list", :language => "language" } + { :controller => "diary_entry", :action => "index", :language => "language" } ) assert_routing( { :path => "/user/username/diary", :method => :get }, - { :controller => "diary_entry", :action => "list", :display_name => "username" } + { :controller => "diary_entry", :action => "index", :display_name => "username" } ) assert_routing( { :path => "/diary/friends", :method => :get }, - { :controller => "diary_entry", :action => "list", :friends => true } + { :controller => "diary_entry", :action => "index", :friends => true } ) assert_routing( { :path => "/diary/nearby", :method => :get }, - { :controller => "diary_entry", :action => "list", :nearby => true } + { :controller => "diary_entry", :action => "index", :nearby => true } ) assert_routing( @@ -170,7 +170,7 @@ class DiaryEntryControllerTest < ActionController::TestCase :session => { :user => user.id } end assert_response :redirect - assert_redirected_to :action => :list, :display_name => user.display_name + assert_redirected_to :action => :index, :display_name => user.display_name entry = DiaryEntry.order(:id).last assert_equal user.id, entry.user_id assert_equal "New Title", entry.title @@ -198,7 +198,7 @@ class DiaryEntryControllerTest < ActionController::TestCase :session => { :user => user.id } end assert_response :redirect - assert_redirected_to :action => :list, :display_name => user.display_name + assert_redirected_to :action => :index, :display_name => user.display_name entry = DiaryEntry.order(:id).last assert_equal user.id, entry.user_id assert_equal "New Title", entry.title @@ -227,7 +227,7 @@ class DiaryEntryControllerTest < ActionController::TestCase :session => { :user => user.id } end assert_response :redirect - assert_redirected_to :action => :list, :display_name => user.display_name + assert_redirected_to :action => :index, :display_name => user.display_name entry = DiaryEntry.order(:id).last assert_equal user.id, entry.user_id assert_equal spammy_title, entry.title @@ -236,7 +236,7 @@ class DiaryEntryControllerTest < ActionController::TestCase assert_equal "suspended", User.find(user.id).status # Follow the redirect - get :list, + get :index, :params => { :display_name => user.display_name }, :session => { :user => user } assert_response :redirect @@ -470,7 +470,7 @@ class DiaryEntryControllerTest < ActionController::TestCase assert_equal "suspended", User.find(other_user.id).status # Follow the redirect - get :list, + get :index, :params => { :display_name => user.display_name }, :session => { :user => other_user } assert_response :redirect @@ -483,17 +483,17 @@ class DiaryEntryControllerTest < ActionController::TestCase assert_select ".diary-comment", :count => 0 end - def test_list_all + def test_index_all diary_entry = create(:diary_entry) geo_entry = create(:diary_entry, :latitude => 51.50763, :longitude => -0.10781) public_entry = create(:diary_entry, :user => create(:user)) # Try a list of all diary entries - get :list - check_diary_list diary_entry, geo_entry, public_entry + get :index + check_diary_index diary_entry, geo_entry, public_entry end - def test_list_user + def test_index_user user = create(:user) other_user = create(:user) @@ -502,16 +502,16 @@ class DiaryEntryControllerTest < ActionController::TestCase _other_entry = create(:diary_entry, :user => other_user) # Try a list of diary entries for a valid user - get :list, :params => { :display_name => user.display_name } - check_diary_list diary_entry, geo_entry + get :index, :params => { :display_name => user.display_name } + check_diary_index diary_entry, geo_entry # Try a list of diary entries for an invalid user - get :list, :params => { :display_name => "No Such User" } + get :index, :params => { :display_name => "No Such User" } assert_response :not_found assert_template "user/no_such_user" end - def test_list_friends + def test_index_friends user = create(:user) other_user = create(:user) friend = create(:friend, :befriender => user) @@ -519,36 +519,36 @@ class DiaryEntryControllerTest < ActionController::TestCase _other_entry = create(:diary_entry, :user => other_user) # Try a list of diary entries for your friends when not logged in - get :list, :params => { :friends => true } + get :index, :params => { :friends => true } assert_response :redirect assert_redirected_to :controller => :user, :action => :login, :referer => "/diary/friends" # Try a list of diary entries for your friends when logged in - get :list, :params => { :friends => true }, :session => { :user => user } - check_diary_list diary_entry - get :list, :params => { :friends => true }, :session => { :user => other_user } - check_diary_list + get :index, :params => { :friends => true }, :session => { :user => user } + check_diary_index diary_entry + get :index, :params => { :friends => true }, :session => { :user => other_user } + check_diary_index end - def test_list_nearby + def test_index_nearby user = create(:user, :home_lat => 12, :home_lon => 12) nearby_user = create(:user, :home_lat => 11.9, :home_lon => 12.1) diary_entry = create(:diary_entry, :user => user) # Try a list of diary entries for nearby users when not logged in - get :list, :params => { :nearby => true } + get :index, :params => { :nearby => true } assert_response :redirect assert_redirected_to :controller => :user, :action => :login, :referer => "/diary/nearby" # Try a list of diary entries for nearby users when logged in - get :list, :params => { :nearby => true }, :session => { :user => nearby_user } - check_diary_list diary_entry - get :list, :params => { :nearby => true }, :session => { :user => user } - check_diary_list + get :index, :params => { :nearby => true }, :session => { :user => nearby_user } + check_diary_index diary_entry + get :index, :params => { :nearby => true }, :session => { :user => user } + check_diary_index end - def test_list_language + def test_index_language create(:language, :code => "de") create(:language, :code => "sl") diary_entry_en = create(:diary_entry, :language_code => "en") @@ -556,29 +556,29 @@ class DiaryEntryControllerTest < ActionController::TestCase diary_entry_de = create(:diary_entry, :language_code => "de") # Try a list of diary entries in english - get :list, :params => { :language => "en" } - check_diary_list diary_entry_en, diary_entry_en2 + get :index, :params => { :language => "en" } + check_diary_index diary_entry_en, diary_entry_en2 # Try a list of diary entries in german - get :list, :params => { :language => "de" } - check_diary_list diary_entry_de + get :index, :params => { :language => "de" } + check_diary_index diary_entry_de # Try a list of diary entries in slovenian - get :list, :params => { :language => "sl" } - check_diary_list + get :index, :params => { :language => "sl" } + check_diary_index end - def test_list_paged + def test_index_paged # Create several pages worth of diary entries create_list(:diary_entry, 50) - # Try and get the list - get :list + # Try and get the index + get :index assert_response :success assert_select "div.diary_post", :count => 20 # Try and get the second page - get :list, :params => { :page => 2 } + get :index, :params => { :page => 2 } assert_response :success assert_select "div.diary_post", :count => 20 end @@ -728,7 +728,7 @@ class DiaryEntryControllerTest < ActionController::TestCase :params => { :display_name => user.display_name, :id => diary_entry.id }, :session => { :user => create(:administrator_user) } assert_response :redirect - assert_redirected_to :action => :list, :display_name => user.display_name + assert_redirected_to :action => :index, :display_name => user.display_name assert_equal false, DiaryEntry.find(diary_entry.id).visible end @@ -881,9 +881,9 @@ class DiaryEntryControllerTest < ActionController::TestCase private - def check_diary_list(*entries) + def check_diary_index(*entries) assert_response :success - assert_template "list" + assert_template "index" assert_no_missing_translations assert_select "div.diary_post", entries.count diff --git a/test/controllers/traces_controller_test.rb b/test/controllers/traces_controller_test.rb index 605c47555..7cfc468b2 100644 --- a/test/controllers/traces_controller_test.rb +++ b/test/controllers/traces_controller_test.rb @@ -1032,8 +1032,8 @@ class TracesControllerTest < ActionController::TestCase assert_select "item", :count => traces.length do |items| traces.zip(items).each do |trace, item| assert_select item, "title", trace.name - assert_select item, "link", "http://test.host/user/#{trace.user.display_name.gsub(' ', '%20')}/traces/#{trace.id}" - assert_select item, "guid", "http://test.host/user/#{trace.user.display_name.gsub(' ', '%20')}/traces/#{trace.id}" + assert_select item, "link", "http://test.host/user/#{ERB::Util.u(trace.user.display_name)}/traces/#{trace.id}" + assert_select item, "guid", "http://test.host/user/#{ERB::Util.u(trace.user.display_name)}/traces/#{trace.id}" assert_select item, "description" # assert_select item, "dc:creator", trace.user.display_name assert_select item, "pubDate", trace.timestamp.rfc822 diff --git a/test/controllers/user_controller_test.rb b/test/controllers/user_controller_test.rb index 55b2c2114..f2aaffb9b 100644 --- a/test/controllers/user_controller_test.rb +++ b/test/controllers/user_controller_test.rb @@ -170,19 +170,19 @@ class UserControllerTest < ActionController::TestCase assert_routing( { :path => "/users", :method => :get }, - { :controller => "user", :action => "list" } + { :controller => "user", :action => "index" } ) assert_routing( { :path => "/users", :method => :post }, - { :controller => "user", :action => "list" } + { :controller => "user", :action => "index" } ) assert_routing( { :path => "/users/status", :method => :get }, - { :controller => "user", :action => "list", :status => "status" } + { :controller => "user", :action => "index", :status => "status" } ) assert_routing( { :path => "/users/status", :method => :post }, - { :controller => "user", :action => "list", :status => "status" } + { :controller => "user", :action => "index", :status => "status" } ) end @@ -1431,7 +1431,7 @@ class UserControllerTest < ActionController::TestCase assert_equal "deleted", user.status end - def test_list_get + def test_index_get user = create(:user) moderator_user = create(:moderator_user) administrator_user = create(:administrator_user) @@ -1443,21 +1443,21 @@ class UserControllerTest < ActionController::TestCase assert_equal 7, User.count # Shouldn't work when not logged in - get :list + get :index assert_response :redirect assert_redirected_to :action => :login, :referer => users_path session[:user] = user.id # Shouldn't work when logged in as a normal user - get :list + get :index assert_response :redirect assert_redirected_to :action => :login, :referer => users_path session[:user] = moderator_user.id # Shouldn't work when logged in as a moderator - get :list + get :index assert_response :redirect assert_redirected_to :action => :login, :referer => users_path @@ -1465,25 +1465,25 @@ class UserControllerTest < ActionController::TestCase # Note there is a header row, so all row counts are users + 1 # Should work when logged in as an administrator - get :list + get :index assert_response :success - assert_template :list + assert_template :index assert_select "table#user_list tr", :count => 7 + 1 # Should be able to limit by status - get :list, :params => { :status => "suspended" } + get :index, :params => { :status => "suspended" } assert_response :success - assert_template :list + assert_template :index assert_select "table#user_list tr", :count => 1 + 1 # Should be able to limit by IP address - get :list, :params => { :ip => "1.2.3.4" } + get :index, :params => { :ip => "1.2.3.4" } assert_response :success - assert_template :list + assert_template :index assert_select "table#user_list tr", :count => 1 + 1 end - def test_list_get_paginated + def test_index_get_paginated 1.upto(100).each do |n| User.create(:display_name => "extra_#{n}", :email => "extra#{n}@example.com", @@ -1495,29 +1495,29 @@ class UserControllerTest < ActionController::TestCase # 100 examples, an administrator, and a granter for the admin. assert_equal 102, User.count - get :list + get :index assert_response :success - assert_template :list + assert_template :index assert_select "table#user_list tr", :count => 51 - get :list, :params => { :page => 2 } + get :index, :params => { :page => 2 } assert_response :success - assert_template :list + assert_template :index assert_select "table#user_list tr", :count => 51 - get :list, :params => { :page => 3 } + get :index, :params => { :page => 3 } assert_response :success - assert_template :list + assert_template :index assert_select "table#user_list tr", :count => 3 end - def test_list_post_confirm + def test_index_post_confirm inactive_user = create(:user, :pending) suspended_user = create(:user, :suspended) # Shouldn't work when not logged in assert_no_difference "User.active.count" do - post :list, :params => { :confirm => 1, :user => { inactive_user.id => 1, suspended_user.id => 1 } } + post :index, :params => { :confirm => 1, :user => { inactive_user.id => 1, suspended_user.id => 1 } } end assert_response :redirect assert_redirected_to :action => :login, :referer => users_path @@ -1528,7 +1528,7 @@ class UserControllerTest < ActionController::TestCase # Shouldn't work when logged in as a normal user assert_no_difference "User.active.count" do - post :list, :params => { :confirm => 1, :user => { inactive_user.id => 1, suspended_user.id => 1 } } + post :index, :params => { :confirm => 1, :user => { inactive_user.id => 1, suspended_user.id => 1 } } end assert_response :redirect assert_redirected_to :action => :login, :referer => users_path @@ -1539,7 +1539,7 @@ class UserControllerTest < ActionController::TestCase # Shouldn't work when logged in as a moderator assert_no_difference "User.active.count" do - post :list, :params => { :confirm => 1, :user => { inactive_user.id => 1, suspended_user.id => 1 } } + post :index, :params => { :confirm => 1, :user => { inactive_user.id => 1, suspended_user.id => 1 } } end assert_response :redirect assert_redirected_to :action => :login, :referer => users_path @@ -1550,21 +1550,21 @@ class UserControllerTest < ActionController::TestCase # Should work when logged in as an administrator assert_difference "User.active.count", 2 do - post :list, :params => { :confirm => 1, :user => { inactive_user.id => 1, suspended_user.id => 1 } } + post :index, :params => { :confirm => 1, :user => { inactive_user.id => 1, suspended_user.id => 1 } } end assert_response :redirect - assert_redirected_to :action => :list + assert_redirected_to :action => :index assert_equal "confirmed", inactive_user.reload.status assert_equal "confirmed", suspended_user.reload.status end - def test_list_post_hide + def test_index_post_hide normal_user = create(:user) confirmed_user = create(:user, :confirmed) # Shouldn't work when not logged in assert_no_difference "User.active.count" do - post :list, :params => { :hide => 1, :user => { normal_user.id => 1, confirmed_user.id => 1 } } + post :index, :params => { :hide => 1, :user => { normal_user.id => 1, confirmed_user.id => 1 } } end assert_response :redirect assert_redirected_to :action => :login, :referer => users_path @@ -1575,7 +1575,7 @@ class UserControllerTest < ActionController::TestCase # Shouldn't work when logged in as a normal user assert_no_difference "User.active.count" do - post :list, :params => { :hide => 1, :user => { normal_user.id => 1, confirmed_user.id => 1 } } + post :index, :params => { :hide => 1, :user => { normal_user.id => 1, confirmed_user.id => 1 } } end assert_response :redirect assert_redirected_to :action => :login, :referer => users_path @@ -1586,7 +1586,7 @@ class UserControllerTest < ActionController::TestCase # Shouldn't work when logged in as a moderator assert_no_difference "User.active.count" do - post :list, :params => { :hide => 1, :user => { normal_user.id => 1, confirmed_user.id => 1 } } + post :index, :params => { :hide => 1, :user => { normal_user.id => 1, confirmed_user.id => 1 } } end assert_response :redirect assert_redirected_to :action => :login, :referer => users_path @@ -1597,10 +1597,10 @@ class UserControllerTest < ActionController::TestCase # Should work when logged in as an administrator assert_difference "User.active.count", -2 do - post :list, :params => { :hide => 1, :user => { normal_user.id => 1, confirmed_user.id => 1 } } + post :index, :params => { :hide => 1, :user => { normal_user.id => 1, confirmed_user.id => 1 } } end assert_response :redirect - assert_redirected_to :action => :list + assert_redirected_to :action => :index assert_equal "deleted", normal_user.reload.status assert_equal "deleted", confirmed_user.reload.status end