From: Andy Allan <git@gravitystorm.co.uk>
Date: Tue, 15 May 2018 09:33:40 +0000 (+0800)
Subject: Remove unused POST method for message replies
X-Git-Tag: live~3061^2~3
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/40cab845fbabb3f0aa8131c16e48cd3d58b6dcb3

Remove unused POST method for message replies

This action just shows the pre-filled form, with the target for
the form being the same as for new messages.
---

diff --git a/config/routes.rb b/config/routes.rb
index ed5e6876b..44996fd8f 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -266,7 +266,7 @@ OpenStreetMap::Application.routes.draw do
   match "/message/new/:display_name" => "messages#new", :via => [:get, :post], :as => "new_message"
   get "/message/read/:message_id" => "messages#read", :as => "read_message"
   post "/message/mark/:message_id" => "messages#mark", :as => "mark_message"
-  match "/message/reply/:message_id" => "messages#reply", :via => [:get, :post], :as => "reply_message"
+  get "/message/reply/:message_id" => "messages#reply", :as => "reply_message"
   post "/message/delete/:message_id" => "messages#delete", :as => "delete_message"
 
   # oauth admin pages (i.e: for setting up new clients, etc...)
diff --git a/test/controllers/messages_controller_test.rb b/test/controllers/messages_controller_test.rb
index dd9df8f45..d9a1d9b0c 100644
--- a/test/controllers/messages_controller_test.rb
+++ b/test/controllers/messages_controller_test.rb
@@ -32,10 +32,6 @@ class MessagesControllerTest < ActionController::TestCase
       { :path => "/message/reply/1", :method => :get },
       { :controller => "messages", :action => "reply", :message_id => "1" }
     )
-    assert_routing(
-      { :path => "/message/reply/1", :method => :post },
-      { :controller => "messages", :action => "reply", :message_id => "1" }
-    )
     assert_routing(
       { :path => "/message/delete/1", :method => :post },
       { :controller => "messages", :action => "delete", :message_id => "1" }