From: Anton Khorev <tony29@yandex.ru>
Date: Sun, 18 Feb 2024 18:30:07 +0000 (+0300)
Subject: Add element list item helper
X-Git-Tag: live~212^2~2
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/43a4a3a887ef6efb54491f8cc873cc7dc424c1d2

Add element list item helper
---

diff --git a/app/helpers/browse_helper.rb b/app/helpers/browse_helper.rb
index 07fa48daf..29f243cf4 100644
--- a/app/helpers/browse_helper.rb
+++ b/app/helpers/browse_helper.rb
@@ -7,6 +7,12 @@ module BrowseHelper
     end
   end
 
+  def element_list_item(type, object, &block)
+    tag.li :class => element_class(type, object) do
+      element_strikethrough object, &block
+    end
+  end
+
   def printable_name(object, version: false)
     id = if object.id.is_a?(Array)
            object.id[0]
diff --git a/app/views/browse/_relation_member.html.erb b/app/views/browse/_relation_member.html.erb
index 504b945aa..93c33b8a7 100644
--- a/app/views/browse/_relation_member.html.erb
+++ b/app/views/browse/_relation_member.html.erb
@@ -1,12 +1,9 @@
-<% member_class = element_class(relation_member.member_type.downcase, relation_member.member)
-   linked_name = link_to printable_name(relation_member.member), { :controller => :browse, :action => relation_member.member_type.downcase, :id => relation_member.member_id.to_s }, { :title => link_title(relation_member.member), :rel => link_follow(relation_member.member) }
+<% linked_name = link_to printable_name(relation_member.member), { :controller => :browse, :action => relation_member.member_type.downcase, :id => relation_member.member_id.to_s }, { :title => link_title(relation_member.member), :rel => link_follow(relation_member.member) }
    type_str = t ".type.#{relation_member.member_type.downcase}" %>
-<li class="<%= member_class %>">
-  <%= element_strikethrough relation_member.member do %>
-    <%= if relation_member.member_role.blank?
-          t ".entry_html", :type => type_str, :name => linked_name
-        else
-          t ".entry_role_html", :type => type_str, :name => linked_name, :role => relation_member.member_role
-        end %>
-  <% end %>
-</li>
+<%= element_list_item relation_member.member_type.downcase, relation_member.member do %>
+  <%= if relation_member.member_role.blank?
+        t ".entry_html", :type => type_str, :name => linked_name
+      else
+        t ".entry_role_html", :type => type_str, :name => linked_name, :role => relation_member.member_role
+      end %>
+<% end %>
diff --git a/app/views/browse/changeset.html.erb b/app/views/browse/changeset.html.erb
index fcdc8f155..eac8bd472 100644
--- a/app/views/browse/changeset.html.erb
+++ b/app/views/browse/changeset.html.erb
@@ -93,11 +93,9 @@
     <%= render :partial => "paging_nav", :locals => { :heading => type_and_paginated_count("way", @way_pages), :pages => @way_pages, :page_param => "way_page" } %>
     <ul class="list-unstyled">
       <% @ways.each do |way| %>
-        <li class="<%= element_class("way", way) %>">
-          <%= element_strikethrough way do %>
-            <%= link_to printable_name(way, :version => true), { :action => "way", :id => way.way_id.to_s }, { :title => link_title(way) } %>
-          <% end %>
-        </li>
+        <%= element_list_item "way", way do %>
+          <%= link_to printable_name(way, :version => true), { :action => "way", :id => way.way_id.to_s }, { :title => link_title(way) } %>
+        <% end %>
       <% end %>
     </ul>
   <% end %>
@@ -106,11 +104,9 @@
     <%= render :partial => "paging_nav", :locals => { :heading => type_and_paginated_count("relation", @relation_pages), :pages => @relation_pages, :page_param => "relation_page" } %>
     <ul class="list-unstyled">
       <% @relations.each do |relation| %>
-        <li class="<%= element_class("relation", relation) %>">
-          <%= element_strikethrough relation do %>
-            <%= link_to printable_name(relation, :version => true), { :action => "relation", :id => relation.relation_id.to_s }, { :title => link_title(relation) } %>
-          <% end %>
-        </li>
+        <%= element_list_item "relation", relation do %>
+          <%= link_to printable_name(relation, :version => true), { :action => "relation", :id => relation.relation_id.to_s }, { :title => link_title(relation) } %>
+        <% end %>
       <% end %>
     </ul>
   <% end %>
@@ -119,11 +115,9 @@
     <%= render :partial => "paging_nav", :locals => { :heading => type_and_paginated_count("node", @node_pages), :pages => @node_pages, :page_param => "node_page" } %>
     <ul class="list-unstyled">
       <% @nodes.each do |node| %>
-        <li class="<%= element_class("node", node) %>">
-          <%= element_strikethrough node do %>
-            <%= link_to printable_name(node, :version => true), { :action => "node", :id => node.node_id.to_s }, { :title => link_title(node), :rel => link_follow(node) } %>
-          <% end %>
-        </li>
+        <%= element_list_item "node", node do %>
+          <%= link_to printable_name(node, :version => true), { :action => "node", :id => node.node_id.to_s }, { :title => link_title(node), :rel => link_follow(node) } %>
+        <% end %>
       <% end %>
     </ul>
   <% end %>