From: Tom Hughes <tom@compton.nu>
Date: Wed, 28 Sep 2011 17:25:27 +0000 (+0100)
Subject: Create new diary entry records instead of cloning the fixture
X-Git-Tag: live~6087
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/44a9a65aa74cd927bfa3abd3b53569500842b489?hp=97b1290f1a9f784566cc352e744dc2d009ae49ce

Create new diary entry records instead of cloning the fixture

Cloning fixtures doesn't seem to do a deep copy in rails 3.1 so the
attribute changes persist into other future cloned copies of the same
fixture. The fix is to create completely new records for each test.
---

diff --git a/test/unit/diary_entry_test.rb b/test/unit/diary_entry_test.rb
index 54ac0175b..d645aa860 100644
--- a/test/unit/diary_entry_test.rb
+++ b/test/unit/diary_entry_test.rb
@@ -25,9 +25,8 @@ class DiaryEntryTest < ActiveSupport::TestCase
   end
   
   def diary_entry_valid(attrs, result = true)
-    entry = diary_entries(:normal_user_entry_1).clone
+    entry = DiaryEntry.new(diary_entries(:normal_user_entry_1).attributes)
     entry.attributes = attrs
     assert_equal result, entry.valid?, "Expected #{attrs.inspect} to be #{result}"
-  end
-  
+  end  
 end